Compare commits

...

4 Commits

Author SHA1 Message Date
Eric Bailey 5908f83665 Make newskie usage full width 2024-10-17 14:27:43 -05:00
Eric Bailey 256acc143e Rm flex_1 causing overflow 2024-10-17 14:17:56 -05:00
Eric Bailey 1fc55697a7 Fix StarterPackCard Link component 2024-10-17 13:51:14 -05:00
Eric Bailey 2aed0ba060 Remove BaseLink component 2024-10-17 13:47:07 -05:00
3 changed files with 7 additions and 53 deletions
+1 -48
View File
@@ -1,10 +1,5 @@
import React from 'react'
import {
GestureResponderEvent,
Pressable,
StyleProp,
ViewStyle,
} from 'react-native'
import {GestureResponderEvent} from 'react-native'
import {sanitizeUrl} from '@braintree/sanitize-url'
import {StackActions, useLinkProps} from '@react-navigation/native'
@@ -348,48 +343,6 @@ export function createStaticClick(
}
}
/**
* A Pressable that uses useLink to handle navigation. It is unstyled, so can be used in cases where the Button styles
* in Link are not desired.
* @param displayText
* @param style
* @param children
* @param rest
* @constructor
*/
export function BaseLink({
displayText,
onPress: onPressOuter,
style,
children,
...rest
}: {
style?: StyleProp<ViewStyle>
children: React.ReactNode
to: string
action: 'push' | 'replace' | 'navigate'
onPress?: () => false | void
shareOnLongPress?: boolean
label: string
displayText?: string
}) {
const {onPress, ...btnProps} = useLink({
displayText: displayText ?? rest.to,
...rest,
})
return (
<Pressable
style={style}
onPress={e => {
onPressOuter?.()
onPress(e)
}}
{...btnProps}>
{children}
</Pressable>
)
}
export function WebOnlyInlineLinkText({
children,
to,
+1 -1
View File
@@ -127,7 +127,7 @@ export function NewskieDialog({
}}>
<View
style={[
a.flex_1,
a.w_full,
a.mt_sm,
a.p_lg,
a.border,
@@ -13,7 +13,7 @@ import {precacheStarterPack} from '#/state/queries/starter-packs'
import {useSession} from '#/state/session'
import {atoms as a, useTheme} from '#/alf'
import {StarterPack} from '#/components/icons/StarterPack'
import {BaseLink} from '#/components/Link'
import {Link as BaseLink, LinkProps as BaseLinkProps} from '#/components/Link'
import {Text} from '#/components/Typography'
export function Default({
@@ -62,7 +62,7 @@ export function Card({
}
return (
<View style={[a.flex_1, a.gap_md]}>
<View style={[a.w_full, a.gap_md]}>
<View style={[a.flex_row, a.gap_sm]}>
{!noIcon ? <StarterPack width={40} gradient="sky" /> : null}
<View>
@@ -96,7 +96,7 @@ export function Link({
}: {
starterPack: AppBskyGraphDefs.StarterPackViewBasic
onPress?: () => void
children: React.ReactNode
children: BaseLinkProps['children']
}) {
const {_} = useLingui()
const queryClient = useQueryClient()
@@ -123,7 +123,8 @@ export function Link({
starterPack.creator.did,
)
precacheStarterPack(queryClient, starterPack)
}}>
}}
style={[a.flex_col, a.align_start]}>
{children}
</BaseLink>
)