Compare commits

...

2 Commits

Author SHA1 Message Date
Dan Abramov fd1d6d107b Remove same pattern elsewhere to avoid further copypaste 2023-11-28 21:19:40 +00:00
Dan Abramov a7b051d3f5 Fix memory leak on mobile web navigation 2023-11-28 21:19:06 +00:00
2 changed files with 4 additions and 9 deletions
+2 -7
View File
@@ -12,11 +12,7 @@ import {
TouchableWithoutFeedback,
TouchableOpacity,
} from 'react-native'
import {
useLinkProps,
useNavigation,
StackActions,
} from '@react-navigation/native'
import {useLinkProps, useNavigation} from '@react-navigation/native'
import {Text} from './text/Text'
import {TypographyVariant} from 'lib/ThemeContext'
import {NavigationProp} from 'lib/routes/types'
@@ -327,9 +323,8 @@ function onPressInner(
Linking.openURL(href)
} else {
closeModal() // close any active modals
// @ts-ignore we're not able to type check on this one -prf
navigation.dispatch(StackActions.push(...router.matchPath(href)))
navigation.navigate(...router.matchPath(href))
}
}
}
+2 -2
View File
@@ -7,7 +7,7 @@ import {
TouchableOpacity,
ActivityIndicator,
} from 'react-native'
import {useNavigation, StackActions} from '@react-navigation/native'
import {useNavigation} from '@react-navigation/native'
import {
AppBskyActorDefs,
moderateProfile,
@@ -143,7 +143,7 @@ export function DesktopSearch() {
setSearchResults([])
if (searchDebounceTimeout.current)
clearTimeout(searchDebounceTimeout.current)
navigation.dispatch(StackActions.push('Search', {q: query}))
navigation.navigate('Search', {q: query})
}, [query, navigation, setSearchResults])
return (