Update feed drag-and-drop handle icon

src/components/FeedCard.tsx

@@ -6,7 +6,7 @@ import {
   AtUri,
   RichText as RichTextApi,
 } from '@atproto/api'
-import {msg, Plural, Trans} from '@lingui/macro'
+import {msg, Trans} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 import {useQueryClient} from '@tanstack/react-query'
 
@@ -17,8 +17,10 @@ import {
   useAddSavedFeedsMutation,
   usePreferencesQuery,
   useRemoveFeedMutation,
+  useUpdateSavedFeedsMutation,
 } from '#/state/queries/preferences'
 import {useSession} from '#/state/session'
+import {formatCount} from '#/view/com/util/numeric/format'
 import * as Toast from '#/view/com/util/Toast'
 import {UserAvatar} from '#/view/com/util/UserAvatar'
 import {atoms as a, useTheme} from '#/alf'
@@ -28,6 +30,7 @@ import {
   type ButtonProps,
   ButtonText,
 } from '#/components/Button'
+import {Heart2_Filled_Stroke2_Corner0_Rounded as HeartIcon} from '#/components/icons/Heart2'
 import {Pin_Stroke2_Corner0_Rounded as PinIcon} from '#/components/icons/Pin'
 import {Link as InternalLink, type LinkProps} from '#/components/Link'
 import {Loader} from '#/components/Loader'
@@ -134,9 +137,9 @@ export function TitleAndByline({
       </Text>
       {creator && (
         <Text
-          style={[a.leading_snug, t.atoms.text_contrast_medium]}
+          style={[a.text_xs, a.leading_snug, t.atoms.text_contrast_medium]}
           numberOfLines={1}>
-          <Trans>Feed by {sanitizeHandle(creator.handle, '@')}</Trans>
+          <Trans>By {sanitizeHandle(creator.handle, '@')}</Trans>
         </Text>
       )}
     </View>
@@ -213,12 +216,14 @@ export function DescriptionPlaceholder() {
 
 export function Likes({count}: {count: number}) {
   const t = useTheme()
+  const {i18n} = useLingui()
   return (
-    <Text style={[a.text_sm, t.atoms.text_contrast_medium, a.font_semi_bold]}>
-      <Trans>
-        Liked by <Plural value={count || 0} one="# user" other="# users" />
-      </Trans>
-    </Text>
+    <View style={[a.flex_row, a.align_center, {gap: 2}]}>
+      <HeartIcon size="xs" fill={t.atoms.text_contrast_low.color} />
+      <Text style={[a.text_sm, t.atoms.text_contrast_medium]}>
+        {formatCount(i18n, count)}
+      </Text>
+    </View>
   )
 }
 
@@ -252,6 +257,8 @@ function SaveButtonInner({
     useAddSavedFeedsMutation()
   const {isPending: isRemovePending, mutateAsync: removeFeed} =
     useRemoveFeedMutation()
+  const {isPending: isUpdatePending, mutateAsync: updateSavedFeeds} =
+    useUpdateSavedFeedsMutation()
 
   const uri = view.uri
   const type = view.uri.includes('app.bsky.feed.generator') ? 'feed' : 'list'
@@ -259,23 +266,26 @@ function SaveButtonInner({
   const savedFeedConfig = React.useMemo(() => {
     return preferences?.savedFeeds?.find(feed => feed.value === uri)
   }, [preferences?.savedFeeds, uri])
+  const isPinned = savedFeedConfig?.pinned ?? false
   const removePromptControl = Prompt.usePromptControl()
-  const isPending = isAddSavedFeedPending || isRemovePending
+  const isPending = isAddSavedFeedPending || isRemovePending || isUpdatePending
 
-  const toggleSave = React.useCallback(
+  const onPinFeed = React.useCallback(
     async (e: GestureResponderEvent) => {
       e.preventDefault()
       e.stopPropagation()
 
       try {
         if (savedFeedConfig) {
-          await removeFeed(savedFeedConfig)
+          // Feed is saved but not pinned, update it to be pinned
+          await updateSavedFeeds([{...savedFeedConfig, pinned: true}])
         } else {
+          // Feed is not saved, save it with pinned=true
           await saveFeeds([
             {
               type,
               value: uri,
-              pinned: pin || false,
+              pinned: true,
             },
           ])
         }
@@ -285,10 +295,22 @@ function SaveButtonInner({
         Toast.show(_(msg`Failed to update feeds`), 'xmark')
       }
     },
-    [_, pin, saveFeeds, removeFeed, uri, savedFeedConfig, type],
+    [_, pin, saveFeeds, updateSavedFeeds, uri, savedFeedConfig, type],
   )
 
-  const onPrompRemoveFeed = React.useCallback(
+  const onRemoveFeed = React.useCallback(async () => {
+    try {
+      if (savedFeedConfig) {
+        await removeFeed(savedFeedConfig)
+      }
+      Toast.show(_(msg({message: 'Feeds updated!', context: 'toast'})))
+    } catch (err: any) {
+      logger.error(err, {message: `FeedCard: failed to remove feed`})
+      Toast.show(_(msg`Failed to update feeds`), 'xmark')
+    }
+  }, [_, removeFeed, savedFeedConfig])
+
+  const onPromptRemoveFeed = React.useCallback(
     async (e: GestureResponderEvent) => {
       e.preventDefault()
       e.stopPropagation()
@@ -302,13 +324,17 @@ function SaveButtonInner({
     <>
       <Button
         disabled={isPending}
-        label={_(msg`Add this feed to your feeds`)}
+        label={
+          isPinned
+            ? _(msg`Remove this feed from your feeds`)
+            : _(msg`Add this feed to your feeds`)
+        }
         size="small"
         variant="solid"
-        color={savedFeedConfig ? 'secondary' : 'primary'}
-        onPress={savedFeedConfig ? onPrompRemoveFeed : toggleSave}
+        color={isPinned ? 'secondary' : 'primary'}
+        onPress={isPinned ? onPromptRemoveFeed : onPinFeed}
         {...buttonProps}>
-        {savedFeedConfig ? (
+        {isPinned ? (
           <>
             {isPending ? (
               <ButtonIcon size="md" icon={Loader} />
@@ -317,7 +343,7 @@ function SaveButtonInner({
             )}
             {text && (
               <ButtonText>
-                <Trans>Unpin Feed</Trans>
+                <Trans>Unpin</Trans>
               </ButtonText>
             )}
           </>
@@ -326,7 +352,7 @@ function SaveButtonInner({
             <ButtonIcon size="md" icon={isPending ? Loader : PinIcon} />
             {text && (
               <ButtonText>
-                <Trans>Pin Feed</Trans>
+                <Trans>Pin</Trans>
               </ButtonText>
             )}
           </>
@@ -339,7 +365,7 @@ function SaveButtonInner({
         description={_(
           msg`Are you sure you want to remove this from your feeds?`,
         )}
-        onConfirm={toggleSave}
+        onConfirm={onRemoveFeed}
         confirmButtonCta={_(msg`Remove`)}
         confirmButtonColor="negative"
       />

src/components/ListCard.tsx

@@ -145,7 +145,7 @@ export function TitleAndByline({
       {creator && (
         <Text
           emoji
-          style={[a.leading_snug, t.atoms.text_contrast_medium]}
+          style={[a.text_xs, a.leading_snug, t.atoms.text_contrast_medium]}
           numberOfLines={1}>
           {purpose === MODLIST
             ? _(msg`Moderation list by ${sanitizeHandle(creator.handle, '@')}`)

src/components/icons/Grip.tsx

@@ -0,0 +1,5 @@
+import {createSinglePathSVG} from './TEMPLATE'
+
+export const Grip_Stroke2_Corner0_Rounded = createSinglePathSVG({
+  path: 'M 7.5 6 a 1.5 1.5 0 1 0 3 0 a 1.5 1.5 0 1 0 -3 0 M 13.5 6 a 1.5 1.5 0 1 0 3 0 a 1.5 1.5 0 1 0 -3 0 M 7.5 12 a 1.5 1.5 0 1 0 3 0 a 1.5 1.5 0 1 0 -3 0 M 13.5 12 a 1.5 1.5 0 1 0 3 0 a 1.5 1.5 0 1 0 -3 0 M 7.5 18 a 1.5 1.5 0 1 0 3 0 a 1.5 1.5 0 1 0 -3 0 M 13.5 18 a 1.5 1.5 0 1 0 3 0 a 1.5 1.5 0 1 0 -3 0',
+})

src/screens/SavedFeeds.tsx

@@ -1,415 +1,27 @@
-import {useCallback, useState} from 'react'
+import {useEffect} from 'react'
 import {View} from 'react-native'
-import Animated, {LinearTransition} from 'react-native-reanimated'
-import {type AppBskyActorDefs} from '@atproto/api'
-import {TID} from '@atproto/common-web'
-import {msg, Trans} from '@lingui/macro'
-import {useLingui} from '@lingui/react'
-import {useFocusEffect} from '@react-navigation/native'
 import {useNavigation} from '@react-navigation/native'
 import {type NativeStackScreenProps} from '@react-navigation/native-stack'
 
-import {RECOMMENDED_SAVED_FEEDS, TIMELINE_SAVED_FEED} from '#/lib/constants'
-import {useHaptics} from '#/lib/haptics'
 import {
   type CommonNavigatorParams,
   type NavigationProp,
 } from '#/lib/routes/types'
-import {logger} from '#/logger'
-import {
-  useOverwriteSavedFeedsMutation,
-  usePreferencesQuery,
-} from '#/state/queries/preferences'
-import {type UsePreferencesQueryResponse} from '#/state/queries/preferences/types'
-import {useSetMinimalShellMode} from '#/state/shell'
-import {FeedSourceCard} from '#/view/com/feeds/FeedSourceCard'
-import * as Toast from '#/view/com/util/Toast'
-import {NoFollowingFeed} from '#/screens/Feeds/NoFollowingFeed'
-import {NoSavedFeedsOfAnyType} from '#/screens/Feeds/NoSavedFeedsOfAnyType'
-import {atoms as a, useBreakpoints, useTheme} from '#/alf'
-import {Admonition} from '#/components/Admonition'
-import {Button, ButtonIcon, ButtonText} from '#/components/Button'
-import {
-  ArrowBottom_Stroke2_Corner0_Rounded as ArrowDownIcon,
-  ArrowTop_Stroke2_Corner0_Rounded as ArrowUpIcon,
-} from '#/components/icons/Arrow'
-import {FilterTimeline_Stroke2_Corner0_Rounded as FilterTimeline} from '#/components/icons/FilterTimeline'
-import {FloppyDisk_Stroke2_Corner0_Rounded as SaveIcon} from '#/components/icons/FloppyDisk'
-import {Pin_Filled_Corner0_Rounded as PinIcon} from '#/components/icons/Pin'
-import {Trash_Stroke2_Corner0_Rounded as TrashIcon} from '#/components/icons/Trash'
-import * as Layout from '#/components/Layout'
-import {InlineLinkText} from '#/components/Link'
-import {Loader} from '#/components/Loader'
-import {Text} from '#/components/Typography'
 
 type Props = NativeStackScreenProps<CommonNavigatorParams, 'SavedFeeds'>
-export function SavedFeeds({}: Props) {
-  const {data: preferences} = usePreferencesQuery()
-  if (!preferences) {
-    return <View />
-  }
-  return <SavedFeedsInner preferences={preferences} />
-}
 
-function SavedFeedsInner({
-  preferences,
-}: {
-  preferences: UsePreferencesQueryResponse
-}) {
-  const t = useTheme()
-  const {_} = useLingui()
-  const {gtMobile} = useBreakpoints()
-  const setMinimalShellMode = useSetMinimalShellMode()
-  const {mutateAsync: overwriteSavedFeeds, isPending: isOverwritePending} =
-    useOverwriteSavedFeedsMutation()
+/**
+ * This screen has been consolidated into the main Feeds screen.
+ * Redirect users there automatically.
+ */
+export function SavedFeeds({}: Props) {
   const navigation = useNavigation<NavigationProp>()
 
-  /*
-   * Use optimistic data if exists and no error, otherwise fallback to remote
-   * data
-   */
-  const [currentFeeds, setCurrentFeeds] = useState(
-    () => preferences.savedFeeds || [],
-  )
-  const hasUnsavedChanges = currentFeeds !== preferences.savedFeeds
-  const pinnedFeeds = currentFeeds.filter(f => f.pinned)
-  const unpinnedFeeds = currentFeeds.filter(f => !f.pinned)
-  const noSavedFeedsOfAnyType = pinnedFeeds.length + unpinnedFeeds.length === 0
-  const noFollowingFeed =
-    currentFeeds.every(f => f.type !== 'timeline') && !noSavedFeedsOfAnyType
+  useEffect(() => {
+    // Replace current screen with Feeds to avoid back-navigation issues
+    navigation.replace('Feeds')
+  }, [navigation])
 
-  useFocusEffect(
-    useCallback(() => {
-      setMinimalShellMode(false)
-    }, [setMinimalShellMode]),
-  )
-
-  const onSaveChanges = async () => {
-    try {
-      await overwriteSavedFeeds(currentFeeds)
-      Toast.show(_(msg({message: 'Feeds updated!', context: 'toast'})))
-      if (navigation.canGoBack()) {
-        navigation.goBack()
-      } else {
-        navigation.navigate('Feeds')
-      }
-    } catch (e) {
-      Toast.show(_(msg`There was an issue contacting the server`), 'xmark')
-      logger.error('Failed to toggle pinned feed', {message: e})
-    }
-  }
-
-  return (
-    <Layout.Screen>
-      <Layout.Header.Outer>
-        <Layout.Header.BackButton />
-        <Layout.Header.Content align="left">
-          <Layout.Header.TitleText>
-            <Trans>Feeds</Trans>
-          </Layout.Header.TitleText>
-        </Layout.Header.Content>
-        <Button
-          testID="saveChangesBtn"
-          size="small"
-          color={hasUnsavedChanges ? 'primary' : 'secondary'}
-          onPress={onSaveChanges}
-          label={_(msg`Save changes`)}
-          disabled={isOverwritePending || !hasUnsavedChanges}>
-          <ButtonIcon icon={isOverwritePending ? Loader : SaveIcon} />
-          <ButtonText>
-            {gtMobile ? <Trans>Save changes</Trans> : <Trans>Save</Trans>}
-          </ButtonText>
-        </Button>
-      </Layout.Header.Outer>
-
-      <Layout.Content>
-        {noSavedFeedsOfAnyType && (
-          <View style={[t.atoms.border_contrast_low, a.border_b]}>
-            <NoSavedFeedsOfAnyType
-              onAddRecommendedFeeds={() =>
-                setCurrentFeeds(
-                  RECOMMENDED_SAVED_FEEDS.map(f => ({
-                    ...f,
-                    id: TID.nextStr(),
-                  })),
-                )
-              }
-            />
-          </View>
-        )}
-
-        <SectionHeaderText>
-          <Trans>Pinned Feeds</Trans>
-        </SectionHeaderText>
-
-        {preferences ? (
-          !pinnedFeeds.length ? (
-            <View style={[a.flex_1, a.p_lg]}>
-              <Admonition type="info">
-                <Trans>You don't have any pinned feeds.</Trans>
-              </Admonition>
-            </View>
-          ) : (
-            pinnedFeeds.map(f => (
-              <ListItem
-                key={f.id}
-                feed={f}
-                isPinned
-                currentFeeds={currentFeeds}
-                setCurrentFeeds={setCurrentFeeds}
-                preferences={preferences}
-              />
-            ))
-          )
-        ) : (
-          <View style={[a.w_full, a.py_2xl, a.align_center]}>
-            <Loader size="xl" />
-          </View>
-        )}
-
-        {noFollowingFeed && (
-          <View style={[t.atoms.border_contrast_low, a.border_b]}>
-            <NoFollowingFeed
-              onAddFeed={() =>
-                setCurrentFeeds(feeds => [
-                  ...feeds,
-                  {...TIMELINE_SAVED_FEED, id: TID.next().toString()},
-                ])
-              }
-            />
-          </View>
-        )}
-
-        <SectionHeaderText>
-          <Trans>Saved Feeds</Trans>
-        </SectionHeaderText>
-
-        {preferences ? (
-          !unpinnedFeeds.length ? (
-            <View style={[a.flex_1, a.p_lg]}>
-              <Admonition type="info">
-                <Trans>You don't have any saved feeds.</Trans>
-              </Admonition>
-            </View>
-          ) : (
-            unpinnedFeeds.map(f => (
-              <ListItem
-                key={f.id}
-                feed={f}
-                isPinned={false}
-                currentFeeds={currentFeeds}
-                setCurrentFeeds={setCurrentFeeds}
-                preferences={preferences}
-              />
-            ))
-          )
-        ) : (
-          <View style={[a.w_full, a.py_2xl, a.align_center]}>
-            <Loader size="xl" />
-          </View>
-        )}
-
-        <View style={[a.px_lg, a.py_xl]}>
-          <Text
-            style={[a.text_sm, t.atoms.text_contrast_medium, a.leading_snug]}>
-            <Trans>
-              Feeds are custom algorithms that users build with a little coding
-              expertise.{' '}
-              <InlineLinkText
-                to="https://github.com/bluesky-social/feed-generator"
-                label={_(msg`See this guide`)}
-                disableMismatchWarning
-                style={[a.leading_snug]}>
-                See this guide
-              </InlineLinkText>{' '}
-              for more information.
-            </Trans>
-          </Text>
-        </View>
-      </Layout.Content>
-    </Layout.Screen>
-  )
-}
-
-function ListItem({
-  feed,
-  isPinned,
-  currentFeeds,
-  setCurrentFeeds,
-}: {
-  feed: AppBskyActorDefs.SavedFeed
-  isPinned: boolean
-  currentFeeds: AppBskyActorDefs.SavedFeed[]
-  setCurrentFeeds: React.Dispatch<AppBskyActorDefs.SavedFeed[]>
-  preferences: UsePreferencesQueryResponse
-}) {
-  const {_} = useLingui()
-  const t = useTheme()
-  const playHaptic = useHaptics()
-  const feedUri = feed.value
-
-  const onTogglePinned = async () => {
-    playHaptic()
-    setCurrentFeeds(
-      currentFeeds.map(f =>
-        f.id === feed.id ? {...feed, pinned: !feed.pinned} : f,
-      ),
-    )
-  }
-
-  const onPressUp = async () => {
-    if (!isPinned) return
-
-    const nextFeeds = currentFeeds.slice()
-    const ids = currentFeeds.map(f => f.id)
-    const index = ids.indexOf(feed.id)
-    const nextIndex = index - 1
-
-    if (index === -1 || index === 0) return
-    ;[nextFeeds[index], nextFeeds[nextIndex]] = [
-      nextFeeds[nextIndex],
-      nextFeeds[index],
-    ]
-
-    setCurrentFeeds(nextFeeds)
-  }
-
-  const onPressDown = async () => {
-    if (!isPinned) return
-
-    const nextFeeds = currentFeeds.slice()
-    const ids = currentFeeds.map(f => f.id)
-    const index = ids.indexOf(feed.id)
-    const nextIndex = index + 1
-
-    if (index === -1 || index >= nextFeeds.filter(f => f.pinned).length - 1)
-      return
-    ;[nextFeeds[index], nextFeeds[nextIndex]] = [
-      nextFeeds[nextIndex],
-      nextFeeds[index],
-    ]
-
-    setCurrentFeeds(nextFeeds)
-  }
-
-  const onPressRemove = async () => {
-    playHaptic()
-    setCurrentFeeds(currentFeeds.filter(f => f.id !== feed.id))
-  }
-
-  return (
-    <Animated.View
-      style={[a.flex_row, a.border_b, t.atoms.border_contrast_low]}
-      layout={LinearTransition.duration(100)}>
-      {feed.type === 'timeline' ? (
-        <FollowingFeedCard />
-      ) : (
-        <FeedSourceCard
-          key={feedUri}
-          feedUri={feedUri}
-          style={[isPinned && a.pr_sm]}
-          showMinimalPlaceholder
-          hideTopBorder={true}
-        />
-      )}
-      <View style={[a.pr_lg, a.flex_row, a.align_center, a.gap_sm]}>
-        {isPinned ? (
-          <>
-            <Button
-              testID={`feed-${feed.type}-moveUp`}
-              label={_(msg`Move feed up`)}
-              onPress={onPressUp}
-              size="small"
-              color="secondary"
-              shape="square">
-              <ButtonIcon icon={ArrowUpIcon} />
-            </Button>
-            <Button
-              testID={`feed-${feed.type}-moveDown`}
-              label={_(msg`Move feed down`)}
-              onPress={onPressDown}
-              size="small"
-              color="secondary"
-              shape="square">
-              <ButtonIcon icon={ArrowDownIcon} />
-            </Button>
-          </>
-        ) : (
-          <Button
-            testID={`feed-${feedUri}-toggleSave`}
-            label={_(msg`Remove from my feeds`)}
-            onPress={onPressRemove}
-            size="small"
-            color="secondary"
-            variant="ghost"
-            shape="square">
-            <ButtonIcon icon={TrashIcon} />
-          </Button>
-        )}
-        <Button
-          testID={`feed-${feed.type}-togglePin`}
-          label={isPinned ? _(msg`Unpin feed`) : _(msg`Pin feed`)}
-          onPress={onTogglePinned}
-          size="small"
-          color={isPinned ? 'primary_subtle' : 'secondary'}
-          shape="square">
-          <ButtonIcon icon={PinIcon} />
-        </Button>
-      </View>
-    </Animated.View>
-  )
-}
-
-function SectionHeaderText({children}: {children: React.ReactNode}) {
-  const t = useTheme()
-  // eslint-disable-next-line bsky-internal/avoid-unwrapped-text
-  return (
-    <View
-      style={[
-        a.flex_row,
-        a.flex_1,
-        a.px_lg,
-        a.pt_2xl,
-        a.pb_md,
-        a.border_b,
-        t.atoms.border_contrast_low,
-      ]}>
-      <Text style={[a.text_xl, a.font_bold, a.leading_snug]}>{children}</Text>
-    </View>
-  )
-}
-
-function FollowingFeedCard() {
-  const t = useTheme()
-  return (
-    <View style={[a.flex_row, a.align_center, a.flex_1, a.p_lg]}>
-      <View
-        style={[
-          a.align_center,
-          a.justify_center,
-          a.rounded_sm,
-          a.mr_md,
-          {
-            width: 36,
-            height: 36,
-            backgroundColor: t.palette.primary_500,
-          },
-        ]}>
-        <FilterTimeline
-          style={[
-            {
-              width: 22,
-              height: 22,
-            },
-          ]}
-          fill={t.palette.white}
-        />
-      </View>
-      <View style={[a.flex_1, a.flex_row, a.gap_sm, a.align_center]}>
-        <Text style={[a.text_sm, a.font_semi_bold, a.leading_snug]}>
-          <Trans context="feed-name">Following</Trans>
-        </Text>
-      </View>
-    </View>
-  )
+  // Show empty view while redirecting
+  return <View />
 }

src/state/queries/preferences/index.ts

@@ -209,13 +209,48 @@ export function useOverwriteSavedFeedsMutation() {
   const queryClient = useQueryClient()
   const agent = useAgent()
 
-  return useMutation<void, unknown, AppBskyActorDefs.SavedFeed[]>({
+  return useMutation<
+    void,
+    unknown,
+    AppBskyActorDefs.SavedFeed[],
+    {previousPrefs: UsePreferencesQueryResponse | undefined}
+  >({
     mutationFn: async savedFeeds => {
       await agent.overwriteSavedFeeds(savedFeeds)
-      // triggers a refetch
-      await queryClient.invalidateQueries({
-        queryKey: preferencesQueryKey,
-      })
+    },
+    onMutate: async newSavedFeeds => {
+      // Cancel any outgoing refetches so they don't overwrite our optimistic update
+      await queryClient.cancelQueries({queryKey: preferencesQueryKey})
+
+      // Snapshot the previous value
+      const previousPrefs =
+        queryClient.getQueryData<UsePreferencesQueryResponse>(
+          preferencesQueryKey,
+        )
+
+      // Optimistically update the cache
+      if (previousPrefs) {
+        queryClient.setQueryData<UsePreferencesQueryResponse>(
+          preferencesQueryKey,
+          {
+            ...previousPrefs,
+            savedFeeds: newSavedFeeds,
+          },
+        )
+      }
+
+      // Return context with the previous value for rollback
+      return {previousPrefs}
+    },
+    onError: (_err, _newSavedFeeds, context) => {
+      // Rollback to the previous value on error
+      if (context?.previousPrefs) {
+        queryClient.setQueryData(preferencesQueryKey, context.previousPrefs)
+      }
+    },
+    onSettled: () => {
+      // Always refetch after error or success to ensure server state consistency
+      queryClient.invalidateQueries({queryKey: preferencesQueryKey})
     },
   })
 }
@@ -227,14 +262,51 @@ export function useAddSavedFeedsMutation() {
   return useMutation<
     void,
     unknown,
-    Pick<AppBskyActorDefs.SavedFeed, 'type' | 'value' | 'pinned'>[]
+    Pick<AppBskyActorDefs.SavedFeed, 'type' | 'value' | 'pinned'>[],
+    {previousPrefs: UsePreferencesQueryResponse | undefined}
   >({
     mutationFn: async savedFeeds => {
       await agent.addSavedFeeds(savedFeeds)
-      // triggers a refetch
-      await queryClient.invalidateQueries({
-        queryKey: preferencesQueryKey,
-      })
+    },
+    onMutate: async newFeeds => {
+      // Cancel any outgoing refetches so they don't overwrite our optimistic update
+      await queryClient.cancelQueries({queryKey: preferencesQueryKey})
+
+      // Snapshot the previous value
+      const previousPrefs =
+        queryClient.getQueryData<UsePreferencesQueryResponse>(
+          preferencesQueryKey,
+        )
+
+      // Optimistically update the cache
+      if (previousPrefs) {
+        // Generate temporary IDs for new feeds
+        const newSavedFeeds = newFeeds.map((feed, index) => ({
+          ...feed,
+          id: `temp-${Date.now()}-${index}`,
+        }))
+
+        queryClient.setQueryData<UsePreferencesQueryResponse>(
+          preferencesQueryKey,
+          {
+            ...previousPrefs,
+            savedFeeds: [...previousPrefs.savedFeeds, ...newSavedFeeds],
+          },
+        )
+      }
+
+      // Return context with the previous value for rollback
+      return {previousPrefs}
+    },
+    onError: (_err, _newFeeds, context) => {
+      // Rollback to the previous value on error
+      if (context?.previousPrefs) {
+        queryClient.setQueryData(preferencesQueryKey, context.previousPrefs)
+      }
+    },
+    onSettled: () => {
+      // Always refetch after error or success to ensure server state consistency
+      queryClient.invalidateQueries({queryKey: preferencesQueryKey})
     },
   })
 }

src/view/com/feeds/FeedSourceCard.tsx

@@ -193,7 +193,7 @@ export function FeedSourceCardLoaded({
         }}
         style={[
           a.flex_1,
-          a.p_lg,
+          a.p_md,
           a.gap_md,
           !hideTopBorder && !a.border_t,
           t.atoms.border_contrast_low,
@@ -207,7 +207,7 @@ export function FeedSourceCardLoaded({
       <View
         style={[
           a.flex_1,
-          a.p_lg,
+          a.p_md,
           a.gap_md,
           !hideTopBorder && !a.border_t,
           t.atoms.border_contrast_low,

src/view/screens/Home.tsx

@@ -1,6 +1,7 @@
 import React from 'react'
 import {ActivityIndicator, StyleSheet} from 'react-native'
 import {useFocusEffect} from '@react-navigation/native'
+import {useQueryClient} from '@tanstack/react-query'
 
 import {PROD_DEFAULT_FEED} from '#/lib/constants'
 import {useNonReactiveCallback} from '#/lib/hooks/useNonReactiveCallback'
@@ -19,7 +20,10 @@ import {
   usePinnedFeedsInfos,
 } from '#/state/queries/feed'
 import {type FeedDescriptor, type FeedParams} from '#/state/queries/post-feed'
-import {usePreferencesQuery} from '#/state/queries/preferences'
+import {
+  preferencesQueryKey,
+  usePreferencesQuery,
+} from '#/state/queries/preferences'
 import {type UsePreferencesQueryResponse} from '#/state/queries/preferences/types'
 import {useSession} from '#/state/session'
 import {useSetMinimalShellMode} from '#/state/shell'
@@ -41,12 +45,20 @@ import {useDemoMode} from '#/storage/hooks/demo-mode'
 
 type Props = NativeStackScreenProps<HomeTabNavigatorParams, 'Home' | 'Start'>
 export function HomeScreen(props: Props) {
+  const queryClient = useQueryClient()
   const {setShowLoggedOut} = useLoggedOutViewControls()
   const {data: preferences} = usePreferencesQuery()
   const {currentAccount} = useSession()
   const {data: pinnedFeedInfos, isLoading: isPinnedFeedsLoading} =
     usePinnedFeedsInfos()
 
+  // Refetch preferences when Home gains focus to sync feed changes
+  useFocusEffect(
+    React.useCallback(() => {
+      queryClient.invalidateQueries({queryKey: preferencesQueryKey})
+    }, [queryClient]),
+  )
+
   React.useEffect(() => {
     if (isWeb && !currentAccount) {
       const getParams = new URLSearchParams(window.location.search)