Commit Graph

7816 Commits

Author SHA1 Message Date
Claude 34d347400a Use snug leading for the notification author name
The author name link was the only `leading_tight` fragment in the notification
text. It is also the paragraph's first fragment, and TextKit takes paragraph
line metrics from the paragraph's first character, so it set the line height for
the whole block: every line laid out at 17pt instead of the 20pt the
surrounding text asks for (measured 51px line spacing at @3x).

That also squeezed the inline badges. At 17pt the ascent budget is 13.4pt, less
than the 14pt badge box, so TextKit had to shift the attachment up to make it
fit and the box bottom no longer landed on the baseline. With snug leading the
ascent budget is 16.4pt and the box sits where `RCTTextLayoutManager` puts it,
which is what the cap-height sizing assumes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Pgeau3P52qsMTcnDeJm8Zn
2026-07-25 09:48:22 +00:00
Claude 8b06b18cd5 Fix inline profile badge alignment in notifications on iOS new arch
The verification/bot/beta badges rendered inline after the author name in a
notification row ("liked by xyz") sat too high on iOS after the new
architecture switch.

The badges are a `View` nested inside a `<Text>`, so iOS lays them out as a
text attachment. The old architecture measured the attachment box with
`sizeThatFitsMinimumSize:` (which folds the inline view's margins into the box)
and positioned it at `lineFragmentBottom - boxHeight + font.descender`, so the
`marginBottom: -6` hack shifted the badges down. On the new architecture
`ParagraphShadowNode` measures the box with `LayoutableShadowNode::measure`,
which returns the node's own frame size with margins excluded, and then
overwrites the box origin with the frame `RCTTextLayoutManager` computed at
`lineTop + baseline - boxHeight`. Margins and `top` are both ignored, leaving
the badges pinned to the text baseline.

Box height is the only remaining lever, so add an `inlineFontSize` prop to
`ProfileBadges` that constrains the container to the cap height of the
surrounding text. The box then covers exactly the capital letters and the
existing `align_center` centers the badges on them, regardless of which badges
are visible or how tall they are.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Pgeau3P52qsMTcnDeJm8Zn
2026-07-25 08:21:33 +00:00
Samuel Newman d5e335e575 Update version to v1.130.0 (#11274) 2026-07-25 10:58:03 +03:00
Austin McKinley 76a928a7af ci: skip the per-PR OTA job for bot authors (#11273)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-24 19:07:57 -07:00
Austin McKinley 9eb78c0f6c ci: publish OTA to denis (S3) + automatic per-PR previews (#11235)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-24 18:18:00 -07:00
Eric Bailey fb8bda861b Add new config to lingui too (#11270) 2026-07-24 16:19:11 -05:00
estrattonbailey afd267bd2b Nightly source-language update 2026-07-24 17:57:36 +00:00
DS Boyce 93cb42b9f2 Tweak advanced search UI for better localization (#11266) 2026-07-24 10:40:37 -07:00
DS Boyce 549e3d7a7d Fix issue where form controls appear above sticky headers (#11254) 2026-07-24 10:40:16 -07:00
Samuel Newman 74a89832a3 v1.129.0 release prep (#11265) 1.129.0 2026-07-24 09:43:38 -07:00
Samuel Newman 19b0d89313 Update react-native-uitextview (#11264) 2026-07-24 07:40:46 -07:00
Spence Pope 98e135f489 Fix native signup captcha interactions (#11263) 2026-07-24 08:46:59 -04:00
Samuel Newman fbb0ee38c2 Add hitslop to switch account ... menu (#11262) 2026-07-24 05:44:45 -07:00
Eric Bailey 7bd27e4180 Add intl note on OTA flow (#11241) 2026-07-24 03:48:55 -07:00
dependabot[bot] 07a810945d Bump github.com/hashicorp/go-retryablehttp from 0.7.5 to 0.7.7 in /bskyweb (#11257)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-24 03:48:39 -07:00
Samuel Newman 63b284030a Fix Maestro E2E regressions on iOS and Android (#11258) 2026-07-24 03:48:03 -07:00
Samuel Newman 3b6fbf315b Fix Maestro E2E runtime environment (#11247) 2026-07-24 03:30:10 -07:00
DS Boyce 97169dbc35 Tweak appearance of trending topics (#11253) 2026-07-24 03:29:55 -07:00
Tomasz Zawadzki 22a4958321 Migrate useScrollViewOffset to useScrollOffset (#11250) 2026-07-24 07:09:01 +03:00
pfrazee a9df815bd0 Nightly source-language update 2026-07-24 03:10:54 +00:00
Eric Bailey a53df16e82 Update API package and filter AA configs by platform (#11244) 2026-07-23 14:15:09 -05:00
Samuel Newman 4e3d1704a6 Fix scroll forwarder web entrypoint (#11245) 2026-07-23 11:17:36 -07:00
DS Boyce 723a60e979 Display post counts greater than 1,000 (#11242) 2026-07-23 10:26:47 -07:00
Spence Pope 325246ec6c Stub RN codegen native component on web (#11240) 2026-07-23 12:52:47 -04:00
DS Boyce 10b027c35b Sort follows and following behind gate (#11237) 2026-07-23 09:02:35 -07:00
Oleksii Bulenok 8d64ab9d4b React Native New Arch (#10980) 2026-07-23 18:25:40 +03:00
pfrazee b80d09000f Nightly source-language update 2026-07-23 03:11:00 +00:00
DS Boyce f38f84e1a3 Enable sharing a post to a new group chat (#11191) 2026-07-22 15:54:46 -07:00
DS Boyce 8d7a7369aa Display beta badge when isBetaUser is true (#11160) 2026-07-22 15:06:08 -07:00
DS Boyce 77bbe8d8a0 Add From: Me to advanced search filters (#11126) 2026-07-22 15:01:24 -07:00
DS Boyce 850765bc8d Tweak loading state for block dialog (#11236) 2026-07-22 14:56:25 -07:00
DS Boyce 8ca8176eb1 Update presentation of trending feeds (#11206) 2026-07-22 14:35:45 -07:00
DS Boyce c71a4f8360 Create new trending feeds interstitial (#11207) 2026-07-22 14:23:01 -07:00
DS Boyce b2de086c3b Update presentation of trending topics in Explore (#11227) 2026-07-22 13:58:26 -07:00
DS Boyce 933ba1c373 Add feature gate for starter pack search (#11234) 2026-07-22 13:22:56 -07:00
DS Boyce 0bd6a99613 Pass recId with trending topic click metrics (#11232) 2026-07-22 12:51:49 -07:00
Samuel Newman f62e54ec82 Use stable tsgolint (#11229) 2026-07-22 07:39:11 -07:00
pfrazee 676f3f9e1a Nightly source-language update 2026-07-22 03:10:59 +00:00
Spence Pope 26ce5f0934 Hide video pillarboxing on web when the card fits (#11118) 2026-07-21 16:39:51 -05:00
Alex Benzer 44b1ab08b5 Move known likers below stats row; restore original order in stats row (#11192) 2026-07-21 15:40:30 -05:00
RetroSunstar c70baff709 Squish separate imports from the same source in ActivityNotificationSettings (#11225) 2026-07-21 23:25:15 +03:00
DS Boyce cbf0d89128 Remove console.log, address lint (#11228) 2026-07-21 23:25:01 +03:00
DS Boyce 86f0bedfbe Add new search results tab for starter packs (#11226) 2026-07-21 13:18:12 -07:00
Spence Pope 26143c1a48 add client event for failed video playback (#11170) 2026-07-21 11:32:53 -04:00
Samuel Newman 6fea12480a TypeScript 7 (attempt 2) (#11169) 2026-07-21 05:21:51 -07:00
DS Boyce 92ec563f9d Restore activity notification subscriptions screen (#11201) 2026-07-21 05:16:22 -07:00
dependabot[bot] 7d4b91dd38 Bump the actions group with 4 updates (#11202)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-21 05:09:01 -07:00
dependabot[bot] 3eab767e89 Bump actions/setup-node from 6.4.0 to 7.0.0 (#11203)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-21 05:08:41 -07:00
Spence Pope 0ba78623d6 Fix image menu in landscape orientation (#11188) 2026-07-21 05:07:43 -07:00
pfrazee daa11b63e7 Nightly source-language update 2026-07-21 03:10:47 +00:00