Clean up more naming

This commit is contained in:
Eric Bailey
2025-01-16 17:44:22 -06:00
parent e37256a30a
commit f6eca73b85
4 changed files with 21 additions and 19 deletions
+2 -2
View File
@@ -89,7 +89,7 @@ import {Wizard} from '#/screens/StarterPack/Wizard'
import {useTheme} from '#/alf' import {useTheme} from '#/alf'
import {router} from '#/routes' import {router} from '#/routes'
import {Referrer} from '../modules/expo-bluesky-swiss-army' import {Referrer} from '../modules/expo-bluesky-swiss-army'
import {VibeScreen} from './screens/Feeds/VibeScreen' import {VideoFeed} from './screens/Feeds/VibeScreen'
import {AboutSettingsScreen} from './screens/Settings/AboutSettings' import {AboutSettingsScreen} from './screens/Settings/AboutSettings'
import {AccessibilitySettingsScreen} from './screens/Settings/AccessibilitySettings' import {AccessibilitySettingsScreen} from './screens/Settings/AccessibilitySettings'
import {AccountSettingsScreen} from './screens/Settings/AccountSettings' import {AccountSettingsScreen} from './screens/Settings/AccountSettings'
@@ -425,7 +425,7 @@ function commonScreens(Stack: typeof HomeTab, unreadCountLabel?: string) {
/> />
<Stack.Screen <Stack.Screen
name="VideoFeed" name="VideoFeed"
getComponent={() => VibeScreen} getComponent={() => VideoFeed}
options={{ options={{
title: title(msg`Video Feed`), title: title(msg`Video Feed`),
requireAuth: true, requireAuth: true,
+4 -4
View File
@@ -131,16 +131,16 @@ export type LogEvents = {
doesPosterFollowLiker: boolean | undefined doesPosterFollowLiker: boolean | undefined
likerClout: number | undefined likerClout: number | undefined
postClout: number | undefined postClout: number | undefined
logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo'
} }
'post:repost': { 'post:repost': {
logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo'
} }
'post:unlike': { 'post:unlike': {
logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo'
} }
'post:unrepost': { 'post:unrepost': {
logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo'
} }
'post:mute': {} 'post:mute': {}
'post:unmute': {} 'post:unmute': {}
+14 -12
View File
@@ -66,8 +66,10 @@ function createThreeVideoPlayers(
return [p1, p2, p3] return [p1, p2, p3]
} }
type Props = NativeStackScreenProps<CommonNavigatorParams, 'VideoFeed'> export function VideoFeed({}: NativeStackScreenProps<
export function VibeScreen({}: Props) { CommonNavigatorParams,
'VideoFeed'
>) {
const {top} = useSafeAreaInsets() const {top} = useSafeAreaInsets()
const setMinShellMode = useSetMinimalShellMode() const setMinShellMode = useSetMinimalShellMode()
@@ -96,19 +98,19 @@ export function VibeScreen({}: Props) {
<Layout.Header.Content> <Layout.Header.Content>
<Layout.Header.TitleText> <Layout.Header.TitleText>
{/* TODO: needs to be feed name */} {/* TODO: needs to be feed name */}
<Trans>Vibes (wip)</Trans> <Trans>Videos</Trans>
</Layout.Header.TitleText> </Layout.Header.TitleText>
</Layout.Header.Content> </Layout.Header.Content>
<Layout.Header.Slot /> <Layout.Header.Slot />
</Layout.Header.Outer> </Layout.Header.Outer>
</View> </View>
<YoloFeed /> <Inner />
</Layout.Screen> </Layout.Screen>
</ThemeProvider> </ThemeProvider>
) )
} }
function YoloFeed() { function Inner() {
const {params} = useRoute<RouteProp<CommonNavigatorParams, 'VideoFeed'>>() const {params} = useRoute<RouteProp<CommonNavigatorParams, 'VideoFeed'>>()
const isFocused = useIsFocused() const isFocused = useIsFocused()
const feedDesc = useMemo(() => { const feedDesc = useMemo(() => {
@@ -161,7 +163,7 @@ function YoloFeed() {
const currentSource = currentSources[index % 3] const currentSource = currentSources[index % 3]
return ( return (
<VibeItem <VideoItem
player={player} player={player}
post={post} post={post}
embed={post.embed} embed={post.embed}
@@ -330,7 +332,7 @@ function keyExtractor(item: FeedPostSliceItem) {
return item._reactKey return item._reactKey
} }
function VibeItem({ function VideoItem({
player, player,
post, post,
embed, embed,
@@ -353,7 +355,7 @@ function VibeItem({
}}> }}>
<SafeAreaView edges={['left', 'right', 'bottom']} style={[a.flex_1]}> <SafeAreaView edges={['left', 'right', 'bottom']} style={[a.flex_1]}>
{player ? ( {player ? (
<VibeItemInner player={player} embed={embed} active={active} /> <VideoItemInner player={player} embed={embed} active={active} />
) : ( ) : (
embed.thumbnail && ( embed.thumbnail && (
<Image <Image
@@ -374,7 +376,7 @@ function VibeItem({
) )
)} )}
{postShadow !== POST_TOMBSTONE ? ( {postShadow !== POST_TOMBSTONE ? (
player && <VibeOverlay player={player} post={postShadow} /> player && <Overlay player={player} post={postShadow} />
) : ( ) : (
<View <View
style={[ style={[
@@ -402,7 +404,7 @@ function VibeItem({
) )
} }
function VibeItemInner({ function VideoItemInner({
player, player,
embed, embed,
active, active,
@@ -453,7 +455,7 @@ function VibeItemInner({
) )
} }
function VibeOverlay({ function Overlay({
player, player,
post, post,
}: { }: {
@@ -465,7 +467,7 @@ function VibeOverlay({
const navigation = useNavigation<NavigationProp>() const navigation = useNavigation<NavigationProp>()
const {status} = useEvent(player, 'statusChange', {status: player.status}) const {status} = useEvent(player, 'statusChange', {status: player.status})
const doubleTapRef = useRef<ReturnType<typeof setTimeout> | null>(null) const doubleTapRef = useRef<ReturnType<typeof setTimeout> | null>(null)
const [queueLike] = usePostLikeMutationQueue(post, 'Vibe') const [queueLike] = usePostLikeMutationQueue(post, 'ImmersiveVideo')
const pushToProfile = useNonReactiveCallback(() => { const pushToProfile = useNonReactiveCallback(() => {
navigation.navigate('Profile', {name: post.author.did}) navigation.navigate('Profile', {name: post.author.did})
+1 -1
View File
@@ -69,7 +69,7 @@ let PostCtrls = ({
style?: StyleProp<ViewStyle> style?: StyleProp<ViewStyle>
onPressReply: () => void onPressReply: () => void
onPostReply?: (postUri: string | undefined) => void onPostReply?: (postUri: string | undefined) => void
logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo'
threadgateRecord?: AppBskyFeedThreadgate.Record threadgateRecord?: AppBskyFeedThreadgate.Record
}): React.ReactNode => { }): React.ReactNode => {
const t = useTheme() const t = useTheme()