From f6eca73b8546d019cb0b2a3fb13703f833a6c173 Mon Sep 17 00:00:00 2001 From: Eric Bailey Date: Thu, 16 Jan 2025 17:44:22 -0600 Subject: [PATCH] Clean up more naming --- src/Navigation.tsx | 4 ++-- src/lib/statsig/events.ts | 8 +++---- src/screens/Feeds/VibeScreen.tsx | 26 ++++++++++++---------- src/view/com/util/post-ctrls/PostCtrls.tsx | 2 +- 4 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src/Navigation.tsx b/src/Navigation.tsx index 378c4ff76b..d637c4efe5 100644 --- a/src/Navigation.tsx +++ b/src/Navigation.tsx @@ -89,7 +89,7 @@ import {Wizard} from '#/screens/StarterPack/Wizard' import {useTheme} from '#/alf' import {router} from '#/routes' import {Referrer} from '../modules/expo-bluesky-swiss-army' -import {VibeScreen} from './screens/Feeds/VibeScreen' +import {VideoFeed} from './screens/Feeds/VibeScreen' import {AboutSettingsScreen} from './screens/Settings/AboutSettings' import {AccessibilitySettingsScreen} from './screens/Settings/AccessibilitySettings' import {AccountSettingsScreen} from './screens/Settings/AccountSettings' @@ -425,7 +425,7 @@ function commonScreens(Stack: typeof HomeTab, unreadCountLabel?: string) { /> VibeScreen} + getComponent={() => VideoFeed} options={{ title: title(msg`Video Feed`), requireAuth: true, diff --git a/src/lib/statsig/events.ts b/src/lib/statsig/events.ts index 220cbd7810..f914ef01f9 100644 --- a/src/lib/statsig/events.ts +++ b/src/lib/statsig/events.ts @@ -131,16 +131,16 @@ export type LogEvents = { doesPosterFollowLiker: boolean | undefined likerClout: number | undefined postClout: number | undefined - logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' + logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo' } 'post:repost': { - logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' + logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo' } 'post:unlike': { - logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' + logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo' } 'post:unrepost': { - logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' + logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo' } 'post:mute': {} 'post:unmute': {} diff --git a/src/screens/Feeds/VibeScreen.tsx b/src/screens/Feeds/VibeScreen.tsx index 579fe9120e..3ff9363bb5 100644 --- a/src/screens/Feeds/VibeScreen.tsx +++ b/src/screens/Feeds/VibeScreen.tsx @@ -66,8 +66,10 @@ function createThreeVideoPlayers( return [p1, p2, p3] } -type Props = NativeStackScreenProps -export function VibeScreen({}: Props) { +export function VideoFeed({}: NativeStackScreenProps< + CommonNavigatorParams, + 'VideoFeed' +>) { const {top} = useSafeAreaInsets() const setMinShellMode = useSetMinimalShellMode() @@ -96,19 +98,19 @@ export function VibeScreen({}: Props) { {/* TODO: needs to be feed name */} - Vibes (wip) + Videos - + ) } -function YoloFeed() { +function Inner() { const {params} = useRoute>() const isFocused = useIsFocused() const feedDesc = useMemo(() => { @@ -161,7 +163,7 @@ function YoloFeed() { const currentSource = currentSources[index % 3] return ( - {player ? ( - + ) : ( embed.thumbnail && ( + player && ) : ( () const {status} = useEvent(player, 'statusChange', {status: player.status}) const doubleTapRef = useRef | null>(null) - const [queueLike] = usePostLikeMutationQueue(post, 'Vibe') + const [queueLike] = usePostLikeMutationQueue(post, 'ImmersiveVideo') const pushToProfile = useNonReactiveCallback(() => { navigation.navigate('Profile', {name: post.author.did}) diff --git a/src/view/com/util/post-ctrls/PostCtrls.tsx b/src/view/com/util/post-ctrls/PostCtrls.tsx index e51353fd31..f73cede352 100644 --- a/src/view/com/util/post-ctrls/PostCtrls.tsx +++ b/src/view/com/util/post-ctrls/PostCtrls.tsx @@ -69,7 +69,7 @@ let PostCtrls = ({ style?: StyleProp onPressReply: () => void onPostReply?: (postUri: string | undefined) => void - logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'Vibe' + logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo' threadgateRecord?: AppBskyFeedThreadgate.Record }): React.ReactNode => { const t = useTheme()