Translation followups (#9980)

src/components/Post/Translated/index.tsx

@@ -147,7 +147,7 @@ function TranslationLanguageSelect({
         {({props}) => {
           return (
             <Text {...props} style={[a.text_xs]}>
-              <Trans>Edit</Trans>
+              <Trans>Change</Trans>
             </Text>
           )
         }}

src/components/dialogs/LanguageSelectDialog.tsx

@@ -5,6 +5,7 @@ import {msg} from '@lingui/core/macro'
 import {useLingui} from '@lingui/react'
 import {Trans} from '@lingui/react/macro'
 
+import {languageName} from '#/locale/helpers'
 import {type Language, LANGUAGES, LANGUAGES_MAP_CODE2} from '#/locale/languages'
 import {useLanguagePrefs} from '#/state/preferences/languages'
 import {ErrorScreen} from '#/view/com/util/error/ErrorScreen'
@@ -139,8 +140,11 @@ export function DialogInner({
     const recentLanguages = mapCode2List(recentLanguagesCode2)
 
     // NOTE(@elijaharita): helper functions
+    const searchLower = search.toLowerCase()
     const matchesSearch = (lang: Language) =>
-      lang.name.toLowerCase().includes(search.toLowerCase())
+      languageName(lang, langPrefs.appLanguage)
+        .toLowerCase()
+        .includes(searchLower) || lang.name.toLowerCase().includes(searchLower)
     const isChecked = (lang: Language) =>
       checkedLanguagesCode2.includes(lang.code2)
     const isInRecents = (lang: Language) =>
@@ -182,6 +186,7 @@ export function DialogInner({
     search,
     langPrefs.postLanguageHistory,
     checkedLanguagesCode2,
+    langPrefs.appLanguage,
   ])
 
   const listHeader = (
@@ -297,6 +302,7 @@ export function DialogInner({
             )
           }
           const lang = item.lang
+          const name = languageName(lang, langPrefs.appLanguage)
 
           const isLastItem = index === numItems - 1
 
@@ -304,7 +310,7 @@ export function DialogInner({
             <Toggle.Item
               key={lang.code2}
               name={lang.code2}
-              label={lang.name}
+              label={name}
               style={[
                 t.atoms.border_contrast_low,
                 !isLastItem && a.border_b,
@@ -312,9 +318,7 @@ export function DialogInner({
                 a.px_0,
                 a.py_md,
               ]}>
-              <Toggle.LabelText style={[a.flex_1]}>
-                {lang.name}
-              </Toggle.LabelText>
+              <Toggle.LabelText style={[a.flex_1]}>{name}</Toggle.LabelText>
               <Toggle.Checkbox />
             </Toggle.Item>
           )

src/locale/helpers.ts

@@ -32,21 +32,27 @@ export function code3ToCode2Strict(lang: string): string | undefined {
   return undefined
 }
 
+const displayNamesCache = new Map<string, Intl.DisplayNames>()
+
+function getDisplayNames(appLang: string): Intl.DisplayNames {
+  let cached = displayNamesCache.get(appLang)
+  if (!cached) {
+    cached = new Intl.DisplayNames([appLang], {
+      type: 'language',
+      fallback: 'none',
+      languageDisplay: 'standard',
+    })
+    displayNamesCache.set(appLang, cached)
+  }
+  return cached
+}
+
 function getLocalizedLanguage(
   langCode: string,
   appLang: string,
 ): string | undefined {
   try {
-    const allNames = new Intl.DisplayNames([appLang], {
-      type: 'language',
-      fallback: 'none',
-      languageDisplay: 'standard',
-    })
-    const translatedName = allNames.of(langCode)
-
-    if (translatedName) {
-      return translatedName
-    }
+    return getDisplayNames(appLang).of(langCode) || undefined
   } catch (e) {
     // ignore RangeError from Intl.DisplayNames APIs
     if (!(e instanceof RangeError)) {
@@ -308,17 +314,26 @@ export function regionName(countryCode: string, appLang: string): string {
   return countryCode
 }
 
+const regionNamesCache = new Map<string, Intl.DisplayNames>()
+
+function getRegionNames(appLang: string): Intl.DisplayNames {
+  let cached = regionNamesCache.get(appLang)
+  if (!cached) {
+    cached = new Intl.DisplayNames([appLang], {
+      type: 'region',
+      fallback: 'none',
+    })
+    regionNamesCache.set(appLang, cached)
+  }
+  return cached
+}
+
 function getLocalizedRegionName(
   countryCode: string,
   appLang: string,
 ): string | undefined {
   try {
-    const allNames = new Intl.DisplayNames([appLang], {
-      type: 'region',
-      fallback: 'none',
-    })
-
-    return allNames.of(countryCode)
+    return getRegionNames(appLang).of(countryCode)
   } catch (err) {
     console.warn('Error getting localized region name:', err)
     return undefined

src/screens/Settings/LanguageSettings.tsx

@@ -8,7 +8,7 @@ import {
   type CommonNavigatorParams,
   type NativeStackScreenProps,
 } from '#/lib/routes/types'
-import {sanitizeAppLanguageSetting} from '#/locale/helpers'
+import {languageName, sanitizeAppLanguageSetting} from '#/locale/helpers'
 import {APP_LANGUAGES, LANGUAGES} from '#/locale/languages'
 import {useLanguagePrefs, useLanguagePrefsApi} from '#/state/preferences'
 import {atoms as a, web} from '#/alf'
@@ -144,13 +144,12 @@ export function LanguageSettingsScreen({}: Props) {
                       <Select.ItemText>{label}</Select.ItemText>
                     </Select.Item>
                   )}
-                  items={DEDUPED_LANGUAGES.sort(
-                    (a, b) =>
-                      a.name.localeCompare(b.name, langPrefs.appLanguage), // Localized sort
-                  ).map(l => ({
-                    label: l.name, // Pre-generated name using Intl.DisplayNames
+                  items={DEDUPED_LANGUAGES.map(l => ({
+                    label: languageName(l, langPrefs.appLanguage),
                     value: l.code2,
-                  }))}
+                  })).sort((a, b) =>
+                    a.label.localeCompare(b.label, langPrefs.appLanguage),
+                  )}
                 />
               </Select.Root>
             </View>
@@ -180,29 +179,24 @@ export function LanguageSettingsScreen({}: Props) {
                   values={langPrefs.contentLanguages}
                   onChange={setLangPrefs.setContentLanguages}>
                   <Toggle.PanelGroup>
-                    {possibleLanguages
-                      .sort(
-                        (a, b) =>
-                          a.name.localeCompare(b.name, langPrefs.appLanguage), // Localized sort
+                    {possibleLanguages.map((language, index) => {
+                      const name = languageName(language, langPrefs.appLanguage)
+                      return (
+                        <Toggle.Item
+                          key={language.code2}
+                          name={language.code2}
+                          label={name}>
+                          {({selected}) => (
+                            <Toggle.Panel
+                              active={selected}
+                              adjacent={index === 0 ? 'trailing' : 'both'}>
+                              <Toggle.Checkbox />
+                              <Toggle.PanelText>{name}</Toggle.PanelText>
+                            </Toggle.Panel>
+                          )}
+                        </Toggle.Item>
                       )
-                      .map((language, index) => {
-                        const name = language.name // Pre-generated name using Intl.DisplayNames
-                        return (
-                          <Toggle.Item
-                            key={language.code2}
-                            name={language.code2}
-                            label={name}>
-                            {({selected}) => (
-                              <Toggle.Panel
-                                active={selected}
-                                adjacent={index === 0 ? 'trailing' : 'both'}>
-                                <Toggle.Checkbox />
-                                <Toggle.PanelText>{name}</Toggle.PanelText>
-                              </Toggle.Panel>
-                            )}
-                          </Toggle.Item>
-                        )
-                      })}
+                    })}
                     <Button
                       label={_(msg`Add more languages…`)}
                       onPress={contentLanguagePrefsControl.open}>