Restore the pinned-post guard inside the try

Hoisting `if (!currentAccount) throw` above the try also moved it past the
catch, losing the "Failed to pin post" toast and the optimistic-update revert.
Keep the check in place and move only the `throw` to module scope.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tomek Zawadzki
2026-08-25 17:26:20 +02:00
parent 73a12c44b1
commit e18f89de4c
+14 -4
View File
@@ -10,6 +10,15 @@ import {updatePostShadow} from '../cache/post-shadow'
import {useAppviewClient, useSession} from '../session'
import {useProfileUpdateMutation} from './profile'
/**
* Out of the hook because React Compiler cannot lower a `throw` inside a `try`.
* Keeping the check in place - rather than hoisting it above the `try` - means
* the catch below still shows its toast and reverts the optimistic update.
*/
function assertSignedIn(account: unknown): asserts account {
if (!account) throw new Error('Not signed in')
}
/**
* Out of the hook because React Compiler cannot lower an optional chain inside a
* `try` block, and `profile` only exists once the request inside it resolves.
@@ -37,21 +46,22 @@ export function usePinnedPostMutation() {
postCid: string
action: 'pin' | 'unpin'
}) => {
if (!currentAccount) throw new Error('Not signed in')
const pinCurrentPost = action === 'pin'
let prevPinnedPost: string | undefined
try {
updatePostShadow(queryClient, postUri, {pinned: pinCurrentPost})
// get the currently pinned post so we can optimistically remove the pin from it
assertSignedIn(currentAccount)
const profile = await client.call(app.bsky.actor.getProfile, {
actor: currentAccount.did,
})
prevPinnedPost = getPinnedPostUri(profile)
if (prevPinnedPost) {
// Nested rather than `&&`: React Compiler cannot lower a logical
// expression in a test position inside a `try`.
/*
* Nested rather than `&&`: React Compiler cannot lower a logical
* expression in a test position inside a `try`.
*/
if (prevPinnedPost !== postUri) {
updatePostShadow(queryClient, prevPinnedPost, {pinned: false})
}