acetheking987/bsky-social-app
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

[APP-2160] Stabilize avatar style and drop stray Fragments

Browse Source 
Hoist the publication avatar style to a module-level const so its
identity is stable across renders, and remove two empty Fragment
wrappers that served no purpose.
This commit is contained in:
Eric Bailey
2026-05-22 14:47:45 -05:00
parent 19d5431c63
commit deb31b2eb9
1 changed files with 49 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/Post/Embed/StandardSiteEmbed/index.tsx
+49 -49
View File
@@ -33,6 +33,10 @@ export type ThemeColors = {
accentForeground: string
}
const PUBLICATION_AVATAR_STYLE = {
borderRadius: a.rounded_sm.borderRadius,
}
export function useStandardSitePublisherConfig(
view: AppBskyEmbedExternal.ViewExternal,
) {
@@ -365,32 +369,30 @@ export function PublicationCard({
a.gap_sm,
gtPhone && a.flex_1,
]}>
<>
<PublicationIcon
<PublicationIcon
view={view}
size={40}
hovered={hovered}
themeColors={themeColors}
/>
<View style={[a.flex_1, a.gap_2xs]}>
<Text
numberOfLines={1}
style={[
a.text_md,
a.font_semi_bold,
t.atoms.text,
hovered && a.underline,
]}>
{view.source?.title}
</Text>
<PublicationMetaRow
view={view}
size={40}
hovered={hovered}
themeColors={themeColors}
author={author}
onInteractWithin={onInteractWithin}
onInteractWithout={onInteractWithout}
/>
<View style={[a.flex_1, a.gap_2xs]}>
<Text
numberOfLines={1}
style={[
a.text_md,
a.font_semi_bold,
t.atoms.text,
hovered && a.underline,
]}>
{view.source?.title}
</Text>
<PublicationMetaRow
view={view}
author={author}
onInteractWithin={onInteractWithin}
onInteractWithout={onInteractWithout}
/>
</View>
</>
</View>
</View>
{!hideSubscribe && (
@@ -482,7 +484,7 @@ function PublicationIcon({
type="labeler"
size={size}
avatar={view.source.icon}
extraAviStyle={{borderRadius: a.rounded_sm.borderRadius}}
extraAviStyle={PUBLICATION_AVATAR_STYLE}
/>
<MediaInsetBorder
style={[
@@ -579,32 +581,30 @@ export function PublicationFooter({
a.gap_sm,
gtPhone && a.flex_1,
]}>
<>
<PublicationIcon
<PublicationIcon
view={view}
size={32}
hovered={hovered}
themeColors={themeColors}
/>
<View style={[a.flex_1, a.gap_2xs]}>
<Text
numberOfLines={1}
style={[
a.text_sm,
a.font_medium,
t.atoms.text,
hovered && a.underline,
]}>
{view.source?.title}
</Text>
<PublicationMetaRow
view={view}
size={32}
hovered={hovered}
themeColors={themeColors}
author={author}
onInteractWithin={onInteractWithin}
onInteractWithout={onInteractWithout}
/>
<View style={[a.flex_1, a.gap_2xs]}>
<Text
numberOfLines={1}
style={[
a.text_sm,
a.font_medium,
t.atoms.text,
hovered && a.underline,
]}>
{view.source?.title}
</Text>
<PublicationMetaRow
view={view}
author={author}
onInteractWithin={onInteractWithin}
onInteractWithout={onInteractWithout}
/>
</View>
</>
</View>
</Link>
{!hideSubscribe && (