Ok diff interface to avoid collapsed views

This commit is contained in:
Eric Bailey
2025-06-23 13:24:38 -05:00
parent bff64b78d1
commit d7a644e759
3 changed files with 17 additions and 21 deletions
+10 -10
View File
@@ -95,8 +95,10 @@ export function Outer({
* Once opened, measure the dimensions and position of the target
*/
targetRef.current.measure((_x, _y, width, height, pageX, pageY) => {
setTargetMeasurements({x: pageX, y: pageY, width, height})
setReady(true)
if (pageX !== undefined && pageY !== undefined && width && height) {
setTargetMeasurements({x: pageX, y: pageY, width, height})
setReady(true)
}
})
}
} else if (!requestVisible && prevRequestVisible) {
@@ -123,16 +125,14 @@ export function Outer({
)
}
export function Target({
children,
}: {
children: (props: {ref: TargetContextType['targetRef']}) => React.ReactNode
}) {
export function Target({children}: {children: React.ReactNode}) {
const {targetRef} = useContext(TargetContext)
return children({
ref: targetRef,
})
return (
<View collapsable={false} ref={targetRef}>
{children}
</View>
)
}
export function Content({
+6 -6
View File
@@ -38,12 +38,12 @@ export function Outer({
)
}
export function Target({
children,
}: {
children: (props: {ref: undefined}) => React.ReactNode
}) {
return <Popover.Trigger asChild>{children({ref: undefined})}</Popover.Trigger>
export function Target({children}: {children: React.ReactNode}) {
return (
<Popover.Trigger asChild>
<View collapsable={false}>{children}</View>
</Popover.Trigger>
)
}
export function Content({
@@ -218,11 +218,7 @@ let ProfileHeaderStandard = ({
visible={visible}
onVisibleChange={setVisible}>
<Tooltip.Target>
{({ref}) => (
<View ref={ref}>
<MessageProfileButton profile={profile} />
</View>
)}
<MessageProfileButton profile={profile} />
</Tooltip.Target>
<Tooltip.TextBubble>
<Text>