Clicking "see more" on user suggestions now opens modal

This commit is contained in:
Alex Benzer
2025-12-04 11:13:22 -08:00
parent 7735183af4
commit d1fc0e8b7c
2 changed files with 68 additions and 31 deletions
+39 -19
View File
@@ -29,10 +29,11 @@ import {Button, ButtonIcon, ButtonText} from '#/components/Button'
import * as FeedCard from '#/components/FeedCard'
import {ArrowRight_Stroke2_Corner0_Rounded as ArrowRight} from '#/components/icons/Arrow'
import {Hashtag_Stroke2_Corner0_Rounded as Hashtag} from '#/components/icons/Hashtag'
import {InlineLinkText, Link} from '#/components/Link'
import {InlineLinkText} from '#/components/Link'
import * as ProfileCard from '#/components/ProfileCard'
import {Text} from '#/components/Typography'
import type * as bsky from '#/types/bsky'
import {useFollowDialogControl} from './ProgressGuide/FollowDialog'
import {ProgressGuideList} from './ProgressGuide/List'
const MOBILE_CARD_WIDTH = 165
@@ -250,6 +251,7 @@ export function ProfileGrid({
const {_} = useLingui()
const moderationOpts = useModerationOpts()
const {gtMobile} = useBreakpoints()
const followDialog = useFollowDialogControl()
const isLoading = isSuggestionsLoading || !moderationOpts
const isProfileHeaderContext = viewContext === 'profileHeader'
@@ -388,19 +390,34 @@ export function ProfileGrid({
)}
</Text>
{!isProfileHeaderContext && (
<InlineLinkText
label={_(msg`See more suggested profiles on the Explore page`)}
to="/search"
<Button
label={_(msg`See more suggested profiles`)}
onPress={() => {
logger.metric('suggestedUser:seeMore', {
followDialog.control.open()
logEvent('suggestedUser:seeMore', {
logContext: isFeedContext ? 'Explore' : 'Profile',
})
}}>
<Trans>See more</Trans>
</InlineLinkText>
{({hovered}) => (
<Text
style={[
a.text_sm,
{color: t.palette.primary_500},
hovered &&
web({
textDecorationLine: 'underline',
textDecorationColor: t.palette.primary_500,
}),
]}>
<Trans>See more</Trans>
</Text>
)}
</Button>
)}
</View>
<followDialog.Dialog />
{gtMobile ? (
<View style={[a.p_lg, a.pt_md]}>
<View style={[a.flex_1, a.flex_row, a.flex_wrap, a.gap_md]}>
@@ -417,7 +434,16 @@ export function ProfileGrid({
decelerationRate="fast">
{content}
{!isProfileHeaderContext && <SeeMoreSuggestedProfilesCard />}
{!isProfileHeaderContext && (
<SeeMoreSuggestedProfilesCard
onPress={() => {
followDialog.control.open()
logger.metric('suggestedUser:seeMore', {
logContext: 'Explore',
})
}}
/>
)}
</ScrollView>
</BlockDrawerGesture>
)}
@@ -425,20 +451,14 @@ export function ProfileGrid({
)
}
function SeeMoreSuggestedProfilesCard() {
function SeeMoreSuggestedProfilesCard({onPress}: {onPress: () => void}) {
const t = useTheme()
const {_} = useLingui()
return (
<Link
to="/search"
color="primary"
label={_(msg`Browse more accounts on the Explore page`)}
onPress={() => {
logger.metric('suggestedUser:seeMore', {
logContext: 'Explore',
})
}}
<Button
label={_(msg`Browse more accounts`)}
onPress={onPress}
style={[
a.flex_col,
a.align_center,
@@ -454,7 +474,7 @@ function SeeMoreSuggestedProfilesCard() {
style={[a.text_md, a.font_medium, a.leading_snug, a.text_center]}>
<Trans>See more</Trans>
</ButtonText>
</Link>
</Button>
)
}
+29 -12
View File
@@ -54,7 +54,7 @@ type Item =
key: string
}
export function FollowDialog({guide}: {guide: Follow10ProgressGuide}) {
export function FollowDialog({guide}: {guide?: Follow10ProgressGuide}) {
const {_} = useLingui()
const control = Dialog.useDialogControl()
const {gtMobile} = useBreakpoints()
@@ -84,11 +84,26 @@ export function FollowDialog({guide}: {guide: Follow10ProgressGuide}) {
)
}
export function useFollowDialogControl() {
const control = Dialog.useDialogControl()
const {height: minHeight} = useWindowDimensions()
return {
control,
Dialog: ({guide}: {guide?: Follow10ProgressGuide}) => (
<Dialog.Outer control={control} nativeOptions={{minHeight}}>
<Dialog.Handle />
<DialogInner guide={guide} />
</Dialog.Outer>
),
}
}
// Fine to keep this top-level.
let lastSelectedInterest = ''
let lastSearchText = ''
function DialogInner({guide}: {guide: Follow10ProgressGuide}) {
function DialogInner({guide}: {guide?: Follow10ProgressGuide}) {
const {_} = useLingui()
const interestsDisplayNames = useInterestsDisplayNames()
const {data: preferences} = usePreferencesQuery()
@@ -289,7 +304,7 @@ let Header = ({
selectedInterest,
interestsDisplayNames,
}: {
guide: Follow10ProgressGuide
guide?: Follow10ProgressGuide
inputRef: React.RefObject<TextInput | null>
listRef: React.RefObject<ListMethods | null>
onSelectTab: (v: string) => void
@@ -340,7 +355,7 @@ let Header = ({
}
Header = memo(Header)
function HeaderTop({guide}: {guide: Follow10ProgressGuide}) {
function HeaderTop({guide}: {guide?: Follow10ProgressGuide}) {
const {_} = useLingui()
const t = useTheme()
const control = Dialog.useDialogContext()
@@ -363,14 +378,16 @@ function HeaderTop({guide}: {guide: Follow10ProgressGuide}) {
]}>
<Trans>Find people to follow</Trans>
</Text>
<View style={isWeb && {paddingRight: 36}}>
<ProgressGuideTask
current={guide.numFollows + 1}
total={10 + 1}
title={`${guide.numFollows} / 10`}
tabularNumsTitle
/>
</View>
{guide && (
<View style={isWeb && {paddingRight: 36}}>
<ProgressGuideTask
current={guide.numFollows + 1}
total={10 + 1}
title={`${guide.numFollows} / 10`}
tabularNumsTitle
/>
</View>
)}
{isWeb ? (
<Button
label={_(msg`Close`)}