Fix KWS language picker silently resetting Arabic, Chinese, Filipino & Portuguese to English (#11082)
Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Eric Bailey <git@esb.lol>
This commit is contained in:
@@ -1,4 +1,3 @@
|
||||
import {useCallback} from 'react'
|
||||
import {msg} from '@lingui/core/macro'
|
||||
import {useLingui} from '@lingui/react'
|
||||
|
||||
@@ -14,26 +13,31 @@ export function LanguageSelect({
|
||||
value: l.code2,
|
||||
})),
|
||||
label,
|
||||
disabledBlueskySupportedLanguageSanitization = false,
|
||||
}: {
|
||||
value?: string
|
||||
onChange: (value: string) => void
|
||||
items?: {label: string; value: string}[]
|
||||
label?: string
|
||||
disabledBlueskySupportedLanguageSanitization?: boolean
|
||||
}) {
|
||||
const {_} = useLingui()
|
||||
const selectValue =
|
||||
value && !disabledBlueskySupportedLanguageSanitization
|
||||
? sanitizeAppLanguageSetting(value)
|
||||
: value
|
||||
|
||||
const handleOnChange = useCallback(
|
||||
(value: string) => {
|
||||
if (!value) return
|
||||
onChange(sanitizeAppLanguageSetting(value))
|
||||
},
|
||||
[onChange],
|
||||
)
|
||||
const handleOnChange = (value: string) => {
|
||||
if (!value) return
|
||||
onChange(
|
||||
disabledBlueskySupportedLanguageSanitization
|
||||
? value
|
||||
: sanitizeAppLanguageSetting(value),
|
||||
)
|
||||
}
|
||||
|
||||
return (
|
||||
<Select.Root
|
||||
value={value ? sanitizeAppLanguageSetting(value) : undefined}
|
||||
onValueChange={handleOnChange}>
|
||||
<Select.Root value={selectValue} onValueChange={handleOnChange}>
|
||||
<Select.Trigger label={_(msg`Select language`)}>
|
||||
<Select.ValueText placeholder={_(msg`Select language`)} />
|
||||
<Select.Icon />
|
||||
|
||||
@@ -296,6 +296,7 @@ function Inner() {
|
||||
setLanguageError(false)
|
||||
}}
|
||||
items={KWS_SUPPORTED_LANGS}
|
||||
disabledBlueskySupportedLanguageSanitization
|
||||
/>
|
||||
|
||||
{languageError && (
|
||||
|
||||
Reference in New Issue
Block a user