a bunch of changes

modules/BlueskyClip/Images.xcassets/AppIcon.appiconset/Contents.json

@@ -1,7 +1,7 @@
 {
   "images" : [
     {
-      "filename" : "icon.png",
+      "filename" : "App-Icon-1024x1024@1x.png",
       "idiom" : "universal",
       "platform" : "ios",
       "size" : "1024x1024"

plugins/starterPackAppClipExtension/withClipInfoPlist.js

@@ -24,6 +24,7 @@ const withClipInfoPlist = (config, {targetName}) => {
       CFBundleExecutable: '$(EXECUTABLE_NAME)',
       CFBundlePackageType: '$(PRODUCT_BUNDLE_PACKAGE_TYPE)',
       CFBundleShortVersionString: config.version,
+      CFBundleIconName: 'AppIcon',
       UIViewControllerBasedStatusBarAppearance: 'NO',
     })
 

plugins/starterPackAppClipExtension/withFiles.js

@@ -25,6 +25,14 @@ const withFiles = (config, {targetName}) => {
       fs.copyFileSync(sourcePath, targetPath)
     }
 
+    const imagesBasePath = path.join(basePath, 'Images.xcassets')
+    const imagesTargetPath = path.join(
+      config.modRequest.platformProjectRoot,
+      targetName,
+      'Images.xcassets',
+    )
+    fs.cpSync(imagesBasePath, imagesTargetPath, {recursive: true})
+
     return config
   })
 }

plugins/starterPackAppClipExtension/withXcodeTarget.js

@@ -15,20 +15,26 @@ const withXcodeTarget = (config, {targetName}) => {
       'Sources',
       target.uuid,
       'application',
-      '"$(CONTENTS_FOLDER_PATH)/AppClips"',
+      '"AppClips"',
     )
     pbxProject.addBuildPhase(
-      [],
+      [`${targetName}/Images.xcassets`],
       'PBXResourcesBuildPhase',
       'Resources',
       target.uuid,
       'application',
-      '"$(CONTENTS_FOLDER_PATH)/AppClips"',
+      '"AppClips"',
     )
 
-    const pbxGroupKey = pbxProject.pbxCreateGroup(targetName, targetName)
-    pbxProject.addFile(`${targetName}/Info.plist`, pbxGroupKey)
+    const pbxGroup = pbxProject.addPbxGroup([
+      'AppDelegate.swift',
+      'ViewController.swift',
+      'Images.xcassets',
+      `${targetName}.entitlements`,
+      'Info.plist',
+    ])
 
+    pbxProject.addFile(`${targetName}/Info.plist`, pbxGroup.uuid)
     const configurations = pbxProject.pbxXCBuildConfigurationSection()
     for (const key in configurations) {
       if (typeof configurations[key].buildSettings !== 'undefined') {
@@ -68,27 +74,13 @@ const withXcodeTarget = (config, {targetName}) => {
       target.uuid,
     ])
 
-    // pbxProject.addProductFile(targetName, {
-    //   basename: `${targetName}.app`,
-    //   groupName: 'Embed App Clips',
-    //   explicitFileType: 'wrapper.application',
-    //   settings: {
-    //     ATTRIBUTES: ['RemoveHeadersOnCopy'],
-    //   },
-    //   includeInIndex: 0,
-    //   path: `${targetName}.app`,
-    //   sourceTree: 'BUILT_PRODUCTS_DIR',
-    // })
-
-    pbxProject.addToPbxNativeTargetSection(target)
-
     pbxProject.addBuildPhase(
       [`${targetName}.app`],
       'PBXCopyFilesBuildPhase',
       'Embed App Clips',
       pbxProject.getFirstTarget().uuid,
       'application',
-      '"$(CONTENTS_FOLDER_PATH)/AppClips"',
+      '"AppClips"',
     )
 
     return config