Resolve merge: keep fallback path for gallery embeds
10707 grouped 'gallery' with 'images' through ImageEmbed. On the OTA branch, gallery should dispatch to GalleryFallbackEmbed instead so older native builds show the update prompt. Also dedupes the duplicate gallery branches the auto-merge left in the Embed type union and parseEmbed.
This commit is contained in:
@@ -57,8 +57,7 @@ export function Embed({embed: rawEmbed, ...rest}: EmbedProps) {
|
||||
case 'images':
|
||||
case 'gallery':
|
||||
case 'link':
|
||||
case 'video':
|
||||
case 'gallery': {
|
||||
case 'video': {
|
||||
return <MediaEmbed embed={embed} {...rest} />
|
||||
}
|
||||
case 'feed':
|
||||
@@ -92,8 +91,7 @@ function MediaEmbed({
|
||||
embed: TEmbed
|
||||
}) {
|
||||
switch (embed.type) {
|
||||
case 'images':
|
||||
case 'gallery': {
|
||||
case 'images': {
|
||||
return (
|
||||
<ContentHider
|
||||
modui={rest.moderation?.ui('contentMedia')}
|
||||
|
||||
@@ -60,10 +60,6 @@ export type Embed =
|
||||
type: 'video'
|
||||
view: $Typed<AppBskyEmbedVideo.View>
|
||||
}
|
||||
| {
|
||||
type: 'gallery'
|
||||
view: $Typed<AppBskyEmbedGallery.View>
|
||||
}
|
||||
| {
|
||||
type: 'post_with_media'
|
||||
view: Embed
|
||||
@@ -154,11 +150,6 @@ export function parseEmbed(embed: AppBskyFeedDefs.PostView['embed']): Embed {
|
||||
view: parseEmbedRecordView(embed.record),
|
||||
media: parseEmbed(embed.media),
|
||||
}
|
||||
} else if (AppBskyEmbedGallery.isView(embed)) {
|
||||
return {
|
||||
type: 'gallery',
|
||||
view: embed,
|
||||
}
|
||||
} else {
|
||||
return {
|
||||
type: 'unknown',
|
||||
|
||||
Reference in New Issue
Block a user