PR feedback

Dockerfile

@@ -48,7 +48,7 @@ ENV EXPO_PUBLIC_SENTRY_DSN=$EXPO_PUBLIC_SENTRY_DSN
 COPY . .
 
 #
-# Generate the JavaScript webpack.
+# Generate the web bundle with Metro.
 #
 RUN mkdir --parents $NVM_DIR && \
   wget \

eslint.config.mjs

@@ -299,7 +299,7 @@ export default defineConfig(
    * bskyogcard - server-side, Node.js imports are fine
    */
   {
-    files: ['bskyogcard/**/*.{js,jsx,ts,tsx}'],
+    files: ['bskyogcard/**/*.{js,jsx,ts,tsx}', 'scripts/**/*.{js,ts}'],
     rules: {
       'import-x/no-nodejs-modules': 'off',
     },

scripts/post-web-build.js

@@ -1,6 +1,6 @@
-const path = require('path')
+const path = require('node:path')
-const fs = require('fs')
+const fs = require('node:fs')
-const {execSync} = require('child_process')
+const {execFileSync} = require('node:child_process')
 
 const projectRoot = path.join(__dirname, '..')
 const distDir = path.join(projectRoot, 'dist')
@@ -119,8 +119,7 @@ if (process.env.SENTRY_AUTH_TOKEN) {
   const sourceMapDir = path.join(distDir, '_expo', 'static')
 
   console.log(`Uploading source maps to Sentry (release: ${release})`)
-  const cmd = [
+  const args = [
-    'sentry-cli',
     'sourcemaps',
     'upload',
     '--org',
@@ -133,7 +132,7 @@ if (process.env.SENTRY_AUTH_TOKEN) {
     sourceMapDir,
   ]
   try {
-    execSync(cmd.join(' '), {stdio: 'inherit', cwd: projectRoot})
+    execFileSync('sentry-cli', args, {stdio: 'inherit', cwd: projectRoot})
     console.log('Sentry source map upload complete')
   } catch (e) {
     console.error('Sentry source map upload failed:', e.message)