From 5d875d311f6d56bdca667753a8ebbd8a7a2280e5 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Fri, 22 May 2026 11:50:57 +0300 Subject: [PATCH] PR feedback --- Dockerfile | 2 +- eslint.config.mjs | 2 +- scripts/post-web-build.js | 11 +++++------ 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/Dockerfile b/Dockerfile index cbcba530eb..819ebcd5f6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -48,7 +48,7 @@ ENV EXPO_PUBLIC_SENTRY_DSN=$EXPO_PUBLIC_SENTRY_DSN COPY . . # -# Generate the JavaScript webpack. +# Generate the web bundle with Metro. # RUN mkdir --parents $NVM_DIR && \ wget \ diff --git a/eslint.config.mjs b/eslint.config.mjs index e7f84c6fb4..05237965bb 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -299,7 +299,7 @@ export default defineConfig( * bskyogcard - server-side, Node.js imports are fine */ { - files: ['bskyogcard/**/*.{js,jsx,ts,tsx}'], + files: ['bskyogcard/**/*.{js,jsx,ts,tsx}', 'scripts/**/*.{js,ts}'], rules: { 'import-x/no-nodejs-modules': 'off', }, diff --git a/scripts/post-web-build.js b/scripts/post-web-build.js index bb4a1c0e62..5259a3a2f8 100644 --- a/scripts/post-web-build.js +++ b/scripts/post-web-build.js @@ -1,6 +1,6 @@ -const path = require('path') -const fs = require('fs') -const {execSync} = require('child_process') +const path = require('node:path') +const fs = require('node:fs') +const {execFileSync} = require('node:child_process') const projectRoot = path.join(__dirname, '..') const distDir = path.join(projectRoot, 'dist') @@ -119,8 +119,7 @@ if (process.env.SENTRY_AUTH_TOKEN) { const sourceMapDir = path.join(distDir, '_expo', 'static') console.log(`Uploading source maps to Sentry (release: ${release})`) - const cmd = [ - 'sentry-cli', + const args = [ 'sourcemaps', 'upload', '--org', @@ -133,7 +132,7 @@ if (process.env.SENTRY_AUTH_TOKEN) { sourceMapDir, ] try { - execSync(cmd.join(' '), {stdio: 'inherit', cwd: projectRoot}) + execFileSync('sentry-cli', args, {stdio: 'inherit', cwd: projectRoot}) console.log('Sentry source map upload complete') } catch (e) { console.error('Sentry source map upload failed:', e.message)