Rm sticky headers (#8154)

This commit is contained in:
Eric Bailey
2025-04-07 19:41:20 -05:00
committed by GitHub
parent 28876a4b23
commit 4879a07701
2 changed files with 3 additions and 20 deletions
+2 -16
View File
@@ -51,7 +51,7 @@ import {ExploreInterestsCard} from '#/screens/Search/modules/ExploreInterestsCar
import {ExploreRecommendations} from '#/screens/Search/modules/ExploreRecommendations'
import {ExploreTrendingTopics} from '#/screens/Search/modules/ExploreTrendingTopics'
import {ExploreTrendingVideos} from '#/screens/Search/modules/ExploreTrendingVideos'
import {atoms as a, native, platform, useTheme, web} from '#/alf'
import {atoms as a, native, platform, useTheme} from '#/alf'
import {Admonition} from '#/components/Admonition'
import {Button} from '#/components/Button'
import * as FeedCard from '#/components/FeedCard'
@@ -202,7 +202,6 @@ type ExploreScreenItems =
export function Explore({
focusSearchInput,
headerHeight,
}: {
focusSearchInput: (tab: 'user' | 'profile' | 'feed') => void
headerHeight: number
@@ -608,18 +607,7 @@ export function Explore({
switch (item.type) {
case 'topBorder':
return (
<View
style={[
a.w_full,
t.atoms.border_contrast_low,
a.border_t,
headerHeight &&
web({
position: 'sticky',
top: headerHeight,
}),
]}
/>
<View style={[a.w_full, t.atoms.border_contrast_low, a.border_t]} />
)
case 'header': {
return (
@@ -805,7 +793,6 @@ export function Explore({
case 'preview:header': {
return (
<ModuleHeader.Container
headerHeight={headerHeight}
style={[
a.pt_xs,
t.atoms.border_contrast_low,
@@ -893,7 +880,6 @@ export function Explore({
selectedInterest,
_,
fetchNextPageFeedPreviews,
headerHeight,
],
)
@@ -6,7 +6,7 @@ import {PressableScale} from '#/lib/custom-animations/PressableScale'
import {makeCustomFeedLink} from '#/lib/routes/links'
import {logger} from '#/logger'
import {UserAvatar} from '#/view/com/util/UserAvatar'
import {atoms as a, native, useTheme, type ViewStyleProp, web} from '#/alf'
import {atoms as a, native, useTheme, type ViewStyleProp} from '#/alf'
import {Button, ButtonIcon} from '#/components/Button'
import * as FeedCard from '#/components/FeedCard'
import {sizes as iconSizes} from '#/components/icons/common'
@@ -17,11 +17,9 @@ import {Text, type TextProps} from '#/components/Typography'
export function Container({
style,
children,
headerHeight,
bottomBorder,
}: {
children: React.ReactNode
headerHeight?: number
bottomBorder?: boolean
} & ViewStyleProp) {
const t = useTheme()
@@ -35,7 +33,6 @@ export function Container({
a.pb_md,
a.gap_sm,
t.atoms.bg,
headerHeight && web({position: 'sticky', top: headerHeight}),
bottomBorder && [a.border_b, t.atoms.border_contrast_low],
style,
]}>