Start moving code around

This commit is contained in:
Dan Abramov
2024-07-06 04:58:12 +01:00
parent e212a3f441
commit 3349174bbd
4 changed files with 156 additions and 205 deletions
+132
View File
@@ -5,3 +5,135 @@ import {Text} from './client.js'
export default async function App() {
return <Text>hello</Text>
}
// TODO
// const DEFAULT_AC = h('Stack', {gap: 10}, [
// h('Label', {
// size: 36,
// lineHeight: 1.2,
// weight: 'bold',
// text: 'Hello, world!',
// }),
// h('Label', {
// lineHeight: 1.2,
// text: 'This is the initial version of a fantastic new feature of the AT Protocol called "application components."',
// }),
// h('Tabs', {labels: ['Layout', 'Display', 'Inputs', 'Forms', 'ATProto']}, [
// h('Stack', {gap: 10, pad: {t: 20}}, [
// h('Box', {pad: {x: 10}}, [
// h('Label', {text: 'Stack', size: 10, weight: 'bold'}),
// ]),
// h('Box', {border: 'default', corner: 10, pad: {x: 2, y: 6}}, [
// h(
// 'Stack',
// {
// direction: 'row',
// align: 'center',
// gap: 10,
// pad: {x: 10},
// },
// [
// h('Label', {text: 'One'}),
// h('Label', {text: 'Two', color: 'positive'}),
// h('Box', {border: 'default', corner: 4, pad: 10}, [
// {type: 'Label', props: {text: 'Three'}},
// ]),
// h('Box', {background: 'secondary', corner: 4, pad: 10}, [
// {type: 'Label', props: {text: 'Four'}},
// ]),
// h('Label', {text: 'Five', color: 'secondary'}),
// ],
// ),
// ]),
// h('Box', {pad: {x: 10}}, [
// h('Label', {text: 'Box', size: 10, weight: 'bold'}),
// ]),
// h('Box', {border: 'default', corner: 10, pad: {x: 10, y: 14}}, [
// h('Label', {
// text: 'You can use the Box element as somewhat similar to a div.',
// }),
// h('Label', {text: 'Its children flow vertically with no gap.'}),
// h('Label', {
// text: 'What it offers is styling -- border, corner radius, background, and padding.',
// }),
// h('Label', {
// text: 'If you want to control layout then you use a Stack, then if you want styling you use a Box.',
// }),
// h('Label', {
// text: 'Boxes also make good neutral containers.',
// }),
// ]),
// h('Box', {pad: {x: 10}}, [
// h('Label', {text: 'Expandable', size: 10, weight: 'bold'}),
// ]),
// h('Box', {border: 'default', corner: 10, pad: 6}, [
// h('Expandable', {label: 'Expandable'}, [h('Label', {text: 'Content'})]),
// ]),
// ]),
// h('Label', {text: 'Display TODO'}),
// h('Label', {text: 'Inputs TODO'}),
// h('Label', {text: 'Forms TODO'}),
// h('Stack', {gap: 10, pad: {t: 20}}, [
// h('Box', {pad: {x: 10}}, [
// h('Label', {text: 'Avatar', size: 10, weight: 'bold'}),
// ]),
// h('Box', {border: 'secondary', corner: 8, pad: {x: 16, y: 12}}, [
// h('Stack', {direction: 'row', gap: 10}, [
// h('Avatar', {uri: 'bsky.app'}),
// h('Avatar', {uri: 'at://atproto.com'}),
// h('Avatar', {uri: 'at://pfrazee.com/'}),
// ]),
// ]),
// h('Box', {pad: {x: 10}}, [
// h('Label', {text: 'ActorLabel', size: 10, weight: 'bold'}),
// ]),
// h('Box', {border: 'secondary', corner: 8, pad: {x: 16, y: 12}}, [
// h('Stack', {gap: 10}, [
// h('Stack', {direction: 'row', gap: 8}, [
// h('Label', {weight: 'bold', text: 'Display Name:'}),
// h('ActorLabel', {uri: 'bsky.app', field: 'displayName'}),
// ]),
// h('Stack', {direction: 'row', gap: 8}, [
// h('Label', {weight: 'bold', text: 'Handle:'}),
// h('ActorLabel', {uri: 'bsky.app', field: 'handle'}),
// ]),
// h('Stack', {direction: 'row', gap: 8}, [
// h('Label', {weight: 'bold', text: 'Description:'}),
// h('ActorLabel', {uri: 'bsky.app', field: 'description'}),
// ]),
// ]),
// ]),
// h('Box', {pad: {x: 10}}, [
// h('Label', {text: 'Embed (Actor)', size: 10, weight: 'bold'}),
// ]),
// h('Box', {border: 'secondary', corner: 8}, [
// h('Embed', {uri: 'bsky.app'}),
// ]),
// h('Box', {border: 'secondary', corner: 8}, [
// h('Embed', {uri: 'at://atproto.com/'}),
// ]),
// h('Box', {border: 'secondary', corner: 8}, [
// h('Embed', {uri: 'at://pfrazee.com'}),
// ]),
// h('Box', {pad: {x: 10}}, [
// h('Label', {text: 'Embed (Post)', size: 10, weight: 'bold'}),
// ]),
// h('Box', {border: 'secondary', corner: 8}, [
// h('Embed', {uri: 'at://pfrazee.com/app.bsky.feed.post/3ku7fbojcqs25'}),
// ]),
// h('Box', {border: 'secondary', corner: 8}, [
// h('Embed', {uri: 'at://bsky.app/app.bsky.feed.post/3ku73zs755e27'}),
// ]),
// h('Box', {pad: {x: 10}}, [
// h('Label', {
// text: 'Embed (Unsupported record type)',
// size: 10,
// weight: 'bold',
// }),
// ]),
// h('Box', {border: 'secondary', corner: 8}, [
// h('Embed', {uri: 'at://pfrazee.com/com.example.unknown/123'}),
// ]),
// ]),
// ]),
// ])
+18 -9
View File
@@ -1,18 +1,13 @@
import React from 'react'
import {View} from 'react-native'
import {ErrorBoundary} from 'react-error-boundary'
import {ZodError} from 'zod'
import {atoms as a, useTheme} from '#/alf'
import {Text} from '../Typography'
import type {AppComNode} from './types'
import {AppComponent} from './vocabulary'
export function AppComponentRegion({
tree,
origin,
}: {
tree: AppComNode
origin: string
}) {
export function AppComponentRegion({origin}: {origin: string}) {
const t = useTheme()
return (
<View style={[a.border, t.atoms.border_contrast_medium, a.rounded_sm]}>
@@ -36,8 +31,22 @@ export function AppComponentRegion({
</Text>
</View>
<View style={[a.px_md, a.py_lg]}>
<AppComponent node={tree} />
<ErrorBoundary fallbackRender={fallbackRender}>
<AppComponent origin={origin} />
</ErrorBoundary>
</View>
</View>
)
}
function fallbackRender({error}: {error: Error}) {
const msg =
error instanceof ZodError
? `${error.issues[0].path.join('.')}: ${error.issues[0].message}`
: error.toString()
return (
<View>
<Text>{msg}</Text>
</View>
)
}
+4 -32
View File
@@ -1,10 +1,6 @@
import React from 'react'
import {View} from 'react-native'
import {ErrorBoundary} from 'react-error-boundary'
import {ZodError} from 'zod'
import {Text} from '#/components/Typography'
import type {AppComNode} from '../types'
import {ActorLabel} from './ActorLabel'
import {Avatar} from './Avatar'
import {Box} from './Box'
@@ -14,6 +10,7 @@ import {Label} from './Label'
import {Stack} from './Stack'
import {Tabs} from './Tabs'
// TODO
export const VOCAB: Record<string, React.ComponentType<any>> = {
ActorLabel,
Avatar,
@@ -25,32 +22,7 @@ export const VOCAB: Record<string, React.ComponentType<any>> = {
Tabs,
}
export function AppComponent({node}: {node: AppComNode}) {
const Com = VOCAB[node.type]
if (!Com) {
console.error('Unknown component:', node.type)
return <></>
}
return (
<ErrorBoundary fallbackRender={fallbackRender}>
<Com {...node.props}>
{node.children?.length
? node.children.map((child, i) => (
<AppComponent key={child.key || String(i)} node={child} />
))
: null}
</Com>
</ErrorBoundary>
)
}
function fallbackRender({error}: {error: Error}) {
const msg =
error instanceof ZodError
? `${error.issues[0].path.join('.')}: ${error.issues[0].message}`
: error.toString()
return (
<View>
<Text>{msg}</Text>
</View>
)
export function AppComponent({origin}: {origin: string}) {
// TODO
return <Text>{origin}</Text>
}
+2 -164
View File
@@ -5,159 +5,14 @@ import {CommonNavigatorParams, NativeStackScreenProps} from 'lib/routes/types'
import {CenteredView, ScrollView} from '#/view/com/util/Views'
import {atoms as a, useTheme} from '#/alf'
import {AppComponentRegion} from '#/components/appcom/AppCom'
import * as TextField from '#/components/forms/TextField'
import {Text} from '#/components/Typography'
const DEFAULT_AC = h('Stack', {gap: 10}, [
h('Label', {
size: 36,
lineHeight: 1.2,
weight: 'bold',
text: 'Hello, world!',
}),
h('Label', {
lineHeight: 1.2,
text: 'This is the initial version of a fantastic new feature of the AT Protocol called "application components."',
}),
h('Tabs', {labels: ['Layout', 'Display', 'Inputs', 'Forms', 'ATProto']}, [
h('Stack', {gap: 10, pad: {t: 20}}, [
h('Box', {pad: {x: 10}}, [
h('Label', {text: 'Stack', size: 10, weight: 'bold'}),
]),
h('Box', {border: 'default', corner: 10, pad: {x: 2, y: 6}}, [
h(
'Stack',
{
direction: 'row',
align: 'center',
gap: 10,
pad: {x: 10},
},
[
h('Label', {text: 'One'}),
h('Label', {text: 'Two', color: 'positive'}),
h('Box', {border: 'default', corner: 4, pad: 10}, [
{type: 'Label', props: {text: 'Three'}},
]),
h('Box', {background: 'secondary', corner: 4, pad: 10}, [
{type: 'Label', props: {text: 'Four'}},
]),
h('Label', {text: 'Five', color: 'secondary'}),
],
),
]),
h('Box', {pad: {x: 10}}, [
h('Label', {text: 'Box', size: 10, weight: 'bold'}),
]),
h('Box', {border: 'default', corner: 10, pad: {x: 10, y: 14}}, [
h('Label', {
text: 'You can use the Box element as somewhat similar to a div.',
}),
h('Label', {text: 'Its children flow vertically with no gap.'}),
h('Label', {
text: 'What it offers is styling -- border, corner radius, background, and padding.',
}),
h('Label', {
text: 'If you want to control layout then you use a Stack, then if you want styling you use a Box.',
}),
h('Label', {
text: 'Boxes also make good neutral containers.',
}),
]),
h('Box', {pad: {x: 10}}, [
h('Label', {text: 'Expandable', size: 10, weight: 'bold'}),
]),
h('Box', {border: 'default', corner: 10, pad: 6}, [
h('Expandable', {label: 'Expandable'}, [h('Label', {text: 'Content'})]),
]),
]),
h('Label', {text: 'Display TODO'}),
h('Label', {text: 'Inputs TODO'}),
h('Label', {text: 'Forms TODO'}),
h('Stack', {gap: 10, pad: {t: 20}}, [
h('Box', {pad: {x: 10}}, [
h('Label', {text: 'Avatar', size: 10, weight: 'bold'}),
]),
h('Box', {border: 'secondary', corner: 8, pad: {x: 16, y: 12}}, [
h('Stack', {direction: 'row', gap: 10}, [
h('Avatar', {uri: 'bsky.app'}),
h('Avatar', {uri: 'at://atproto.com'}),
h('Avatar', {uri: 'at://pfrazee.com/'}),
]),
]),
h('Box', {pad: {x: 10}}, [
h('Label', {text: 'ActorLabel', size: 10, weight: 'bold'}),
]),
h('Box', {border: 'secondary', corner: 8, pad: {x: 16, y: 12}}, [
h('Stack', {gap: 10}, [
h('Stack', {direction: 'row', gap: 8}, [
h('Label', {weight: 'bold', text: 'Display Name:'}),
h('ActorLabel', {uri: 'bsky.app', field: 'displayName'}),
]),
h('Stack', {direction: 'row', gap: 8}, [
h('Label', {weight: 'bold', text: 'Handle:'}),
h('ActorLabel', {uri: 'bsky.app', field: 'handle'}),
]),
h('Stack', {direction: 'row', gap: 8}, [
h('Label', {weight: 'bold', text: 'Description:'}),
h('ActorLabel', {uri: 'bsky.app', field: 'description'}),
]),
]),
]),
h('Box', {pad: {x: 10}}, [
h('Label', {text: 'Embed (Actor)', size: 10, weight: 'bold'}),
]),
h('Box', {border: 'secondary', corner: 8}, [
h('Embed', {uri: 'bsky.app'}),
]),
h('Box', {border: 'secondary', corner: 8}, [
h('Embed', {uri: 'at://atproto.com/'}),
]),
h('Box', {border: 'secondary', corner: 8}, [
h('Embed', {uri: 'at://pfrazee.com'}),
]),
h('Box', {pad: {x: 10}}, [
h('Label', {text: 'Embed (Post)', size: 10, weight: 'bold'}),
]),
h('Box', {border: 'secondary', corner: 8}, [
h('Embed', {uri: 'at://pfrazee.com/app.bsky.feed.post/3ku7fbojcqs25'}),
]),
h('Box', {border: 'secondary', corner: 8}, [
h('Embed', {uri: 'at://bsky.app/app.bsky.feed.post/3ku73zs755e27'}),
]),
h('Box', {pad: {x: 10}}, [
h('Label', {
text: 'Embed (Unsupported record type)',
size: 10,
weight: 'bold',
}),
]),
h('Box', {border: 'secondary', corner: 8}, [
h('Embed', {uri: 'at://pfrazee.com/com.example.unknown/123'}),
]),
]),
]),
])
export const DebugAppcomScreen = ({}: NativeStackScreenProps<
CommonNavigatorParams,
'DebugAppcom'
>) => {
const t = useTheme()
const [acJson, setAcJson] = React.useState(
JSON.stringify(DEFAULT_AC, null, 2),
)
const [acObj, setAcObj] = React.useState(undefined)
const [error, setError] = React.useState('')
React.useEffect(() => {
try {
setAcObj(JSON.parse(acJson))
setError('')
} catch (e: any) {
setError(e.toString())
}
}, [acJson, setAcObj, setError])
const error = '' // TODO
return (
<ScrollView>
@@ -166,15 +21,6 @@ export const DebugAppcomScreen = ({}: NativeStackScreenProps<
Application components
</Text>
<TextField.LabelText>Application JSON component</TextField.LabelText>
<TextField.Input
multiline
numberOfLines={20}
value={acJson}
onChangeText={setAcJson}
label="Application component JSON"
/>
{error && (
<View
style={[
@@ -189,16 +35,8 @@ export const DebugAppcomScreen = ({}: NativeStackScreenProps<
<View style={{height: 40}} />
{acObj && <AppComponentRegion tree={acObj} origin="@bsky.app" />}
<AppComponentRegion origin="http://localhost:3001" />
</CenteredView>
</ScrollView>
)
}
function h(type: string, props?: any | Array<any>, children?: Array<any>) {
return {
type,
props: Array.isArray(props) ? undefined : props,
children: Array.isArray(props) ? props : children,
}
}