c8c308e31e
* Update to react-query v5 * Introduce post-feed react query * Add feed refresh behaviors * Only fetch feeds of visible pages * Implement polling for latest on feeds * Add moderation filtering to slices * Handle block errors * Update feed error messages * Remove old models * Replace simple-feed option with disable-tuner option * Add missing useMemo * Implement the mergefeed and fixes to polling * Correctly handle failed load more state * Improve error and empty state behaviors * Clearer naming
274 lines
7.1 KiB
TypeScript
274 lines
7.1 KiB
TypeScript
import {AppBskyFeedDefs, AppBskyFeedGetTimeline, BskyAgent} from '@atproto/api'
|
|
import shuffle from 'lodash.shuffle'
|
|
import {timeout} from 'lib/async/timeout'
|
|
import {bundleAsync} from 'lib/async/bundle'
|
|
import {feedUriToHref} from 'lib/strings/url-helpers'
|
|
import {FeedTuner} from '../feed-manip'
|
|
import {FeedAPI, FeedAPIResponse, ReasonFeedSource} from './types'
|
|
import {FeedParams} from '#/state/queries/post-feed'
|
|
import {FeedTunerFn} from '../feed-manip'
|
|
|
|
const REQUEST_WAIT_MS = 500 // 500ms
|
|
const POST_AGE_CUTOFF = 60e3 * 60 * 24 // 24hours
|
|
|
|
export class MergeFeedAPI implements FeedAPI {
|
|
following: MergeFeedSource_Following
|
|
customFeeds: MergeFeedSource_Custom[] = []
|
|
feedCursor = 0
|
|
itemCursor = 0
|
|
sampleCursor = 0
|
|
|
|
constructor(
|
|
public agent: BskyAgent,
|
|
public params: FeedParams,
|
|
public feedTuners: FeedTunerFn[],
|
|
) {
|
|
this.following = new MergeFeedSource_Following(this.agent, this.feedTuners)
|
|
}
|
|
|
|
reset() {
|
|
this.following = new MergeFeedSource_Following(this.agent, this.feedTuners)
|
|
this.customFeeds = [] // just empty the array, they will be captured in _fetchNext()
|
|
this.feedCursor = 0
|
|
this.itemCursor = 0
|
|
this.sampleCursor = 0
|
|
if (this.params.mergeFeedEnabled && this.params.mergeFeedSources) {
|
|
this.customFeeds = shuffle(
|
|
this.params.mergeFeedSources.map(
|
|
feedUri =>
|
|
new MergeFeedSource_Custom(this.agent, feedUri, this.feedTuners),
|
|
),
|
|
)
|
|
} else {
|
|
this.customFeeds = []
|
|
}
|
|
}
|
|
|
|
async peekLatest(): Promise<AppBskyFeedDefs.FeedViewPost> {
|
|
const res = await this.agent.getTimeline({
|
|
limit: 1,
|
|
})
|
|
return res.data.feed[0]
|
|
}
|
|
|
|
async fetch({
|
|
cursor,
|
|
limit,
|
|
}: {
|
|
cursor: string | undefined
|
|
limit: number
|
|
}): Promise<FeedAPIResponse> {
|
|
if (!cursor) {
|
|
this.reset()
|
|
}
|
|
|
|
const promises = []
|
|
|
|
// always keep following topped up
|
|
if (this.following.numReady < limit) {
|
|
promises.push(this.following.fetchNext(60))
|
|
}
|
|
|
|
// pick the next feeds to sample from
|
|
const feeds = this.customFeeds.slice(this.feedCursor, this.feedCursor + 3)
|
|
this.feedCursor += 3
|
|
if (this.feedCursor > this.customFeeds.length) {
|
|
this.feedCursor = 0
|
|
}
|
|
|
|
// top up the feeds
|
|
for (const feed of feeds) {
|
|
if (feed.numReady < 5) {
|
|
promises.push(feed.fetchNext(10))
|
|
}
|
|
}
|
|
|
|
// wait for requests (all capped at a fixed timeout)
|
|
await Promise.all(promises)
|
|
|
|
// assemble a response by sampling from feeds with content
|
|
const posts: AppBskyFeedDefs.FeedViewPost[] = []
|
|
while (posts.length < limit) {
|
|
let slice = this.sampleItem()
|
|
if (slice[0]) {
|
|
posts.push(slice[0])
|
|
} else {
|
|
break
|
|
}
|
|
}
|
|
|
|
return {
|
|
cursor: posts.length ? String(this.itemCursor) : undefined,
|
|
feed: posts,
|
|
}
|
|
}
|
|
|
|
sampleItem() {
|
|
const i = this.itemCursor++
|
|
const candidateFeeds = this.customFeeds.filter(f => f.numReady > 0)
|
|
const canSample = candidateFeeds.length > 0
|
|
const hasFollows = this.following.hasMore
|
|
const hasFollowsReady = this.following.numReady > 0
|
|
|
|
// this condition establishes the frequency that custom feeds are woven into follows
|
|
const shouldSample =
|
|
i >= 15 && candidateFeeds.length >= 2 && (i % 4 === 0 || i % 5 === 0)
|
|
|
|
if (!canSample && !hasFollows) {
|
|
// no data available
|
|
return []
|
|
}
|
|
if (shouldSample || !hasFollows) {
|
|
// time to sample, or the user isnt following anybody
|
|
return candidateFeeds[this.sampleCursor++ % candidateFeeds.length].take(1)
|
|
}
|
|
if (!hasFollowsReady) {
|
|
// stop here so more follows can be fetched
|
|
return []
|
|
}
|
|
// provide follow
|
|
return this.following.take(1)
|
|
}
|
|
}
|
|
|
|
class MergeFeedSource {
|
|
sourceInfo: ReasonFeedSource | undefined
|
|
cursor: string | undefined = undefined
|
|
queue: AppBskyFeedDefs.FeedViewPost[] = []
|
|
hasMore = true
|
|
|
|
constructor(public agent: BskyAgent, public feedTuners: FeedTunerFn[]) {}
|
|
|
|
get numReady() {
|
|
return this.queue.length
|
|
}
|
|
|
|
get needsFetch() {
|
|
return this.hasMore && this.queue.length === 0
|
|
}
|
|
|
|
reset() {
|
|
this.cursor = undefined
|
|
this.queue = []
|
|
this.hasMore = true
|
|
}
|
|
|
|
take(n: number): AppBskyFeedDefs.FeedViewPost[] {
|
|
return this.queue.splice(0, n)
|
|
}
|
|
|
|
async fetchNext(n: number) {
|
|
await Promise.race([this._fetchNextInner(n), timeout(REQUEST_WAIT_MS)])
|
|
}
|
|
|
|
_fetchNextInner = bundleAsync(async (n: number) => {
|
|
const res = await this._getFeed(this.cursor, n)
|
|
if (res.success) {
|
|
this.cursor = res.data.cursor
|
|
if (res.data.feed.length) {
|
|
this.queue = this.queue.concat(res.data.feed)
|
|
} else {
|
|
this.hasMore = false
|
|
}
|
|
} else {
|
|
this.hasMore = false
|
|
}
|
|
})
|
|
|
|
protected _getFeed(
|
|
_cursor: string | undefined,
|
|
_limit: number,
|
|
): Promise<AppBskyFeedGetTimeline.Response> {
|
|
throw new Error('Must be overridden')
|
|
}
|
|
}
|
|
|
|
class MergeFeedSource_Following extends MergeFeedSource {
|
|
tuner = new FeedTuner()
|
|
|
|
reset() {
|
|
super.reset()
|
|
this.tuner.reset()
|
|
}
|
|
|
|
async fetchNext(n: number) {
|
|
return this._fetchNextInner(n)
|
|
}
|
|
|
|
protected async _getFeed(
|
|
cursor: string | undefined,
|
|
limit: number,
|
|
): Promise<AppBskyFeedGetTimeline.Response> {
|
|
const res = await this.agent.getTimeline({cursor, limit})
|
|
// run the tuner pre-emptively to ensure better mixing
|
|
const slices = this.tuner.tune(res.data.feed, this.feedTuners, {
|
|
dryRun: false,
|
|
maintainOrder: true,
|
|
})
|
|
res.data.feed = slices.map(slice => slice.rootItem)
|
|
return res
|
|
}
|
|
}
|
|
|
|
class MergeFeedSource_Custom extends MergeFeedSource {
|
|
minDate: Date
|
|
|
|
constructor(
|
|
public agent: BskyAgent,
|
|
public feedUri: string,
|
|
public feedTuners: FeedTunerFn[],
|
|
) {
|
|
super(agent, feedTuners)
|
|
this.sourceInfo = {
|
|
$type: 'reasonFeedSource',
|
|
displayName: feedUri.split('/').pop() || '',
|
|
uri: feedUriToHref(feedUri),
|
|
}
|
|
this.minDate = new Date(Date.now() - POST_AGE_CUTOFF)
|
|
this.agent.app.bsky.feed
|
|
.getFeedGenerator({
|
|
feed: feedUri,
|
|
})
|
|
.then(
|
|
res => {
|
|
if (this.sourceInfo) {
|
|
this.sourceInfo.displayName = res.data.view.displayName
|
|
}
|
|
},
|
|
_err => {},
|
|
)
|
|
}
|
|
|
|
protected async _getFeed(
|
|
cursor: string | undefined,
|
|
limit: number,
|
|
): Promise<AppBskyFeedGetTimeline.Response> {
|
|
try {
|
|
const res = await this.agent.app.bsky.feed.getFeed({
|
|
cursor,
|
|
limit,
|
|
feed: this.feedUri,
|
|
})
|
|
// NOTE
|
|
// some custom feeds fail to enforce the pagination limit
|
|
// so we manually truncate here
|
|
// -prf
|
|
if (limit && res.data.feed.length > limit) {
|
|
res.data.feed = res.data.feed.slice(0, limit)
|
|
}
|
|
// filter out older posts
|
|
res.data.feed = res.data.feed.filter(
|
|
post => new Date(post.post.indexedAt) > this.minDate,
|
|
)
|
|
// attach source info
|
|
for (const post of res.data.feed) {
|
|
post.__source = this.sourceInfo
|
|
}
|
|
return res
|
|
} catch {
|
|
// dont bubble custom-feed errors
|
|
return {success: false, headers: {}, data: {feed: []}}
|
|
}
|
|
}
|
|
}
|