Files
bsky-social-app/src/screens/Signup/StepHandle/index.tsx
T
Tomek Zawadzki 73a12c44b1 Unblock React Compiler for 5 components with early exits inside try
Where a `return` sits in the try or the catch, the `finally` body has to be
duplicated on that exit path before it can be hoisted below the try/catch.
Where a `throw` is used to jump to the catch, an explicit test replaces it.

Each of these then revealed a second cause in the same try, so the fixes go
together: an optional chain hoisted above the try where it does not depend on
anything the try produces, moved into a module-scope helper where it does, and
one `&&` in an if-test split into nested ifs.

Skipped components: 125 -> 120.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-25 16:40:33 +02:00

303 lines
9.8 KiB
TypeScript

import {useState} from 'react'
import {View} from 'react-native'
import Animated, {
FadeIn,
FadeOut,
LayoutAnimationConfig,
LinearTransition,
} from 'react-native-reanimated'
import {useSift} from '@bsky.app/sift'
import {msg} from '@lingui/core/macro'
import {useLingui} from '@lingui/react'
import {Plural, Trans} from '@lingui/react/macro'
import {
createFullHandle,
MAX_SERVICE_HANDLE_LENGTH,
validateServiceHandle,
} from '#/lib/strings/handles'
import {logger} from '#/logger'
import {
checkHandleAvailability,
useHandleAvailabilityQuery,
} from '#/state/queries/handle-availability'
import {useSignupContext} from '#/screens/Signup/state'
import {atoms as a, native, useTheme} from '#/alf'
import * as TextField from '#/components/forms/TextField'
import {useThrottledValue} from '#/components/hooks/useThrottledValue'
import {At_Stroke2_Corner0_Rounded as AtIcon} from '#/components/icons/At'
import {Check_Stroke2_Corner0_Rounded as CheckIcon} from '#/components/icons/Check'
import {Text} from '#/components/Typography'
import {useAnalytics} from '#/analytics'
import {IS_WEB} from '#/env'
import {BackNextButtons} from '../BackNextButtons'
import {HandleSuggestions} from './HandleSuggestions'
export function StepHandle() {
const {_} = useLingui()
const ax = useAnalytics()
const t = useTheme()
const {state, dispatch} = useSignupContext()
const [draftValue, setDraftValue] = useState(state.handle)
const isNextLoading = useThrottledValue(state.isLoading, 500)
/*
* Web anchors a floating Sift dropdown of suggestions to the input; native
* renders them inline and ignores this. `offset` leaves a small gap below the
* anchor, matching the inline `mt_xs` spacing.
*/
const sift = useSift({offset: a.p_xs.padding, placement: 'bottom-start'})
const validCheck = validateServiceHandle(draftValue, state.userDomain)
const {
debouncedUsername: debouncedDraftValue,
enabled: queryEnabled,
query: {data: isHandleAvailable, isPending},
} = useHandleAvailabilityQuery({
username: draftValue,
serviceDid: state.serviceDescription?.did ?? 'UNKNOWN',
serviceDomain: state.userDomain,
birthDate: state.dateOfBirth.toISOString(),
email: state.email,
enabled: validCheck.overall,
})
const onNextPress = async () => {
const handle = draftValue.trim()
dispatch({
type: 'setHandle',
value: handle,
})
if (!validCheck.overall) {
return
}
dispatch({type: 'setIsLoading', value: true})
const serviceDid = state.serviceDescription?.did ?? 'UNKNOWN'
try {
const {available: handleAvailable} = await checkHandleAvailability(
createFullHandle(handle, state.userDomain),
serviceDid,
{},
)
if (!handleAvailable) {
ax.metric('signup:handleTaken', {typeahead: false})
dispatch({
type: 'setError',
value: _(msg`That username is already taken`),
field: 'handle',
})
dispatch({type: 'setIsLoading', value: false})
return
} else {
ax.metric('signup:handleAvailable', {typeahead: false})
}
} catch (error) {
logger.error('Failed to check handle availability on next press', {
safeMessage: error,
})
// do nothing on error, let them pass
}
dispatch({type: 'setIsLoading', value: false})
ax.metric('signup:nextPressed', {
activeStep: state.activeStep,
phoneVerificationRequired:
state.serviceDescription?.phoneVerificationRequired,
})
// phoneVerificationRequired is actually whether a captcha is required
if (!state.serviceDescription?.phoneVerificationRequired) {
dispatch({
type: 'submit',
task: {verificationCode: undefined, mutableProcessed: false},
})
return
}
dispatch({type: 'next'})
}
const onBackPress = () => {
const handle = draftValue.trim()
dispatch({
type: 'setHandle',
value: handle,
})
dispatch({type: 'prev'})
ax.metric('signup:backPressed', {activeStep: state.activeStep})
}
const hasDebounceSettled = draftValue === debouncedDraftValue
const isHandleTaken =
!isPending &&
queryEnabled &&
isHandleAvailable &&
!isHandleAvailable.available
const isNotReady = isPending || !hasDebounceSettled
const isNextDisabled =
!validCheck.overall || !!state.error || isNotReady ? true : isHandleTaken
const textFieldInvalid =
isHandleTaken ||
!validCheck.frontLengthNotTooLong ||
!validCheck.handleChars ||
!validCheck.hyphenStartOrEnd ||
!validCheck.totalLength
/*
* Web-only Sift wiring. The anchor is the input section, whose bottom edge in
* the taken-and-valid state sits right below the availability error, so the
* floating dropdown lands beneath it. The input ref feeds Sift's keyboard
* handling and the combobox a11y props describe the typeahead relationship.
* Native ignores all of this and renders suggestions inline.
*/
const {ref: inputAnchorRef, ...comboboxProps} = sift.targetProps
return (
<>
<View
collapsable={false}
ref={IS_WEB ? sift.refs.setAnchor : undefined}
onLayout={IS_WEB ? () => void sift.updatePosition() : undefined}
style={[a.gap_sm, a.pt_lg, a.z_10]}>
<View>
<TextField.Root isInvalid={textFieldInvalid}>
<TextField.Icon icon={AtIcon} />
<TextField.Input
{...(IS_WEB ? comboboxProps : {})}
inputRef={IS_WEB ? inputAnchorRef : undefined}
testID="handleInput"
onChangeText={val => {
if (state.error) {
dispatch({type: 'setError', value: ''})
}
setDraftValue(val.toLocaleLowerCase())
}}
label={state.userDomain}
value={draftValue}
keyboardType="ascii-capable" // fix for iOS replacing -- with —
autoCapitalize="none"
autoCorrect={false}
autoFocus
autoComplete="off"
/>
{draftValue.length > 0 && (
<TextField.GhostText value={state.userDomain}>
{draftValue}
</TextField.GhostText>
)}
{isHandleAvailable?.available && (
<CheckIcon
testID="handleAvailableCheck"
style={[{color: t.palette.positive_500}, a.z_20]}
/>
)}
</TextField.Root>
</View>
<LayoutAnimationConfig skipEntering skipExiting>
{/* Reserve space for one line of text to avoid layout shift. */}
<View style={[a.gap_xs, {minHeight: 21}]}>
{state.error && (
<Requirement>
<RequirementText>{state.error}</RequirementText>
</Requirement>
)}
{isHandleTaken && validCheck.overall && (
<>
<Requirement>
<RequirementText>
<Trans>
{createFullHandle(draftValue, state.userDomain)} is not
available
</Trans>
</RequirementText>
</Requirement>
{isHandleAvailable.suggestions &&
isHandleAvailable.suggestions.length > 0 && (
<HandleSuggestions
sift={sift}
suggestions={isHandleAvailable.suggestions}
onSelect={suggestion => {
setDraftValue(
suggestion.handle.slice(
0,
state.userDomain.length * -1,
),
)
ax.metric('signup:handleSuggestionSelected', {
method: suggestion.method,
})
}}
/>
)}
</>
)}
{(!validCheck.handleChars || !validCheck.hyphenStartOrEnd) && (
<Requirement>
{!validCheck.hyphenStartOrEnd ? (
<RequirementText>
<Trans>Username cannot begin or end with a hyphen</Trans>
</RequirementText>
) : (
<RequirementText>
<Trans>
Username must only contain letters (a-z), numbers, and
hyphens
</Trans>
</RequirementText>
)}
</Requirement>
)}
<Requirement>
{(!validCheck.frontLengthNotTooLong ||
!validCheck.totalLength) && (
<RequirementText>
<Trans>
Username cannot be longer than{' '}
<Plural
value={MAX_SERVICE_HANDLE_LENGTH}
other="# characters"
/>
</Trans>
</RequirementText>
)}
</Requirement>
</View>
</LayoutAnimationConfig>
</View>
<Animated.View layout={native(LinearTransition)}>
<BackNextButtons
isLoading={isNextLoading}
isNextDisabled={isNextDisabled}
onBackPress={onBackPress}
onNextPress={() => void onNextPress()}
/>
</Animated.View>
</>
)
}
function Requirement({children}: {children: React.ReactNode}) {
return (
<Animated.View
style={[a.w_full]}
layout={native(LinearTransition)}
entering={native(FadeIn)}
exiting={native(FadeOut)}>
{children}
</Animated.View>
)
}
function RequirementText({children}: {children: React.ReactNode}) {
const t = useTheme()
return (
<Text style={[a.text_sm, a.flex_1, {color: t.palette.negative_500}]}>
{children}
</Text>
)
}