Files
bsky-social-app/src
Samuel Newman 3d7cee234d restore metadata dep in analytics useChild memo
The phase-2 session rework dropped `metadata` from the child logger's
useMemo deps to satisfy exhaustive-deps (which misclassifies the
closure-captured value as outer-scope because createLogger is defined
outside a component - lint-staged's --fix strips the dep on commit).
But AnalyticsContext explicitly re-renders (not remounts) on account
change with a new did, producing a fresh createLogger closure with new
metadata; a mounted consumer's memoized child logger kept the previous
account's metadata, misattributing telemetry across session switches.
Suppress the rule with the why and keep the dep.

Found by a full-diff roast pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-30 18:20:11 +03:00
..
2026-03-25 00:50:26 -07:00