vineyardbovines
434d56ad00
B1: Android encoder format now sets KEY_COLOR_STANDARD = BT709, KEY_COLOR_TRANSFER = SDR_VIDEO, KEY_COLOR_RANGE = LIMITED (API 24+). Previously the encoder inherited or emitted default color metadata, which meant HDR sources produced incorrectly-tagged output on Android. iOS already had AVVideoColorPropertiesKey set correctly. B2: Replace single currentCompressor reference with a per-job map keyed by jobId. The cancel function now takes a jobId and only cancels that specific job. Prevents the previous race where a second compress call overwrote the reference and made the first job uncancellable. B3: Clamp frameRateCap to >= 1 at the native module boundary. Previously a value of 0 from JS would cause divide-by-zero (Android Long division ArithmeticException, iOS CMTime Infinity / Int32(0) frameDuration trap).
88 lines
2.1 KiB
TypeScript
88 lines
2.1 KiB
TypeScript
import {type EventSubscription} from 'expo-modules-core'
|
|
|
|
import NativeModule from './src/ExpoBlueskyVideoCompressModule'
|
|
import {
|
|
type CodecPreference,
|
|
type CompressCallbacks,
|
|
type CompressOptions,
|
|
type CompressResult,
|
|
type VideoMetadata,
|
|
} from './src/types'
|
|
|
|
export type {
|
|
CodecPreference,
|
|
CompressCallbacks,
|
|
CompressOptions,
|
|
CompressResult,
|
|
VideoMetadata,
|
|
}
|
|
|
|
class AbortError extends Error {
|
|
name = 'AbortError'
|
|
constructor() {
|
|
super('Aborted')
|
|
}
|
|
}
|
|
|
|
let jobIdCounter = 0
|
|
|
|
export function probe(uri: string): Promise<VideoMetadata> {
|
|
return NativeModule.probe(uri)
|
|
}
|
|
|
|
export function compress(
|
|
uri: string,
|
|
options: CompressOptions = {},
|
|
callbacks?: CompressCallbacks,
|
|
): Promise<CompressResult> {
|
|
const jobId = ++jobIdCounter
|
|
let subscription: EventSubscription | undefined
|
|
|
|
if (callbacks?.signal?.aborted) {
|
|
return Promise.reject(new AbortError())
|
|
}
|
|
|
|
const nativeOptions = {
|
|
targetBitrate: options.targetBitrate ?? 0,
|
|
maxSize: options.maxSize ?? 1920,
|
|
codec: options.codec ?? 'auto',
|
|
frameRateCap: options.frameRateCap ?? 30,
|
|
jobId,
|
|
}
|
|
|
|
return new Promise<CompressResult>((resolve, reject) => {
|
|
if (callbacks?.onProgress) {
|
|
subscription = NativeModule.addListener(
|
|
'onProgress',
|
|
(event: {id: number; progress: number}) => {
|
|
if (event.id === jobId) {
|
|
callbacks.onProgress!(event.progress)
|
|
}
|
|
},
|
|
)
|
|
}
|
|
|
|
const abortHandler = () => {
|
|
NativeModule.cancel(jobId)
|
|
subscription?.remove()
|
|
reject(new AbortError())
|
|
}
|
|
|
|
if (callbacks?.signal) {
|
|
callbacks.signal.addEventListener('abort', abortHandler, {once: true})
|
|
}
|
|
|
|
NativeModule.compress(uri, nativeOptions)
|
|
.then(result => {
|
|
callbacks?.signal?.removeEventListener('abort', abortHandler)
|
|
subscription?.remove()
|
|
resolve(result)
|
|
})
|
|
.catch((error: unknown) => {
|
|
callbacks?.signal?.removeEventListener('abort', abortHandler)
|
|
subscription?.remove()
|
|
reject(error instanceof Error ? error : new Error(String(error)))
|
|
})
|
|
})
|
|
}
|