acetheking987/bsky-social-app
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity
8,013 Commits 2,383 Branches 91 Tags
@tomekzaw/react-compiler-finally-leftovers
Commit Graph

6792 Commits

Author SHA1 Message Date
Tomek Zawadzki e991e3f64f Keep the DeleteAccountDialog guard inside the try 
Addresses review feedback on #11545. Hoisting the guard above the try moved the
throw past the catch, so a falsy did became an unhandled rejection with no
inline error, no log and no step reset.

Reverting outright would re-break compilation - confirmDeletion is a nested
callback of the component, so its throw is part of the same compiled unit. The
check stays where it was; only the throw and the optional chain move to a
module-scope requireAccount.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
 2026-08-25 17:35:15 +02:00
Tomek Zawadzki 5fa9e3cc1c Correct the withCleanup docblock 
The constraint is that the try must contain no `return` meant to exit the
enclosing function, not that the try must be the whole function body - four of
the five call sites have statements around the try and are fine.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
 2026-08-25 17:26:43 +02:00
Tomek Zawadzki dfa98d5946 Unblock React Compiler for 6 components with try/finally that cannot hoist 
The earlier pass moved `finally` bodies below the try/catch, which is only
valid when a `catch` completes normally. These are the leftovers.

Where the catch does complete normally but a nested callback happened to
contain a `return`, the same hoist applies after all - InterestsSettings and
DeleteAccountDialog were false positives in the first pass's scan.

Where there is no `catch`, the cleanup has to survive the throw path, so the
try/finally moves into `withCleanup` at module scope instead. Same semantics,
outside the compiled function.

Skipped components: 125 -> 119.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
 2026-08-25 16:31:59 +02:00
Samuel Newman f87fdd2ea2 Enable React Native strict TypeScript API (#11459) 2026-08-25 09:40:14 +03:00
pfrazee 5f3d24efab Nightly source-language update 2026-08-25 02:30:39 +00:00
Samuel Newman cf2684b0d1 Send an integer exp for video upload service auth tokens (#11529) 
Co-authored-by: Claude <noreply@anthropic.com>
 2026-08-24 17:34:16 -07:00
Samuel Newman 95f5360012 Fix iOS message input height after sending (#11533) 2026-08-24 17:28:56 -07:00
DS Boyce 6b35d3de1c Revert "Send beta user state with AppView requests (#11474)" (#11510) 2026-08-24 11:40:15 -07:00
DS Boyce 6f46927c28 Overfetch trending topics before filtering (#11477) 2026-08-24 11:39:46 -07:00
Spence Pope 6009e61ae9 [APP-2922] Fix cached starter pack navigation (#11531) 2026-08-24 09:34:45 -04:00
pfrazee 97a85bb73d Nightly source-language update 2026-08-24 02:34:37 +00:00
Spence Pope 5e01a6c7ee Explain trending topics in options menu (#11521) 2026-08-23 20:23:38 -04:00
pfrazee 9047df5413 Nightly source-language update 2026-08-22 02:28:32 +00:00
RetroSunstar f48fab872e Adds a small padding for labeller avatars in group chat 'Add people' selector (#11422) 2026-08-21 15:12:14 -05:00
Samuel Newman 06cb80a4c3 [AA] Set maxAge: Infinity on age assurance cache (#11526) 2026-08-21 10:32:15 -07:00
Oleksii Bulenok 63f0d4d311 Fix hairline divider not visible (#11518) 2026-08-21 11:57:21 +02:00
Tomasz Zawadzki a892057e29 Fix "Tried to synchronously call a Remote Function" crash (#11517) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-20 17:56:50 +02:00
Spence Pope 6406a2ef4d translations (#11511) 2026-08-19 19:55:50 -04:00
Samuel Newman c19fec3f48 Invert password reveal eye icon (#11365) 
Co-authored-by: Claude <noreply@anthropic.com>
 2026-08-19 07:37:01 -07:00
Samuel Newman 11c80a1fbd Fix profile handle resolution errors (#11503) 2026-08-19 07:34:45 -07:00
Tomasz Zawadzki 0e04159335 Unblock React Compiler for PostFeed (#11451) 
Co-authored-by: Oleksii Bulenok <oleksii.bulenok@swmansion.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-19 06:28:53 -07:00
Samuel Newman 04ca3f9829 Only persist successful queries (#11484) 2026-08-19 06:27:41 -07:00
Samuel Newman 51381d41b0 Clear the cached initial URL after handling a deep link (#11500) 
Co-authored-by: Claude <noreply@anthropic.com>
 2026-08-19 06:26:58 -07:00
pfrazee c4172cef99 Nightly source-language update 2026-08-19 02:30:40 +00:00
DS Boyce cc3622b583 Send beta user state with AppView requests (#11474) 2026-08-18 09:50:15 -07:00
Oleksii Bulenok 45aa1a67b0 Expo 57 (#11334) 
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Co-authored-by: vineyardbovines <spencerfpope@gmail.com>
 2026-08-18 10:46:11 -04:00
Spence Pope 7f59d8fcfb APP-2859 Add web list performance telemetry (#11486) 2026-08-18 09:26:50 -04:00
Spence Pope df3cea1c78 APP-2884: Avoid base64 reads for web videos (#11493) 2026-08-18 09:26:26 -04:00
Oleksii Bulenok e87ec032cd Truncate gif alt text to 2000 symbols (#11488) 2026-08-18 11:29:23 +02:00
pfrazee 3b7284a86b Nightly source-language update 2026-08-18 02:29:23 +00:00
DS Boyce 01486d27e0 Add pagination to feed search (#11475) 2026-08-17 09:55:45 -07:00
pfrazee 4562ca8e38 Nightly source-language update 2026-08-17 02:32:20 +00:00
Spence Pope 0ba971b1f6 APP-2774: Add algorithmic visibility setting (#11417) 2026-08-16 17:13:17 -04:00
pfrazee 34b6f1d323 Nightly source-language update 2026-08-15 02:27:20 +00:00
DS Boyce 221c4d9c5b Fix size of post numbers with emoji-only posts (#11471) 2026-08-14 12:58:55 -07:00
Oleksii Bulenok 2d93273956 Fix metro failing to resolve @ipld/dag-cbor in dev mode (#11467) 2026-08-14 14:37:11 +02:00
Samuel Newman 70195d7059 Drop accidental eslint dependency (#11460) 2026-08-14 00:21:52 -07:00
pfrazee afb3cdc26f Nightly source-language update 2026-08-14 03:00:15 +00:00
Samuel Newman bb33eb91cb [SDK] Use finalised package (#11398) 2026-08-13 12:26:23 -07:00
Samuel Newman b89167f07c [SDK] Address stack review feedback (#11389) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:23 -07:00
Samuel Newman 3677c98873 [SDK] Validate and brand the persisted account did (#11387) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:22 -07:00
Samuel Newman 9fe0084874 [SDK] Remove @atproto/api (#11386) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:22 -07:00
Samuel Newman 54da80dfb0 [SDK] Delete the bridge agent and rework the session bundle onto lex clients (#11385) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:22 -07:00
Samuel Newman 59d2bf09d7 [SDK] Swap moderation to @bsky.app/sdk and move labeler config to Client statics (#11383) 2026-08-13 12:26:21 -07:00
Samuel Newman dc31e7fd12 [SDK] Migrate agent sugar to @bsky.app/sdk actions (#11382) 2026-08-13 12:26:21 -07:00
Samuel Newman a4f2811f39 [SDK] Add refreshSession and migrate the session-pinned infra (#11381) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:20 -07:00
Samuel Newman 0c93d1e416 [SDK] Migrate the post pipeline and blob uploads (#11380) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:20 -07:00
Samuel Newman 75e4180800 [SDK] Migrate the repo writes cluster (#11379) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:20 -07:00
Samuel Newman ca226f589d [SDK] Migrate the gate records to raw repo calls on the pds client (#11378) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:19 -07:00
Samuel Newman 3568cdc42d [SDK] Migrate getAllListMembers to the appview client (#11377) 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
 2026-08-13 12:26:19 -07:00