Add video upload telemetry events (#10991)
This commit is contained in:
@@ -73,6 +73,7 @@ import {
|
||||
} from '#/lib/constants'
|
||||
import {useIsKeyboardVisible} from '#/lib/hooks/useIsKeyboardVisible'
|
||||
import {useNonReactiveCallback} from '#/lib/hooks/useNonReactiveCallback'
|
||||
import {createVideoTelemetry} from '#/lib/media/video/telemetry'
|
||||
import {mimeToExt} from '#/lib/media/video/util'
|
||||
import {useCallOnce} from '#/lib/once'
|
||||
import {type NavigationProp} from '#/lib/routes/types'
|
||||
@@ -387,6 +388,12 @@ export const ComposePost = ({
|
||||
const selectVideo = useCallback(
|
||||
(postId: string, asset: ImagePickerAsset) => {
|
||||
const abortController = new AbortController()
|
||||
const telemetry = createVideoTelemetry({
|
||||
asset,
|
||||
signal: abortController.signal,
|
||||
metric: ax.metric,
|
||||
})
|
||||
telemetry.picked()
|
||||
composerDispatch({
|
||||
type: 'update_post',
|
||||
postId: postId,
|
||||
@@ -394,6 +401,7 @@ export const ComposePost = ({
|
||||
type: 'embed_add_video',
|
||||
asset,
|
||||
abortController,
|
||||
telemetry,
|
||||
},
|
||||
})
|
||||
void processVideo(
|
||||
@@ -412,9 +420,10 @@ export const ComposePost = ({
|
||||
currentDid,
|
||||
abortController.signal,
|
||||
i18n,
|
||||
telemetry,
|
||||
)
|
||||
},
|
||||
[i18n, agent, currentDid, composerDispatch],
|
||||
[i18n, agent, currentDid, composerDispatch, ax.metric],
|
||||
)
|
||||
|
||||
const onInitVideo = useNonReactiveCallback(() => {
|
||||
@@ -494,6 +503,12 @@ export const ComposePost = ({
|
||||
|
||||
// Start video processing using existing flow
|
||||
const abortController = new AbortController()
|
||||
const telemetry = createVideoTelemetry({
|
||||
asset,
|
||||
signal: abortController.signal,
|
||||
metric: ax.metric,
|
||||
})
|
||||
telemetry.picked()
|
||||
composerDispatch({
|
||||
type: 'update_post',
|
||||
postId,
|
||||
@@ -501,6 +516,7 @@ export const ComposePost = ({
|
||||
type: 'embed_add_video',
|
||||
asset,
|
||||
abortController,
|
||||
telemetry,
|
||||
},
|
||||
})
|
||||
|
||||
@@ -559,6 +575,7 @@ export const ComposePost = ({
|
||||
currentDid,
|
||||
abortController.signal,
|
||||
i18n,
|
||||
telemetry,
|
||||
)
|
||||
} catch (e) {
|
||||
logger.error('Failed to restore video from draft', {
|
||||
@@ -567,7 +584,7 @@ export const ComposePost = ({
|
||||
})
|
||||
}
|
||||
},
|
||||
[i18n, agent, currentDid, composerDispatch],
|
||||
[i18n, agent, currentDid, composerDispatch, ax.metric],
|
||||
)
|
||||
|
||||
const handleSelectDraft = useCallback(
|
||||
@@ -979,6 +996,15 @@ export const ComposePost = ({
|
||||
})
|
||||
).uris[0]
|
||||
|
||||
// Fire published event for every video that made it into the post.
|
||||
// The status guard upstream ensures each video.telemetry is present and
|
||||
// processing has completed by this point.
|
||||
for (const post of filteredThread.posts) {
|
||||
if (post.embed.media?.type === 'video') {
|
||||
post.embed.media.video.telemetry?.published()
|
||||
}
|
||||
}
|
||||
|
||||
/*
|
||||
* Wait for app view to have received the post(s). If this fails, it's
|
||||
* ok, because the post _was_ actually published above.
|
||||
|
||||
Reference in New Issue
Block a user