acetheking987/bsky-social-app
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

isLastSiblingByCounts isn't needed, should rely only on the count of replies seen

Browse Source
This commit is contained in:
Eric Bailey
2025-10-14 15:40:32 -05:00
parent b928e27c18
commit fceec83e08
1 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/state/queries/usePostThread/traversal.ts
+1 -12
View File
@@ -266,15 +266,6 @@ export function sortAndAnnotateThreadItems(
if (nextItem?.type === 'threadPost') if (nextItem?.type === 'threadPost')
metadata.nextItemDepth = nextItem?.depth metadata.nextItemDepth = nextItem?.depth
/*
* Item is the last "sibling" if we know for sure we're out of
* replies on the parent (even though this item itself may have its
* own reply branches).
*/
const isLastSiblingByCounts =
metadata.replyIndex ===
metadata.parentMetadata.repliesIndexCounter - 1
/** /**
* Item is also the last "sibling" if its index matches the total * Item is also the last "sibling" if its index matches the total
* number of replies we're actually able to render to the page. * number of replies we're actually able to render to the page.
@@ -298,9 +289,7 @@ export function sortAndAnnotateThreadItems(
* Ok now we can set the last sibling state. * Ok now we can set the last sibling state.
*/ */
metadata.isLastSibling = metadata.isLastSibling =
isLastSiblingByCounts || isImplicitlyLastSibling || isLastSiblingDueToMissingReplies
isImplicitlyLastSibling ||
isLastSiblingDueToMissingReplies
/* /*
* Item is the last "child" in a branch if there is no next item, * Item is the last "child" in a branch if there is no next item,