diff --git a/src/components/VideoPostCard.tsx b/src/components/VideoPostCard.tsx index 4b75354e17..b487b0d8ac 100644 --- a/src/components/VideoPostCard.tsx +++ b/src/components/VideoPostCard.tsx @@ -47,7 +47,7 @@ export function VideoPostCard({ /** * Callback for metrics etc */ - onInteract: () => void + onInteract?: () => void }) { const t = useTheme() const {_, i18n} = useLingui() @@ -81,7 +81,7 @@ export function VideoPostCard({ }, }} onPress={() => { - onInteract() + onInteract?.() }} onPressIn={onPressIn} onPressOut={onPressOut} @@ -334,7 +334,7 @@ export function CompactVideoPostCard({ /** * Callback for metrics etc */ - onInteract: () => void + onInteract?: () => void }) { const t = useTheme() const {_, i18n} = useLingui() @@ -366,7 +366,7 @@ export function CompactVideoPostCard({ }, }} onPress={() => { - onInteract() + onInteract?.() }} onPressIn={onPressIn} onPressOut={onPressOut} diff --git a/src/components/feeds/PostFeedVideoGridRow.tsx b/src/components/feeds/PostFeedVideoGridRow.tsx index 688fb961a1..7200afc0c1 100644 --- a/src/components/feeds/PostFeedVideoGridRow.tsx +++ b/src/components/feeds/PostFeedVideoGridRow.tsx @@ -1,6 +1,7 @@ import {View} from 'react-native' import {AppBskyEmbedVideo} from '@atproto/api' +import {logEvent} from '#/lib/statsig/statsig' import {FeedPostSliceItem} from '#/state/queries/post-feed' import {VideoFeedSourceContext} from '#/screens/VideoFeed/types' import {atoms as a, useGutters} from '#/alf' @@ -41,6 +42,9 @@ export function PostFeedVideoGridRow({ post={post.post} sourceContext={sourceContext} moderation={post.moderation} + onInteract={() => { + logEvent('videoCard:click', {context: 'feed'}) + }} /> ))} diff --git a/src/components/interstitials/TrendingVideos.tsx b/src/components/interstitials/TrendingVideos.tsx index 3aac27a0f8..d43d988ac2 100644 --- a/src/components/interstitials/TrendingVideos.tsx +++ b/src/components/interstitials/TrendingVideos.tsx @@ -31,7 +31,7 @@ export function TrendingVideos() { const onConfirmHide = React.useCallback(() => { setTrendingVideoDisabled(true) - logEvent('trendingVideos:hide', {context: 'interstitial'}) + logEvent('trendingVideos:hide', {context: 'interstitial:discover'}) }, [setTrendingVideoDisabled]) if (error) { @@ -113,7 +113,9 @@ export function TrendingVideos() { uri: VIDEO_FEED_URI, }} onInteract={() => { - logEvent('trendingVideo:click', {context: 'interstitial'}) + logEvent('videoCard:click', { + context: 'interstitial:discover', + }) }} /> diff --git a/src/lib/statsig/events.ts b/src/lib/statsig/events.ts index ca1f683e98..1a680c211d 100644 --- a/src/lib/statsig/events.ts +++ b/src/lib/statsig/events.ts @@ -253,10 +253,10 @@ export type LogEvents = { context: 'settings' } 'trendingVideos:hide': { - context: 'settings' | 'interstitial' | 'explore' + context: 'settings' | 'interstitial:discover' | 'interstitial:explore' } - 'trendingVideo:click': { - context: 'interstitial' | 'explore' + 'videoCard:click': { + context: 'interstitial:discover' | 'interstitial:explore' | 'feed' } 'progressGuide:hide': {} diff --git a/src/screens/Search/components/ExploreTrendingVideos.tsx b/src/screens/Search/components/ExploreTrendingVideos.tsx index cdd914201e..0bc62d7aa3 100644 --- a/src/screens/Search/components/ExploreTrendingVideos.tsx +++ b/src/screens/Search/components/ExploreTrendingVideos.tsx @@ -10,7 +10,7 @@ import {isWeb} from '#/platform/detection' import {useSavedFeeds} from '#/state/queries/feed' import {usePostFeedQuery} from '#/state/queries/post-feed' import {useAddSavedFeedsMutation} from '#/state/queries/preferences' -import {atoms as a, tokens,useGutters, useTheme} from '#/alf' +import {atoms as a, tokens, useGutters, useTheme} from '#/alf' import {Button, ButtonIcon, ButtonText} from '#/components/Button' import {GradientFill} from '#/components/GradientFill' import {Pin_Stroke2_Corner0_Rounded as Pin} from '#/components/icons/Pin' @@ -134,7 +134,9 @@ export function ExploreTrendingVideos() { uri: VIDEO_FEED_URI, }} onInteract={() => { - logEvent('trendingVideo:click', {context: 'interstitial'}) + logEvent('videoCard:click', { + context: 'interstitial:explore', + }) }} />