Remove autofocus from alt text input (#5727)

* remove autofocus from alt text input

* open to full height
This commit is contained in:
Hailey
2024-10-11 16:32:31 -07:00
committed by GitHub
parent 0f7cd2b74d
commit eaba658419
2 changed files with 9 additions and 7 deletions
+5 -4
View File
@@ -1,5 +1,5 @@
import React, {useState} from 'react' import React, {useState} from 'react'
import {TouchableOpacity, View} from 'react-native' import {Dimensions, TouchableOpacity, View} from 'react-native'
import {msg, Trans} from '@lingui/macro' import {msg, Trans} from '@lingui/macro'
import {useLingui} from '@lingui/react' import {useLingui} from '@lingui/react'
@@ -9,7 +9,7 @@ import {
EmbedPlayerParams, EmbedPlayerParams,
parseEmbedPlayerFromUrl, parseEmbedPlayerFromUrl,
} from '#/lib/strings/embed-player' } from '#/lib/strings/embed-player'
import {isAndroid} from '#/platform/detection' import {isAndroid, isWeb} from '#/platform/detection'
import {useResolveGifQuery} from '#/state/queries/resolve-link' import {useResolveGifQuery} from '#/state/queries/resolve-link'
import {Gif} from '#/state/queries/tenor' import {Gif} from '#/state/queries/tenor'
import {AltTextCounterWrapper} from '#/view/com/composer/AltTextCounterWrapper' import {AltTextCounterWrapper} from '#/view/com/composer/AltTextCounterWrapper'
@@ -107,7 +107,8 @@ export function GifAltTextDialogLoaded({
control={control} control={control}
onClose={() => { onClose={() => {
onSubmit(altTextDraft) onSubmit(altTextDraft)
}}> }}
nativeOptions={{minHeight: Dimensions.get('window').height}}>
<Dialog.Handle /> <Dialog.Handle />
<AltTextInner <AltTextInner
vendorAltText={vendorAltText} vendorAltText={vendorAltText}
@@ -157,7 +158,7 @@ function AltTextInner({
defaultValue={altText} defaultValue={altText}
multiline multiline
numberOfLines={3} numberOfLines={3}
autoFocus autoFocus={isWeb}
onKeyPress={({nativeEvent}) => { onKeyPress={({nativeEvent}) => {
if (nativeEvent.key === 'Escape') { if (nativeEvent.key === 'Escape') {
control.close() control.close()
@@ -1,5 +1,5 @@
import React from 'react' import React from 'react'
import {ImageStyle, useWindowDimensions, View} from 'react-native' import {Dimensions, ImageStyle, useWindowDimensions, View} from 'react-native'
import {Image} from 'expo-image' import {Image} from 'expo-image'
import {msg, Trans} from '@lingui/macro' import {msg, Trans} from '@lingui/macro'
import {useLingui} from '@lingui/react' import {useLingui} from '@lingui/react'
@@ -38,7 +38,8 @@ export const ImageAltTextDialog = ({
...image, ...image,
alt: enforceLen(altText, MAX_ALT_TEXT, true), alt: enforceLen(altText, MAX_ALT_TEXT, true),
}) })
}}> }}
nativeOptions={{minHeight: Dimensions.get('window').height}}>
<Dialog.Handle /> <Dialog.Handle />
<ImageAltTextInner <ImageAltTextInner
control={control} control={control}
@@ -122,7 +123,7 @@ const ImageAltTextInner = ({
defaultValue={altText} defaultValue={altText}
multiline multiline
numberOfLines={3} numberOfLines={3}
autoFocus autoFocus={isWeb}
/> />
</TextField.Root> </TextField.Root>
</View> </View>