Attempted video perf improvements (#6519)

* remove layout animations from video

* only show button/spinner when necessary

* use native activityindicator rather than loader
This commit is contained in:
Samuel Newman
2024-11-19 12:50:06 +00:00
committed by GitHub
parent 9a57d2a538
commit ea3fe93be9
3 changed files with 32 additions and 38 deletions
@@ -1,8 +1,8 @@
import React from 'react'
import {StyleProp, ViewStyle} from 'react-native'
import Animated, {FadeInDown, FadeOutDown} from 'react-native-reanimated'
import {View} from 'react-native'
import {atoms as a, native, useTheme} from '#/alf'
import {atoms as a, useTheme} from '#/alf'
import {Text} from '#/components/Typography'
/**
@@ -26,9 +26,7 @@ export function TimeIndicator({
const seconds = String(time % 60).padStart(2, '0')
return (
<Animated.View
entering={native(FadeInDown.duration(300))}
exiting={native(FadeOutDown.duration(500))}
<View
pointerEvents="none"
style={[
{
@@ -52,6 +50,6 @@ export function TimeIndicator({
]}>
{`${minutes}:${seconds}`}
</Text>
</Animated.View>
</View>
)
}
@@ -1,6 +1,5 @@
import React, {useRef} from 'react'
import {Pressable, StyleProp, View, ViewStyle} from 'react-native'
import Animated, {FadeInDown} from 'react-native-reanimated'
import {AppBskyEmbedVideo} from '@atproto/api'
import {BlueskyVideoView} from '@haileyok/bluesky-video'
import {msg} from '@lingui/macro'
@@ -182,8 +181,7 @@ function ControlButton({
style?: StyleProp<ViewStyle>
}) {
return (
<Animated.View
entering={FadeInDown.duration(300)}
<View
style={[
a.absolute,
a.rounded_full,
@@ -207,6 +205,6 @@ function ControlButton({
hitSlop={HITSLOP_30}>
{children}
</Pressable>
</Animated.View>
</View>
)
}