Fixes to feed preference and state sync [APP-678] (#829)

* Remove extraneous custom-feed health check

* Fixes to custom feed preference sync

* Fix lint

* Fix to how preferences are synced to enable membership modifications

src/state/models/feeds/posts.ts

@@ -436,9 +436,6 @@ export class PostsFeedModel {
     } else if (this.feedType === 'home') {
       return this.rootStore.agent.getTimeline(params as GetTimeline.QueryParams)
     } else if (this.feedType === 'custom') {
-      this.checkIfCustomFeedIsOnlineAndValid(
-        params as GetCustomFeed.QueryParams,
-      )
       return this.rootStore.agent.app.bsky.feed.getFeed(
         params as GetCustomFeed.QueryParams,
       )
@@ -448,18 +445,4 @@ export class PostsFeedModel {
       )
     }
   }
-
-  private async checkIfCustomFeedIsOnlineAndValid(
-    params: GetCustomFeed.QueryParams,
-  ) {
-    const res = await this.rootStore.agent.app.bsky.feed.getFeedGenerator({
-      feed: params.feed,
-    })
-    if (!res.data.isOnline || !res.data.isValid) {
-      runInAction(() => {
-        this.error =
-          'This custom feed is not online or may be experiencing issues.'
-      })
-    }
-  }
 }