revert changes to scroll forwarder (#8328)

This commit is contained in:
hailey
2025-05-05 00:20:34 -07:00
committed by GitHub
parent abbdeb4f28
commit e7fe9ab553
@@ -9,7 +9,7 @@ class ExpoScrollForwarderView: ExpoView, UIGestureRecognizerDelegate {
} }
} }
private var scrollView: UIScrollView? private var rctScrollView: RCTScrollView?
private var rctRefreshCtrl: RCTRefreshControl? private var rctRefreshCtrl: RCTRefreshControl?
private var cancelGestureRecognizers: [UIGestureRecognizer]? private var cancelGestureRecognizers: [UIGestureRecognizer]?
private var animTimer: Timer? private var animTimer: Timer?
@@ -68,7 +68,7 @@ class ExpoScrollForwarderView: ExpoView, UIGestureRecognizerDelegate {
} }
@IBAction func callOnPan(_ sender: UIPanGestureRecognizer) { @IBAction func callOnPan(_ sender: UIPanGestureRecognizer) {
guard let sv = self.scrollView else { guard let rctsv = self.rctScrollView, let sv = rctsv.scrollView else {
return return
} }
@@ -113,7 +113,7 @@ class ExpoScrollForwarderView: ExpoView, UIGestureRecognizerDelegate {
} }
func startDecayAnimation(_ translation: CGFloat, _ velocity: CGFloat) { func startDecayAnimation(_ translation: CGFloat, _ velocity: CGFloat) {
guard let sv = self.scrollView else { guard let sv = self.rctScrollView?.scrollView else {
return return
} }
@@ -161,48 +161,31 @@ class ExpoScrollForwarderView: ExpoView, UIGestureRecognizerDelegate {
return offset return offset
} }
private func findScrollView(in view: UIView, foundCount: Int) -> UIScrollView? { func tryFindScrollView() {
var foundCount = foundCount guard let scrollViewTag = scrollViewTag else {
if let sv = view as? UIScrollView { return sv } return
for child in view.subviews {
if let found = findScrollView(in: child, foundCount: foundCount) {
if foundCount == 1 {
print("found sv: \(found)")
// return found
} else {
print("found sv: \(found)")
foundCount += 1
}
}
}
return nil
} }
func tryFindScrollView() {
// Before we switch to a different scrollview, we always want to remove the cancel gesture recognizer. // Before we switch to a different scrollview, we always want to remove the cancel gesture recognizer.
// Otherwise we might end up with duplicates when we switch back to that scrollview. // Otherwise we might end up with duplicates when we switch back to that scrollview.
self.removeCancelGestureRecognizers() self.removeCancelGestureRecognizers()
guard let sv = self.findScrollView(in: self.superview!.superview!.superview!, foundCount: 0) else { self.rctScrollView = self.appContext?
print("⚠️ ExpoScrollForwarder: couldnt find UIScrollView under tag \(tag)") .findView(withTag: scrollViewTag, ofType: RCTScrollView.self)
return self.rctRefreshCtrl = self.rctScrollView?.scrollView.refreshControl as? RCTRefreshControl
}
self.scrollView = sv
self.rctRefreshCtrl = sv.refreshControl as? RCTRefreshControl
self.addCancelGestureRecognizers() self.addCancelGestureRecognizers()
} }
func addCancelGestureRecognizers() { func addCancelGestureRecognizers() {
self.cancelGestureRecognizers?.forEach { r in self.cancelGestureRecognizers?.forEach { r in
self.scrollView?.addGestureRecognizer(r) self.rctScrollView?.scrollView?.addGestureRecognizer(r)
} }
} }
func removeCancelGestureRecognizers() { func removeCancelGestureRecognizers() {
self.cancelGestureRecognizers?.forEach { r in self.cancelGestureRecognizers?.forEach { r in
self.scrollView?.removeGestureRecognizer(r) self.rctScrollView?.scrollView?.removeGestureRecognizer(r)
} }
} }
@@ -219,7 +202,7 @@ class ExpoScrollForwarderView: ExpoView, UIGestureRecognizerDelegate {
} }
func scrollToOffset(_ offset: Int, animated: Bool = true) { func scrollToOffset(_ offset: Int, animated: Bool = true) {
self.scrollView?.scrollRectToVisible(CGRect(x: 0, y: offset, width: 0, height: 0), animated: animated) self.rctScrollView?.scroll(toOffset: CGPoint(x: 0, y: offset), animated: animated)
} }
func stopTimer() { func stopTimer() {