From df9909baa353c8576aadca77e12e3251c0bfc604 Mon Sep 17 00:00:00 2001
From: surfdude29 <149612116+surfdude29@users.noreply.github.com>
Date: Tue, 1 Apr 2025 23:59:53 +0100
Subject: [PATCH] Translate number joined starter pack string and add plural
 formatting (#7984)

* translate number joined starter pack string

* also add plural formatting in StarterPackScreen.tsx

* import Plural

* tweak

* tweak
---
 src/components/StarterPack/StarterPackCard.tsx |  6 ++++--
 src/screens/StarterPack/StarterPackScreen.tsx  | 11 +++++++----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/components/StarterPack/StarterPackCard.tsx b/src/components/StarterPack/StarterPackCard.tsx
index caa052726a..b5760fd6df 100644
--- a/src/components/StarterPack/StarterPackCard.tsx
+++ b/src/components/StarterPack/StarterPackCard.tsx
@@ -2,7 +2,7 @@ import React from 'react'
 import {View} from 'react-native'
 import {Image} from 'expo-image'
 import {AppBskyGraphStarterpack, AtUri} from '@atproto/api'
-import {msg} from '@lingui/macro'
+import {msg, Plural, Trans} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 import {useQueryClient} from '@tanstack/react-query'
 
@@ -95,7 +95,9 @@ export function Card({
       ) : null}
       {!!joinedAllTimeCount && joinedAllTimeCount >= 50 && (
         <Text style={[a.font_bold, t.atoms.text_contrast_medium]}>
-          {joinedAllTimeCount} users have joined!
+          <Trans comment="Number of users (always at least 50) who have joined Bluesky using a specific starter pack">
+            <Plural value={joinedAllTimeCount} other="# users have" /> joined!
+          </Trans>
         </Text>
       )}
     </View>
diff --git a/src/screens/StarterPack/StarterPackScreen.tsx b/src/screens/StarterPack/StarterPackScreen.tsx
index 7ec0043b1d..9fae5d4d5f 100644
--- a/src/screens/StarterPack/StarterPackScreen.tsx
+++ b/src/screens/StarterPack/StarterPackScreen.tsx
@@ -9,7 +9,7 @@ import {
   RichText as RichTextAPI,
 } from '@atproto/api'
 import {FontAwesomeIcon} from '@fortawesome/react-native-fontawesome'
-import {msg, Trans} from '@lingui/macro'
+import {msg, Plural, Trans} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 import {useNavigation} from '@react-navigation/native'
 import {NativeStackScreenProps} from '@react-navigation/native-stack'
@@ -482,9 +482,12 @@ function Header({
               />
               <Text
                 style={[a.font_bold, a.text_sm, t.atoms.text_contrast_medium]}>
-                <Trans>
-                  {starterPack.joinedAllTimeCount || 0} people have used this
-                  starter pack!
+                <Trans comment="Number of users (always at least 25) who have joined Bluesky using a specific starter pack">
+                  <Plural
+                    value={starterPack.joinedAllTimeCount || 0}
+                    other="# people have"
+                  />{' '}
+                  used this starter pack!
                 </Trans>
               </Text>
             </View>