Address lint warnings (#10188)

src/state/birthdate.ts

@@ -14,7 +14,7 @@ const BIRTHDATE_DELAY_HOURS = IS_DEV ? 0.001 : 48
  * Stores the timestamp of the birthday update locally. This is used to
  * debounce birthday updates globally.
  *
- * Use {@link useIsBirthDateUpdateAllowed} to check if an update is allowed.
+ * Use {@link useIsBirthdateUpdateAllowed} to check if an update is allowed.
  */
 export function snoozeBirthdateUpdateAllowedForDid(did: string) {
   account.set([did, 'birthdateLastUpdatedAt'], new Date().toISOString())

src/state/queries/messages/actor-declaration.ts

@@ -52,7 +52,7 @@ export function useUpdateActorDeclaration({
     onError: error => {
       logger.error(error)
       if (currentAccount) {
-        queryClient.invalidateQueries({
+        void queryClient.invalidateQueries({
           queryKey: PROFILE_RKEY(currentAccount.did),
         })
       }

src/state/session/agent.ts

@@ -181,65 +181,64 @@ export async function createAgentAndCreateAccount(
   // Not awaited so that we can still get into onboarding.
   // This is OK because we won't let you toggle adult stuff until you set the date.
   if (IS_PROD_SERVICE(service)) {
-    Promise.allSettled(
-      [
-        networkRetry(3, () => {
-          return agent.setPersonalDetails({
-            birthDate: birthdate,
-          })
-        }).catch(e => {
-          logger.info(`createAgentAndCreateAccount: failed to set birthDate`)
-          throw e
-        }),
-        networkRetry(3, () => {
-          return agent.upsertProfile(prev => {
-            const next: Un$Typed<AppBskyActorProfile.Record> = prev || {}
-            next.displayName = handle
-            next.createdAt = createdAt
-            return next
-          })
-        }).catch(e => {
-          logger.info(
-            `createAgentAndCreateAccount: failed to set initial profile`,
-          )
-          throw e
-        }),
-        networkRetry(1, () => {
-          return agent.overwriteSavedFeeds([
-            {
-              ...DISCOVER_SAVED_FEED,
-              id: TID.nextStr(),
-            },
-            {
-              ...TIMELINE_SAVED_FEED,
-              id: TID.nextStr(),
-            },
-          ])
-        }).catch(e => {
-          logger.info(
-            `createAgentAndCreateAccount: failed to set initial feeds`,
-          )
-          throw e
-        }),
-        getAge(birthDate) < 18 &&
-          networkRetry(3, () => {
-            return agent.com.atproto.repo.putRecord({
-              repo: account.did,
-              collection: 'chat.bsky.actor.declaration',
-              rkey: 'self',
-              record: {
-                $type: 'chat.bsky.actor.declaration',
-                allowIncoming: 'none',
-              },
-            })
-          }).catch(e => {
-            logger.info(
-              `createAgentAndCreateAccount: failed to set chat declaration`,
-            )
-            throw e
-          }),
-      ].filter(Boolean),
-    ).then(promises => {
+    void Promise.allSettled([
+      networkRetry(3, () => {
+        return agent.setPersonalDetails({
+          birthDate: birthdate,
+        })
+      }).catch(e => {
+        logger.info(`createAgentAndCreateAccount: failed to set birthDate`)
+        throw e
+      }),
+      networkRetry(3, () => {
+        return agent.upsertProfile(prev => {
+          const next: Un$Typed<AppBskyActorProfile.Record> = prev || {}
+          next.displayName = handle
+          next.createdAt = createdAt
+          return next
+        })
+      }).catch(e => {
+        logger.info(
+          `createAgentAndCreateAccount: failed to set initial profile`,
+        )
+        throw e
+      }),
+      networkRetry(1, () => {
+        return agent.overwriteSavedFeeds([
+          {
+            ...DISCOVER_SAVED_FEED,
+            id: TID.nextStr(),
+          },
+          {
+            ...TIMELINE_SAVED_FEED,
+            id: TID.nextStr(),
+          },
+        ])
+      }).catch(e => {
+        logger.info(`createAgentAndCreateAccount: failed to set initial feeds`)
+        throw e
+      }),
+      ...(getAge(birthDate) < 18
+        ? [
+            networkRetry(3, () => {
+              return agent.com.atproto.repo.putRecord({
+                repo: account.did,
+                collection: 'chat.bsky.actor.declaration',
+                rkey: 'self',
+                record: {
+                  $type: 'chat.bsky.actor.declaration',
+                  allowIncoming: 'none',
+                },
+              })
+            }).catch(e => {
+              logger.info(
+                `createAgentAndCreateAccount: failed to set chat declaration`,
+              )
+              throw e
+            }),
+          ]
+        : []),
+    ]).then(promises => {
       const rejected = promises.filter(p => p.status === 'rejected')
       if (rejected.length > 0) {
         logger.error(
@@ -248,30 +247,28 @@ export async function createAgentAndCreateAccount(
       }
     })
   } else {
-    Promise.allSettled(
-      [
-        networkRetry(3, () => {
-          return agent.setPersonalDetails({
-            birthDate: birthDate.toISOString(),
-          })
-        }).catch(e => {
-          logger.info(`createAgentAndCreateAccount: failed to set birthDate`)
-          throw e
-        }),
-        networkRetry(3, () => {
-          return agent.upsertProfile(prev => {
-            const next: Un$Typed<AppBskyActorProfile.Record> = prev || {}
-            next.createdAt = prev?.createdAt || new Date().toISOString()
-            return next
-          })
-        }).catch(e => {
-          logger.info(
-            `createAgentAndCreateAccount: failed to set initial profile`,
-          )
-          throw e
-        }),
-      ].filter(Boolean),
-    ).then(promises => {
+    void Promise.allSettled([
+      networkRetry(3, () => {
+        return agent.setPersonalDetails({
+          birthDate: birthDate.toISOString(),
+        })
+      }).catch(e => {
+        logger.info(`createAgentAndCreateAccount: failed to set birthDate`)
+        throw e
+      }),
+      networkRetry(3, () => {
+        return agent.upsertProfile(prev => {
+          const next: Un$Typed<AppBskyActorProfile.Record> = prev || {}
+          next.createdAt = prev?.createdAt || new Date().toISOString()
+          return next
+        })
+      }).catch(e => {
+        logger.info(
+          `createAgentAndCreateAccount: failed to set initial profile`,
+        )
+        throw e
+      }),
+    ]).then(promises => {
       const rejected = promises.filter(p => p.status === 'rejected')
       if (rejected.length > 0) {
         logger.error(

src/state/session/index.tsx

@@ -8,7 +8,7 @@ import {
   useState,
   useSyncExternalStore,
 } from 'react'
-import {type AtpSessionEvent, type BskyAgent} from '@atproto/api'
+import {type AtpAgent, type AtpSessionEvent} from '@atproto/api'
 
 import * as persisted from '#/state/persisted'
 import {useCloseAllActiveElements} from '#/state/util'
@@ -47,7 +47,7 @@ const StateContext = createContext<SessionStateContext>({
 })
 StateContext.displayName = 'SessionStateContext'
 
-const AgentContext = createContext<BskyAgent | null>(null)
+const AgentContext = createContext<AtpAgent | null>(null)
 AgentContext.displayName = 'SessionAgentContext'
 
 const ApiContext = createContext<SessionApiContext>({
@@ -96,7 +96,7 @@ class SessionStore {
         ),
       }
       addSessionDebugLog({type: 'persisted:broadcast', data: persistedData})
-      persisted.write('session', persistedData)
+      void persisted.write('session', persistedData)
     }
     this.listeners.forEach(listener => listener())
   }
@@ -105,12 +105,13 @@ class SessionStore {
 export function Provider({children}: React.PropsWithChildren<{}>) {
   const ax = useAnalyticsBase()
   const cancelPendingTask = useOneTaskAtATime()
+  // eslint-disable-next-line react/hook-use-state
   const [store] = useState(() => new SessionStore())
   const state = useSyncExternalStore(store.subscribe, store.getState)
   const onboardingDispatch = useOnboardingDispatch()
 
   const onAgentSessionChange = useCallback(
-    (agent: BskyAgent, accountDid: string, sessionEvent: AtpSessionEvent) => {
+    (agent: AtpAgent, accountDid: string, sessionEvent: AtpSessionEvent) => {
       const refreshedAccount = agentToSessionAccount(agent) // Mutable, so snapshot it right away.
       if (sessionEvent === 'expired' || sessionEvent === 'create-failed') {
         emitSessionDropped()
@@ -327,10 +328,11 @@ export function Provider({children}: React.PropsWithChildren<{}>) {
            * follower tabs. Follower tabs will therefore receive the fresh
            * session. See APP-1960, or ask Eric.
            */
-          resumeSession(syncedAccount)
+          void resumeSession(syncedAccount)
         } else {
-          const agent = state.currentAgentState.agent as BskyAgent
+          const agent = state.currentAgentState.agent as AtpAgent
           const prevSession = agent.session
+          // eslint-disable-next-line react-compiler/react-compiler
           agent.sessionManager.session = sessionAccountToSession(syncedAccount)
           addSessionDebugLog({
             type: 'agent:patch',
@@ -376,6 +378,7 @@ export function Provider({children}: React.PropsWithChildren<{}>) {
   )
 
   // @ts-expect-error window type is not declared, debug only
+  // eslint-disable-next-line react-hooks/immutability
   if (__DEV__ && IS_WEB) window.agent = state.currentAgentState.agent
 
   const agent = state.currentAgentState.agent as BskyAppAgent
@@ -448,7 +451,7 @@ export function useRequireAuth() {
   )
 }
 
-export function useAgent(): BskyAgent {
+export function useAgent(): AtpAgent {
   const agent = useContext(AgentContext)
   if (!agent) {
     throw Error('useAgent() must be below <SessionProvider>.')