From d01d01812ee0f92a5aabaff28f9c4445f7496012 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sun, 19 Jan 2025 23:08:56 +0000 Subject: [PATCH] Fix effect cleanup --- src/screens/VideoFeed/index.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/screens/VideoFeed/index.tsx b/src/screens/VideoFeed/index.tsx index 5537655bcd..9cdbdf6177 100644 --- a/src/screens/VideoFeed/index.tsx +++ b/src/screens/VideoFeed/index.tsx @@ -479,19 +479,19 @@ let VideoItem = ({ const {sendInteraction} = useFeedFeedbackContext() useEffect(() => { - let to: NodeJS.Timeout | null = null - if (active && !to) { - to = setTimeout(() => { + if (active) { + const to = setTimeout(() => { sendInteraction({ item: post.uri, event: 'app.bsky.feed.defs#interactionSeen', feedContext, }) }, 1000) - } else if (!active && to) { - clearTimeout(to) + return () => { + clearTimeout(to) + } } - }, [active, post, feedContext, sendInteraction]) + }, [active, post.uri, feedContext, sendInteraction]) return (