Fine tune

This commit is contained in:
Eric Bailey
2024-05-09 22:17:20 -05:00
parent 1be2d395f8
commit c88647c8d1
3 changed files with 51 additions and 61 deletions
+30 -30
View File
@@ -147,12 +147,12 @@ export function BottomBar({navigation}: BottomTabBarProps) {
icon={ icon={
isAtHome ? ( isAtHome ? (
<HomeFilled <HomeFilled
width={iconWidth} width={iconWidth + 2}
style={[styles.ctrlIcon, pal.text, styles.homeIcon]} style={[styles.ctrlIcon, pal.text, styles.homeIcon]}
/> />
) : ( ) : (
<Home <Home
width={iconWidth} width={iconWidth + 2}
style={[styles.ctrlIcon, pal.text, styles.homeIcon]} style={[styles.ctrlIcon, pal.text, styles.homeIcon]}
/> />
) )
@@ -167,12 +167,12 @@ export function BottomBar({navigation}: BottomTabBarProps) {
icon={ icon={
isAtSearch ? ( isAtSearch ? (
<MagnifyingGlassFilled <MagnifyingGlassFilled
width={iconWidth} width={iconWidth + 2}
style={[styles.ctrlIcon, pal.text, styles.searchIcon]} style={[styles.ctrlIcon, pal.text, styles.searchIcon]}
/> />
) : ( ) : (
<MagnifyingGlass <MagnifyingGlass
width={iconWidth} width={iconWidth + 2}
style={[styles.ctrlIcon, pal.text, styles.searchIcon]} style={[styles.ctrlIcon, pal.text, styles.searchIcon]}
/> />
) )
@@ -182,32 +182,6 @@ export function BottomBar({navigation}: BottomTabBarProps) {
accessibilityLabel={_(msg`Search`)} accessibilityLabel={_(msg`Search`)}
accessibilityHint="" accessibilityHint=""
/> />
<Btn
testID="bottomBarNotificationsBtn"
icon={
isAtNotifications ? (
<BellFilled
width={iconWidth}
style={[styles.ctrlIcon, pal.text, styles.bellIcon]}
/>
) : (
<Bell
width={iconWidth}
style={[styles.ctrlIcon, pal.text, styles.bellIcon]}
/>
)
}
onPress={onPressNotifications}
notificationCount={numUnreadNotifications}
accessible={true}
accessibilityRole="tab"
accessibilityLabel={_(msg`Notifications`)}
accessibilityHint={
numUnreadNotifications === ''
? ''
: `${numUnreadNotifications} unread`
}
/>
{gate('dms') && ( {gate('dms') && (
<Btn <Btn
testID="bottomBarMessagesBtn" testID="bottomBarMessagesBtn"
@@ -236,6 +210,32 @@ export function BottomBar({navigation}: BottomTabBarProps) {
} }
/> />
)} )}
<Btn
testID="bottomBarNotificationsBtn"
icon={
isAtNotifications ? (
<BellFilled
width={iconWidth}
style={[styles.ctrlIcon, pal.text, styles.bellIcon]}
/>
) : (
<Bell
width={iconWidth}
style={[styles.ctrlIcon, pal.text, styles.bellIcon]}
/>
)
}
onPress={onPressNotifications}
notificationCount={numUnreadNotifications}
accessible={true}
accessibilityRole="tab"
accessibilityLabel={_(msg`Notifications`)}
accessibilityHint={
numUnreadNotifications === ''
? ''
: `${numUnreadNotifications} unread`
}
/>
<Btn <Btn
testID="bottomBarProfileBtn" testID="bottomBarProfileBtn"
icon={ icon={
+7 -17
View File
@@ -9,6 +9,7 @@ export const styles = StyleSheet.create({
left: 0, left: 0,
right: 0, right: 0,
flexDirection: 'row', flexDirection: 'row',
alignItems: 'center',
borderTopWidth: 1, borderTopWidth: 1,
paddingLeft: 5, paddingLeft: 5,
paddingRight: 10, paddingRight: 10,
@@ -49,29 +50,18 @@ export const styles = StyleSheet.create({
marginRight: 'auto', marginRight: 'auto',
}, },
ctrlIconSizingWrapper: { ctrlIconSizingWrapper: {
height: 27, height: 28,
},
homeIcon: {
top: 0,
},
feedsIcon: {
top: -2,
},
searchIcon: {
top: -2,
},
bellIcon: {
top: -2.5,
}, },
homeIcon: {},
feedsIcon: {},
searchIcon: {},
bellIcon: {},
profileIcon: { profileIcon: {
borderRadius: 100, borderRadius: 100,
borderWidth: 1, borderWidth: 1,
borderColor: 'transparent', borderColor: 'transparent',
top: -4,
},
messagesIcon: {
top: 2,
}, },
messagesIcon: {},
onProfile: { onProfile: {
borderWidth: 1, borderWidth: 1,
borderRadius: 100, borderRadius: 100,
+14 -14
View File
@@ -81,7 +81,7 @@ export function BottomBarWeb() {
const Icon = isActive ? HomeFilled : Home const Icon = isActive ? HomeFilled : Home
return ( return (
<Icon <Icon
width={iconWidth} width={iconWidth + 2}
style={[styles.ctrlIcon, pal.text, styles.homeIcon]} style={[styles.ctrlIcon, pal.text, styles.homeIcon]}
/> />
) )
@@ -92,7 +92,7 @@ export function BottomBarWeb() {
const Icon = isActive ? MagnifyingGlassFilled : MagnifyingGlass const Icon = isActive ? MagnifyingGlassFilled : MagnifyingGlass
return ( return (
<Icon <Icon
width={iconWidth} width={iconWidth + 2}
style={[styles.ctrlIcon, pal.text, styles.searchIcon]} style={[styles.ctrlIcon, pal.text, styles.searchIcon]}
/> />
) )
@@ -101,17 +101,6 @@ export function BottomBarWeb() {
{hasSession && ( {hasSession && (
<> <>
<NavItem routeName="Notifications" href="/notifications">
{({isActive}) => {
const Icon = isActive ? BellFilled : Bell
return (
<Icon
width={iconWidth}
style={[styles.ctrlIcon, pal.text, styles.bellIcon]}
/>
)
}}
</NavItem>
{gate('dms') && ( {gate('dms') && (
<NavItem routeName="Messages" href="/messages"> <NavItem routeName="Messages" href="/messages">
{({isActive}) => { {({isActive}) => {
@@ -125,6 +114,17 @@ export function BottomBarWeb() {
}} }}
</NavItem> </NavItem>
)} )}
<NavItem routeName="Notifications" href="/notifications">
{({isActive}) => {
const Icon = isActive ? BellFilled : Bell
return (
<Icon
width={iconWidth}
style={[styles.ctrlIcon, pal.text, styles.bellIcon]}
/>
)
}}
</NavItem>
<NavItem <NavItem
routeName="Profile" routeName="Profile"
href={ href={
@@ -139,7 +139,7 @@ export function BottomBarWeb() {
const Icon = isActive ? UserCircleFilled : UserCircle const Icon = isActive ? UserCircleFilled : UserCircle
return ( return (
<Icon <Icon
width={iconWidth} width={iconWidth + 2}
style={[styles.ctrlIcon, pal.text, styles.profileIcon]} style={[styles.ctrlIcon, pal.text, styles.profileIcon]}
/> />
) )