Reduce Sentry noise from logger transport and expected-failure call sites (#10893)

src/logger/__tests__/logger.test.ts

@@ -182,11 +182,7 @@ describe('general functionality', () => {
       timestamp: sentryTimestamp,
     })
     jest.runAllTimers()
-    expect(Sentry.captureMessage).toHaveBeenCalledWith(message, {
-      level: 'log',
-      tags: {category: 'logger'},
-      extra: {__context__: 'logger'},
-    })
+    expect(Sentry.captureMessage).not.toHaveBeenCalled()
 
     sentryTransport(
       LogLevel.Warn,
@@ -204,8 +200,18 @@ describe('general functionality', () => {
       timestamp: sentryTimestamp,
     })
     jest.runAllTimers()
+    expect(Sentry.captureMessage).not.toHaveBeenCalled()
+
+    sentryTransport(
+      LogLevel.Error,
+      Logger.Context.Default,
+      message,
+      {},
+      timestamp,
+    )
+    jest.runAllTimers()
     expect(Sentry.captureMessage).toHaveBeenCalledWith(message, {
-      level: 'warning',
+      level: 'error',
       tags: {category: 'logger'},
       extra: {__context__: 'logger'},
     })
@@ -259,6 +265,42 @@ describe('general functionality', () => {
     })
   })
 
+  test('sentryTransport filters network errors', () => {
+    jest.clearAllMocks()
+    const timestamp = Date.now()
+
+    // network error in the message itself
+    sentryTransport(
+      LogLevel.Error,
+      Logger.Context.Default,
+      'Network request failed',
+      {},
+      timestamp,
+    )
+
+    // network error in metadata, message is something else
+    sentryTransport(
+      LogLevel.Error,
+      Logger.Context.Default,
+      'poll failed',
+      {safeMessage: new Error('Network request failed')},
+      timestamp,
+    )
+
+    jest.runAllTimers()
+    expect(Sentry.captureMessage).not.toHaveBeenCalled()
+
+    // network Error object
+    sentryTransport(
+      LogLevel.Error,
+      Logger.Context.Default,
+      new Error('Network request failed'),
+      {},
+      timestamp,
+    )
+    expect(Sentry.captureException).not.toHaveBeenCalled()
+  })
+
   test('add/remove transport', () => {
     const timestamp = Date.now()
     const logger = new Logger({})