From c1f42ef877ef973bb98650add202c546fe45c4aa Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Mon, 25 May 2026 14:22:39 +0300 Subject: [PATCH] Fix image cropping not saving on iOS (#10404) Co-authored-by: Claude Opus 4.7 (1M context) --- package.json | 2 +- pnpm-lock.yaml | 2 +- src/state/gallery.ts | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index fc7a097858..1787e76315 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "@braintree/sanitize-url": "^6.0.2", "@bsky.app/alf": "^0.1.9", "@bsky.app/expo-guess-language": "^0.2.8", - "@bsky.app/expo-image-crop-tool": "^0.5.0", + "@bsky.app/expo-image-crop-tool": "^0.5.1", "@bsky.app/expo-scroll-edge-effect": "^0.1.4", "@bsky.app/expo-translate-text": "^0.2.9", "@bsky.app/react-native-mmkv": "2.12.5", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 52975d475f..0c60bd415d 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -260,7 +260,7 @@ importers: specifier: ^0.2.8 version: 0.2.8(expo@54.0.34(@babel/core@7.29.0)(react-native-webview@13.15.0(react-native@0.81.5(patch_hash=2656ac6deb71b92a4df4af4593d13ace6a5740936432e5e7e8ef32bc3cd05194)(@babel/core@7.29.0)(@types/react@19.1.17)(react@19.1.0))(react@19.1.0))(react-native@0.81.5(patch_hash=2656ac6deb71b92a4df4af4593d13ace6a5740936432e5e7e8ef32bc3cd05194)(@babel/core@7.29.0)(@types/react@19.1.17)(react@19.1.0))(react@19.1.0))(react-native@0.81.5(patch_hash=2656ac6deb71b92a4df4af4593d13ace6a5740936432e5e7e8ef32bc3cd05194)(@babel/core@7.29.0)(@types/react@19.1.17)(react@19.1.0))(react@19.1.0) '@bsky.app/expo-image-crop-tool': - specifier: ^0.5.0 + specifier: ^0.5.1 version: 0.5.1(expo@54.0.34(@babel/core@7.29.0)(react-native-webview@13.15.0(react-native@0.81.5(patch_hash=2656ac6deb71b92a4df4af4593d13ace6a5740936432e5e7e8ef32bc3cd05194)(@babel/core@7.29.0)(@types/react@19.1.17)(react@19.1.0))(react@19.1.0))(react-native@0.81.5(patch_hash=2656ac6deb71b92a4df4af4593d13ace6a5740936432e5e7e8ef32bc3cd05194)(@babel/core@7.29.0)(@types/react@19.1.17)(react@19.1.0))(react@19.1.0))(react-native@0.81.5(patch_hash=2656ac6deb71b92a4df4af4593d13ace6a5740936432e5e7e8ef32bc3cd05194)(@babel/core@7.29.0)(@types/react@19.1.17)(react@19.1.0))(react@19.1.0) '@bsky.app/expo-scroll-edge-effect': specifier: ^0.1.4 diff --git a/src/state/gallery.ts b/src/state/gallery.ts index c122ca6df4..c9c7f37750 100644 --- a/src/state/gallery.ts +++ b/src/state/gallery.ts @@ -19,6 +19,7 @@ import {openCropper} from '#/lib/media/picker' import {type PickerImage} from '#/lib/media/picker.shared' import {getDataUriSize} from '#/lib/media/util' import {isCancelledError} from '#/lib/strings/errors' +import {logger} from '#/logger' import {IS_NATIVE, IS_WEB} from '#/env' export type ImageTransformation = { @@ -149,6 +150,7 @@ export async function cropImage(img: ComposerImage): Promise { } } catch (e) { if (!isCancelledError(e)) { + logger.error('Failed to crop image', {safeMessage: e}) return img }