[APP-1783] Clean up some feature gates and logging (#9729)
* Remove gates we don't need * Clean up some logging * Keep disable gates around for now * Add missing gate * Revert file * Revert package changes
This commit is contained in:
@@ -1,8 +1,5 @@
|
||||
import {type AtpSessionData, type AtpSessionEvent} from '@atproto/api'
|
||||
import {sha256} from 'js-sha256'
|
||||
import {Statsig} from 'statsig-react-native-expo'
|
||||
|
||||
import {IS_INTERNAL} from '#/env'
|
||||
import {type Schema} from '../persisted'
|
||||
import {type Action, type State} from './reducer'
|
||||
import {type SessionAccount} from './types'
|
||||
@@ -68,92 +65,9 @@ export function wrapSessionReducerForLogging(reducer: Reducer): Reducer {
|
||||
}
|
||||
}
|
||||
|
||||
let nextMessageIndex = 0
|
||||
const MAX_SLICE_LENGTH = 1000
|
||||
|
||||
// Not gated.
|
||||
export function addSessionErrorLog(did: string, event: AtpSessionEvent) {
|
||||
try {
|
||||
if (!Statsig.initializeCalled() || !Statsig.getStableID()) {
|
||||
return
|
||||
}
|
||||
const stack = (new Error().stack ?? '').slice(0, MAX_SLICE_LENGTH)
|
||||
Statsig.logEvent('session:error', null, {
|
||||
did,
|
||||
event,
|
||||
stack,
|
||||
})
|
||||
} catch (e) {
|
||||
console.error(e)
|
||||
}
|
||||
}
|
||||
|
||||
export function addSessionDebugLog(log: Log) {
|
||||
try {
|
||||
if (!Statsig.initializeCalled() || !Statsig.getStableID()) {
|
||||
// Drop these logs for now.
|
||||
return
|
||||
}
|
||||
// DISABLING THIS GATE DUE TO EME @TODO EME-GATE
|
||||
if (!IS_INTERNAL) {
|
||||
return
|
||||
}
|
||||
// if (!Statsig.checkGate('debug_session')) {
|
||||
// return
|
||||
// }
|
||||
const messageIndex = nextMessageIndex++
|
||||
const {type, ...content} = log
|
||||
let payload = JSON.stringify(content, replacer)
|
||||
|
||||
let nextSliceIndex = 0
|
||||
while (payload.length > 0) {
|
||||
const sliceIndex = nextSliceIndex++
|
||||
const slice = payload.slice(0, MAX_SLICE_LENGTH)
|
||||
payload = payload.slice(MAX_SLICE_LENGTH)
|
||||
Statsig.logEvent('session:debug', null, {
|
||||
realmId,
|
||||
messageIndex: String(messageIndex),
|
||||
messageType: type,
|
||||
sliceIndex: String(sliceIndex),
|
||||
slice,
|
||||
})
|
||||
}
|
||||
} catch (e) {
|
||||
console.error(e)
|
||||
}
|
||||
}
|
||||
|
||||
let agentIds = new WeakMap<object, string>()
|
||||
let realmId = Math.random().toString(36).slice(2)
|
||||
let nextAgentId = 1
|
||||
|
||||
function getAgentId(agent: object) {
|
||||
let id = agentIds.get(agent)
|
||||
if (id === undefined) {
|
||||
id = realmId + '::' + nextAgentId++
|
||||
agentIds.set(agent, id)
|
||||
}
|
||||
return id
|
||||
}
|
||||
|
||||
function replacer(key: string, value: unknown) {
|
||||
if (typeof value === 'object' && value != null && 'api' in value) {
|
||||
return getAgentId(value)
|
||||
}
|
||||
if (
|
||||
key === 'service' ||
|
||||
key === 'email' ||
|
||||
key === 'emailConfirmed' ||
|
||||
key === 'emailAuthFactor' ||
|
||||
key === 'pdsUrl'
|
||||
) {
|
||||
return undefined
|
||||
}
|
||||
if (
|
||||
typeof value === 'string' &&
|
||||
(key === 'refreshJwt' || key === 'accessJwt')
|
||||
) {
|
||||
return sha256(value)
|
||||
}
|
||||
return value
|
||||
}
|
||||
/**
|
||||
* Stubs, previously used to log session errors to Statsig. We may revive this
|
||||
* using Sentry or Bitdrift in the future.
|
||||
*/
|
||||
export function addSessionErrorLog(_did: string, _event: AtpSessionEvent) {}
|
||||
export function addSessionDebugLog(_log: Log) {}
|
||||
|
||||
Reference in New Issue
Block a user