[APP-1783] Clean up some feature gates and logging (#9729)

* Remove gates we don't need

* Clean up some logging

* Keep disable gates around for now

* Add missing gate

* Revert file

* Revert package changes

src/components/FeedInterstitials.tsx

@@ -7,7 +7,7 @@ import {useLingui} from '@lingui/react'
 import {useNavigation} from '@react-navigation/native'
 
 import {type NavigationProp} from '#/lib/routes/types'
-import {logEvent, useGate} from '#/lib/statsig/statsig'
+import {logEvent} from '#/lib/statsig/statsig'
 import {logger} from '#/logger'
 import {type MetricEvents} from '#/logger/metrics'
 import {useModerationOpts} from '#/state/preferences/moderation-opts'
@@ -435,7 +435,6 @@ export function ProfileGrid({
 }) {
   const t = useTheme()
   const {_} = useLingui()
-  const gate = useGate()
   const moderationOpts = useModerationOpts()
   const {gtMobile} = useBreakpoints()
   const followDialogControl = useDialogControl()
@@ -443,7 +442,6 @@ export function ProfileGrid({
   const isLoading = isSuggestionsLoading || !moderationOpts
   const isProfileHeaderContext = viewContext === 'profileHeader'
   const isFeedContext = viewContext === 'feed'
-  const showDismissButton = onDismiss && gate('suggested_users_dismiss')
 
   const maxLength = gtMobile ? 3 : isProfileHeaderContext ? 12 : 6
   const minLength = gtMobile ? 3 : 4
@@ -584,12 +582,12 @@ export function ProfileGrid({
                     (hovered || pressed) && t.atoms.border_contrast_high,
                   ]}>
                   <ProfileCard.Outer>
-                    {showDismissButton && (
+                    {onDismiss && (
                       <Button
                         label={_(msg`Dismiss this suggestion`)}
                         onPress={e => {
                           e.preventDefault()
-                          onDismiss!(profile.did)
+                          onDismiss(profile.did)
                           logEvent('suggestedUser:dismiss', {
                             logContext: isFeedContext
                               ? 'InterstitialDiscover'

src/components/PostControls/ShareMenu/index.tsx

@@ -12,14 +12,12 @@ import {useLingui} from '@lingui/react'
 
 import {makeProfileLink} from '#/lib/routes/links'
 import {shareUrl} from '#/lib/sharing'
-import {useGate} from '#/lib/statsig/statsig'
 import {toShareUrl} from '#/lib/strings/url-helpers'
 import {logger} from '#/logger'
 import {type Shadow} from '#/state/cache/post-shadow'
 import {useFeedFeedbackContext} from '#/state/feed-feedback'
 import {EventStopper} from '#/view/com/util/EventStopper'
 import {native} from '#/alf'
-import {ArrowOutOfBoxModified_Stroke2_Corner2_Rounded as ArrowOutOfBoxIcon} from '#/components/icons/ArrowOutOfBox'
 import {ArrowShareRight_Stroke2_Corner2_Rounded as ArrowShareRightIcon} from '#/components/icons/ArrowShareRight'
 import {useMenuControl} from '#/components/Menu'
 import * as Menu from '#/components/Menu'
@@ -50,13 +48,8 @@ let ShareMenuButton = ({
   logContext: 'FeedItem' | 'PostThreadItem' | 'Post' | 'ImmersiveVideo'
 }): React.ReactNode => {
   const {_} = useLingui()
-  const gate = useGate()
   const {feedDescriptor} = useFeedFeedbackContext()
 
-  const ShareIcon = gate('alt_share_icon')
-    ? ArrowShareRightIcon
-    : ArrowOutOfBoxIcon
-
   const menuControl = useMenuControl()
   const [hasBeenOpen, setHasBeenOpen] = useState(false)
   const lazyMenuControl = useMemo(
@@ -114,7 +107,7 @@ let ShareMenuButton = ({
                 {...props}
                 onLongPress={native(onNativeLongPress)}
                 hitSlop={hitSlop}>
-                <PostControlButtonIcon icon={ShareIcon} />
+                <PostControlButtonIcon icon={ArrowShareRightIcon} />
               </PostControlButton>
             )
           }}

src/components/contacts/FindContactsBannerNUX.tsx

@@ -6,7 +6,6 @@ import {msg, Trans} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 
 import {HITSLOP_10} from '#/lib/constants'
-import {useGate} from '#/lib/statsig/statsig'
 import {logger} from '#/logger'
 import {Nux, useNux, useSaveNux} from '#/state/queries/nuxs'
 import {atoms as a, useTheme} from '#/alf'
@@ -89,16 +88,14 @@ function useInternalState() {
   const {mutate: save, variables} = useSaveNux()
   const hidden = !!variables
   const isFeatureEnabled = useIsFindContactsFeatureEnabledBasedOnGeolocation()
-  const gate = useGate()
 
   const visible = useMemo(() => {
     if (IS_WEB) return false
     if (hidden) return false
     if (nux && nux.completed) return false
     if (!isFeatureEnabled) return false
-    if (gate('disable_settings_find_contacts')) return false
     return true
-  }, [hidden, nux, isFeatureEnabled, gate])
+  }, [hidden, nux, isFeatureEnabled])
 
   const close = () => {
     save({

src/components/dialogs/nuxs/LiveNowBetaDialog.tsx

@@ -15,8 +15,7 @@ import {
 } from '#/components/dialogs/nuxs/utils'
 import {Beaker_Stroke2_Corner2_Rounded as BeakerIcon} from '#/components/icons/Beaker'
 import {Text} from '#/components/Typography'
-import {IS_WEB} from '#/env'
-import {IS_E2E} from '#/env'
+import {IS_E2E, IS_WEB} from '#/env'
 
 export const enabled = createIsEnabledCheck(props => {
   return (