Upgrade ESLint to v9 with flat config (#9680)

* Upgrade ESLint to v9 with flat config

- Upgrade eslint from v8 to v9.18.0
- Migrate from .eslintrc.js to eslint.config.mjs (flat config)
- Upgrade typescript-eslint to v8.20.0 (unified package)
- Replace eslint-plugin-import with eslint-plugin-import-x for flat config support
- Add globals package for environment globals
- Update eslint-plugin-bsky-internal with proper meta objects for ESLint v9
- Fix deprecated context.getScope() API usage
- Update bskyembed to use flat config
- Remove deprecated --ext flag from lint scripts
- Configure rules to maintain previous behavior while using new ESLint version

* Fix varsIgnorePattern to require character after underscore

Restore the original pattern `^_.+` instead of `^_` so that lingui's
`const { _ } = useLingui()` will still be flagged when unused.

* Update ESLint rule tests for flat config format

- Update RuleTester to use flat config languageOptions instead of
  eslintrc parser format
- Remove duplicate test case that ESLint v9 now detects
- Add Jest globals for test files

* update eslint package versions

* lint android a11y

* enable typechecked rules, switch them to warn

* fix yarn lock ci

* Fix CI failure

* Remove unused globals?

* Organize a bit, add quiet to main lint command

* Allow ternary

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Eric Bailey <git@esb.lol>

src/state/messages/convo/agent.ts

@@ -95,7 +95,7 @@ export class Convo {
     this.convoId = params.convoId
     this.agent = params.agent
     this.events = params.events
-    this.senderUserDid = params.agent.session?.did!
+    this.senderUserDid = params.agent.assertDid
 
     if (params.placeholderData) {
       this.setupPlaceholderData(params.placeholderData)

src/state/persisted/index.web.ts

@@ -22,6 +22,8 @@ const UPDATE_EVENT = 'BSKY_UPDATE'
 let _state: Schema = defaults
 const _emitter = new EventEmitter()
 
+// async, to match native implementation
+// eslint-disable-next-line @typescript-eslint/require-await
 export async function init() {
   broadcast.onmessage = onBroadcastMessage
   window.onstorage = onStorage
@@ -37,6 +39,7 @@ export function get<K extends keyof Schema>(key: K): Schema[K] {
 }
 get satisfies PersistedApi['get']
 
+// eslint-disable-next-line @typescript-eslint/require-await
 export async function write<K extends keyof Schema>(
   key: K,
   value: Schema[K],
@@ -82,6 +85,7 @@ export function onUpdate<K extends keyof Schema>(
 }
 onUpdate satisfies PersistedApi['onUpdate']
 
+// eslint-disable-next-line @typescript-eslint/require-await
 export async function clearStorage() {
   try {
     localStorage.removeItem(BSKY_STORAGE)
@@ -102,6 +106,7 @@ function onStorage() {
   }
 }
 
+// eslint-disable-next-line @typescript-eslint/require-await
 async function onBroadcastMessage({data}: MessageEvent) {
   if (
     typeof data === 'object' &&

src/state/preferences/index.tsx

@@ -23,7 +23,7 @@ export {
   useExternalEmbedsPrefs,
   useSetExternalEmbedPref,
 } from './external-embeds-prefs'
-export * from './hidden-posts'
+export {useHiddenPosts, useHiddenPostsApi} from './hidden-posts'
 export {useLabelDefinitions} from './label-defs'
 export {useLanguagePrefs, useLanguagePrefsApi} from './languages'
 export {useSetSubtitlesEnabled, useSubtitlesEnabled} from './subtitles'

src/state/queries/preferences/types.ts

@@ -15,6 +15,12 @@ export type UsePreferencesQueryResponse = Omit<
 }
 
 export type ThreadViewPreferences = {
-  sort: 'hotness' | 'oldest' | 'newest' | 'most-likes' | 'random' | string
+  sort:
+    | 'hotness'
+    | 'oldest'
+    | 'newest'
+    | 'most-likes'
+    | 'random'
+    | (string & {})
   lab_treeViewEnabled?: boolean
 }

src/state/queries/usePostThread/traversal.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-labels */
 import {AppBskyUnspeccedDefs, type ModerationOpts} from '@atproto/api'
 
 import {

src/state/shell/logged-out.tsx

@@ -26,7 +26,7 @@ type Controls = {
     /**
      * The did of the account to populate the login form with.
      */
-    requestedAccount?: string | 'none' | 'new' | 'starterpack'
+    requestedAccount?: (string & {}) | 'none' | 'new' | 'starterpack'
   }) => void
   /**
    * Clears the requested account so that next time the logged out view is