Fix crash when deleting account from NoAccessScreen (#10283)

src/components/Link.tsx

@@ -141,18 +141,18 @@ export function useLink({
         })
       } else {
         if (isExternal) {
-          openLink(href, overridePresentation, shouldProxy)
+          void openLink(href, overridePresentation, shouldProxy)
         } else {
           const shouldOpenInNewTab = shouldClickOpenNewTab(e)
 
           if (isBskyDownloadUrl(href)) {
-            shareUrl(BSKY_DOWNLOAD_URL)
+            void shareUrl(BSKY_DOWNLOAD_URL)
           } else if (
             shouldOpenInNewTab ||
             href.startsWith('http') ||
             href.startsWith('mailto')
           ) {
-            openLink(href)
+            void openLink(href)
           } else {
             closeModal() // close any active modals
 
@@ -232,7 +232,7 @@ export function useLink({
         share: true,
       })
     } else {
-      shareUrl(href)
+      void shareUrl(href)
     }
   }, [
     disableMismatchWarning,
@@ -451,7 +451,7 @@ export function SimpleInlineLinkText({
   const onPress = (e: GestureResponderEvent) => {
     const exitEarlyIfFalse = outerOnPress?.(e)
     if (exitEarlyIfFalse === false) return
-    Linking.openURL(href)
+    void Linking.openURL(href)
   }
 
   return (

src/screens/Settings/components/DeleteAccountDialog.tsx

@@ -9,7 +9,7 @@ import {useCleanError} from '#/lib/hooks/useCleanError'
 import {sanitizeHandle} from '#/lib/strings/handles'
 import {logger} from '#/logger'
 import {useAgent, useSession, useSessionApi} from '#/state/session'
-import {atoms as a, useTheme, web} from '#/alf'
+import {atoms as a, useTheme} from '#/alf'
 import {Admonition} from '#/components/Admonition'
 import {type DialogOuterProps} from '#/components/Dialog'
 import {
@@ -19,7 +19,7 @@ import {
 import * as TextField from '#/components/forms/TextField'
 import {Envelope_Stroke2_Corner0_Rounded as Envelope} from '#/components/icons/Envelope'
 import {Lock_Stroke2_Corner0_Rounded as Lock} from '#/components/icons/Lock'
-import {createStaticClick, InlineLinkText} from '#/components/Link'
+import {createStaticClick, SimpleInlineLinkText} from '#/components/Link'
 import {Loader} from '#/components/Loader'
 import * as Prompt from '#/components/Prompt'
 import * as toast from '#/components/Toast'
@@ -113,12 +113,9 @@ function DeleteAccountDialogInner({
       }
       const token = confirmCode.replace(WHITESPACE_RE, '')
       // Inform chat service of intent to delete account.
-      const {success} = await agent.api.chat.bsky.actor.deleteAccount(
+      const {success} = await agent.chat.bsky.actor.deleteAccount(undefined, {
-        undefined,
+        headers: DM_SERVICE_HEADERS,
-        {
+      })
-          headers: DM_SERVICE_HEADERS,
-        },
-      )
       if (!success) {
         throw new Error('Failed to inform chat service of account deletion')
       }
@@ -213,11 +210,11 @@ function DeleteAccountDialogInner({
           <Admonition style={[a.mt_lg]} type="tip">
             <Trans>
               You can also{' '}
-              <Span
+              <SimpleInlineLinkText
-                style={[{color: t.palette.primary_500}, web(a.underline)]}
+                label={_(msg`Temporarily deactivate your account`)}
-                onPress={handleDeactivate}>
+                {...createStaticClick(handleDeactivate)}>
                 temporarily deactivate
-              </Span>{' '}
+              </SimpleInlineLinkText>{' '}
               your account instead. Your profile, posts, feeds, and lists will
               no longer be visible to other Bluesky users. You can reactivate
               your account at any time by logging in.
@@ -262,24 +259,20 @@ function DeleteAccountDialogInner({
             {emailSentCount > 1 ? (
               <Trans>
                 Email sent!{' '}
-                <InlineLinkText
+                <SimpleInlineLinkText
-                  label={_(msg`Resend`)}
+                  label={_(msg`Click here to resend the email`)}
-                  {...createStaticClick(() => {
+                  {...createStaticClick(handleSendEmail)}>
-                    void handleSendEmail()
-                  })}>
                   Click here to resend.
-                </InlineLinkText>
+                </SimpleInlineLinkText>
               </Trans>
             ) : (
               <Trans>
                 Don’t see a code?{' '}
-                <InlineLinkText
+                <SimpleInlineLinkText
-                  label={_(msg`Resend`)}
+                  label={_(msg`Click here to resend the email`)}
-                  {...createStaticClick(() => {
+                  {...createStaticClick(handleSendEmail)}>
-                    void handleSendEmail()
-                  })}>
                   Click here to resend.
-                </InlineLinkText>
+                </SimpleInlineLinkText>
               </Trans>
             )}{' '}
             <Span style={{top: 1}}>
@@ -340,12 +333,11 @@ function DeleteAccountDialogInner({
                   {currentHandle}
                 </Span>{' '}
                 and all associated data. Note that this will affect any other{' '}
-                <InlineLinkText
+                <SimpleInlineLinkText
-                  label={_(msg`Learn more about the AT Protocol.`)}
+                  to="https://bsky.social/about/faq"
-                  style={[a.text_md]}
+                  label={_(msg`AT Protocol FAQ`)}>
-                  to="https://bsky.social/about/faq">
                   AT Protocol
-                </InlineLinkText>{' '}
+                </SimpleInlineLinkText>{' '}
                 services you use with this account.
               </Trans>
             </Prompt.DescriptionText>