Fix pinned feeds mutation issue (#2016)

src/view/screens/Home.tsx

@@ -57,9 +57,7 @@ function HomeScreenReady({
       }
     }
     return feeds
-    // TODO careful, needed to disabled this -esb
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [preferences.feeds.pinned, pinnedFeedOrderKey])
+  }, [preferences.feeds.pinned])
 
   const homeFeedParams = React.useMemo<FeedParams>(() => {
     return {

src/view/screens/SavedFeeds.tsx

@@ -185,7 +185,8 @@ function ListItem({
       queryClient.getQueryData<UsePreferencesQueryResponse>(
         preferencesQueryKey,
       )?.feeds
-    const pinned = feeds?.pinned ?? []
+    // create new array, do not mutate
+    const pinned = feeds?.pinned ? [...feeds.pinned] : []
     const index = pinned.indexOf(feedUri)
 
     if (index === -1 || index === 0) return
@@ -210,7 +211,8 @@ function ListItem({
       queryClient.getQueryData<UsePreferencesQueryResponse>(
         preferencesQueryKey,
       )?.feeds
-    const pinned = feeds?.pinned ?? []
+    // create new array, do not mutate
+    const pinned = feeds?.pinned ? [...feeds.pinned] : []
     const index = pinned.indexOf(feedUri)
 
     if (index === -1 || index >= pinned.length - 1) return