From 78b374b43d86318b32dd905d2de1604c5b113b4e Mon Sep 17 00:00:00 2001 From: Bryan Lee <38807139+liby@users.noreply.github.com> Date: Sun, 15 Oct 2023 06:26:26 +0800 Subject: [PATCH 1/2] Improved accessibility and interaction for waitlist Link in `Step2` component --- src/view/com/auth/create/Step2.tsx | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/view/com/auth/create/Step2.tsx b/src/view/com/auth/create/Step2.tsx index 83b0aee405..695c40cb8c 100644 --- a/src/view/com/auth/create/Step2.tsx +++ b/src/view/com/auth/create/Step2.tsx @@ -11,6 +11,7 @@ import {TextInput} from '../util/TextInput' import {Policies} from './Policies' import {ErrorMessage} from 'view/com/util/error/ErrorMessage' import {useStores} from 'state/index' +import {isWeb} from 'platform/detection' /** STEP 2: Your account * @field Invite code or waitlist @@ -60,10 +61,11 @@ export const Step2 = observer(function Step2Impl({ Don't have an invite code?{' '} - Join the waitlist. + + Join the waitlist. + ) : ( @@ -151,4 +153,8 @@ const styles = StyleSheet.create({ borderRadius: 6, paddingVertical: 14, }, + // @ts-expect-error: Suppressing error due to incomplete `ViewStyle` type definition in react-native-web, missing `cursor` prop as discussed in https://github.com/necolas/react-native-web/issues/832. + touchable: { + ...(isWeb && {cursor: 'pointer'}), + }, }) From 074719397787fb02305d5b2ed71b7fbace9d309c Mon Sep 17 00:00:00 2001 From: Paul Frazee Date: Mon, 30 Oct 2023 18:06:31 -0700 Subject: [PATCH 2/2] Fix a11y prop --- src/view/com/auth/create/Step2.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/view/com/auth/create/Step2.tsx b/src/view/com/auth/create/Step2.tsx index 695c40cb8c..60e1975648 100644 --- a/src/view/com/auth/create/Step2.tsx +++ b/src/view/com/auth/create/Step2.tsx @@ -61,8 +61,8 @@ export const Step2 = observer(function Step2Impl({ Don't have an invite code?{' '} + accessibilityLabel="Join the waitlist." + accessibilityHint=""> Join the waitlist.