From b7b46ea6fb13907ed5d52b09cd5242f2aaba515a Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sat, 23 Dec 2023 01:53:46 +0000 Subject: [PATCH] Fixes and types --- src/view/com/pager/Pager.tsx | 1 + src/view/com/pager/PagerWithHeader.web.tsx | 2 +- src/view/com/util/Views.web.tsx | 10 ++++------ src/view/screens/PostThread.tsx | 1 + 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/view/com/pager/Pager.tsx b/src/view/com/pager/Pager.tsx index 61c3609f29..834b1c0d01 100644 --- a/src/view/com/pager/Pager.tsx +++ b/src/view/com/pager/Pager.tsx @@ -17,6 +17,7 @@ export interface PagerRef { export interface RenderTabBarFnProps { selectedPage: number onSelect?: (index: number) => void + tabBarAnchor?: JSX.Element | null | undefined // Ignored on native. } export type RenderTabBarFn = (props: RenderTabBarFnProps) => JSX.Element diff --git a/src/view/com/pager/PagerWithHeader.web.tsx b/src/view/com/pager/PagerWithHeader.web.tsx index 4b2aa32d45..0a18a9e7dc 100644 --- a/src/view/com/pager/PagerWithHeader.web.tsx +++ b/src/view/com/pager/PagerWithHeader.web.tsx @@ -107,7 +107,7 @@ let PagerTabBar = ({ renderHeader?: () => JSX.Element onCurrentPageSelected?: (index: number) => void onSelect?: (index: number) => void - tabBarAnchor?: JSX.Element + tabBarAnchor?: JSX.Element | null | undefined }): React.ReactNode => { const pal = usePalette('default') const {isMobile} = useWebMediaQueries() diff --git a/src/view/com/util/Views.web.tsx b/src/view/com/util/Views.web.tsx index 65cf1a5c10..db3b9de0d8 100644 --- a/src/view/com/util/Views.web.tsx +++ b/src/view/com/util/Views.web.tsx @@ -150,6 +150,8 @@ const styles = StyleSheet.create({ contentContainer: { borderLeftWidth: 1, borderRightWidth: 1, + // @ts-ignore web only + minHeight: '100vh', }, container: { width: '100%', @@ -163,12 +165,8 @@ const styles = StyleSheet.create({ marginLeft: 'auto', marginRight: 'auto', }, - row: { - // @ts-ignore web - contentVisibility: 'auto', - }, - minHeightViewport: { + fixedHeight: { // @ts-ignore web only - minHeight: '100vh', + height: '100vh', }, }) diff --git a/src/view/screens/PostThread.tsx b/src/view/screens/PostThread.tsx index c61287a25d..4766cc3f74 100644 --- a/src/view/screens/PostThread.tsx +++ b/src/view/screens/PostThread.tsx @@ -110,6 +110,7 @@ export function PostThreadScreen({route}: Props) { const styles = StyleSheet.create({ prompt: { + // @ts-ignore web-only position: isWeb ? 'fixed' : 'absolute', left: 0, right: 0,