From af2aaa1f39137c7e1e4926efaa6540942f607cf4 Mon Sep 17 00:00:00 2001 From: Hailey Date: Wed, 5 Jun 2024 09:03:40 -0700 Subject: [PATCH 1/2] add types for `desktopFixedHeight` to `List` (#4356) * add types for `desktopFixedHeight` * nit * accept both `number` and `boolean` --- src/view/com/util/List.tsx | 1 + src/view/com/util/List.web.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/view/com/util/List.tsx b/src/view/com/util/List.tsx index 22d0949129..ed43ed5f0d 100644 --- a/src/view/com/util/List.tsx +++ b/src/view/com/util/List.tsx @@ -25,6 +25,7 @@ export type ListProps = Omit< onRefresh?: () => void onItemSeen?: (item: ItemT) => void containWeb?: boolean + desktopFixedHeight?: number | boolean sideBorders?: boolean // Web only prop to disable a perf optimization (which would otherwise be on). disableContentVisibility?: boolean diff --git a/src/view/com/util/List.web.tsx b/src/view/com/util/List.web.tsx index d4bd1b0039..6b0c17762c 100644 --- a/src/view/com/util/List.web.tsx +++ b/src/view/com/util/List.web.tsx @@ -22,7 +22,7 @@ export type ListProps = Omit< refreshing?: boolean onRefresh?: () => void onItemSeen?: (item: ItemT) => void - desktopFixedHeight: any // TODO: Better types. + desktopFixedHeight?: number | boolean containWeb?: boolean sideBorders?: boolean disableContentVisibility?: boolean From aefbab3850fe23cad45026ae6bdaaffdc92699ca Mon Sep 17 00:00:00 2001 From: Hailey Date: Wed, 5 Jun 2024 09:05:25 -0700 Subject: [PATCH 2/2] Remove `expo-constants` (#4371) --- package.json | 1 - yarn.lock | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index bca0d74590..26a61f0577 100644 --- a/package.json +++ b/package.json @@ -116,7 +116,6 @@ "expo-build-properties": "^0.12.1", "expo-camera": "~15.0.9", "expo-clipboard": "^6.0.3", - "expo-constants": "~16.0.1", "expo-dev-client": "^4.0.14", "expo-device": "~6.0.2", "expo-file-system": "^17.0.1", diff --git a/yarn.lock b/yarn.lock index fc29b2a205..792c74a4d8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -12083,7 +12083,7 @@ expo-constants@^13.0.2: "@expo/config" "~7.0.0" uuid "^3.3.2" -expo-constants@~16.0.0, expo-constants@~16.0.1: +expo-constants@~16.0.0: version "16.0.1" resolved "https://registry.yarnpkg.com/expo-constants/-/expo-constants-16.0.1.tgz#1285e29c85513c6e88e118289e2baab72596d3f7" integrity sha512-s6aTHtglp926EsugWtxN7KnpSsE9FCEjb7CgEjQQ78Gpu4btj4wB+IXot2tlqNwqv+x7xFe5veoPGfJDGF/kVg==