From b4412f333381504f6e93ebbfb3f2b9fa9dab892d Mon Sep 17 00:00:00 2001 From: dan Date: Sun, 10 Nov 2024 20:30:31 +0000 Subject: [PATCH] Fix render loop on Android (#6213) --- .../components/ImageItem/ImageItem.android.tsx | 12 ++++++++---- .../components/ImageItem/ImageItem.ios.tsx | 12 ++++++++---- src/view/com/util/images/AutoSizedImage.tsx | 10 +++++++--- 3 files changed, 23 insertions(+), 11 deletions(-) diff --git a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx index 4652cb606b..260787d2f3 100644 --- a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx +++ b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.android.tsx @@ -396,10 +396,14 @@ const ImageItem = ({ placeholderContentFit="cover" placeholder={{uri: imageSrc.thumbUri}} accessibilityLabel={imageSrc.alt} - onLoad={e => { - setHasLoaded(true) - onLoad({width: e.source.width, height: e.source.height}) - }} + onLoad={ + hasLoaded + ? undefined + : e => { + setHasLoaded(true) + onLoad({width: e.source.width, height: e.source.height}) + } + } style={{flex: 1, borderRadius}} accessibilityHint="" accessibilityIgnoresInvertColors diff --git a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx index e6ec64c3d7..f06a59ed60 100644 --- a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx +++ b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx @@ -228,10 +228,14 @@ const ImageItem = ({ accessibilityHint="" enableLiveTextInteraction={showControls && !scaled} accessibilityIgnoresInvertColors - onLoad={e => { - setHasLoaded(true) - onLoad({width: e.source.width, height: e.source.height}) - }} + onLoad={ + hasLoaded + ? undefined + : e => { + setHasLoaded(true) + onLoad({width: e.source.width, height: e.source.height}) + } + } /> diff --git a/src/view/com/util/images/AutoSizedImage.tsx b/src/view/com/util/images/AutoSizedImage.tsx index b82bab8795..fe8911e31c 100644 --- a/src/view/com/util/images/AutoSizedImage.tsx +++ b/src/view/com/util/images/AutoSizedImage.tsx @@ -113,9 +113,13 @@ export function AutoSizedImage({ accessibilityIgnoresInvertColors accessibilityLabel={image.alt} accessibilityHint="" - onLoad={e => { - setFetchedDims({width: e.source.width, height: e.source.height}) - }} + onLoad={ + fetchedDims + ? undefined + : e => { + setFetchedDims({width: e.source.width, height: e.source.height}) + } + } />