From a6c99b1c459c381d29fc9fae45aa7bab444bd853 Mon Sep 17 00:00:00 2001 From: Eric Bailey Date: Tue, 4 Jun 2024 17:40:03 -0500 Subject: [PATCH] Clarify some things --- docs/deploy-ota.md | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/docs/deploy-ota.md b/docs/deploy-ota.md index e92aebd39c..4572e3de6c 100644 --- a/docs/deploy-ota.md +++ b/docs/deploy-ota.md @@ -19,7 +19,7 @@ testing as well as retrieving the build number. - You should have signed in to EAS locally through npx eas login. You will need to modify the build number in a subsequent step. - Identify the build number of the production app you want to deploy an update for. iOS and Android build numbers are -divergent, so you will need to find both +divergent, so you will need to find both. Save these build numbers for later steps. ![app-build-number](./img/app-build-number.png) @@ -38,14 +38,17 @@ to create your branch from, this should be properly set. ### Deployment -- Update the build number through EAS +- Update the build number through EAS to match the build numbers of the + production iOS/Android apps - Note: This isn’t strictly necessary, but having a step that takes you off of GitHub and into the terminal provides a little “friction” to avoid fat fingering a release. Since there are legitimate reasons to just “click and deploy” for internal builds, I felt it useful to make sure it doesn’t accidentally become a prod deployment. - - Set the build number to the appropriate build number found in the prerequisite steps. Again, this should be the + - Set the build numbers to the values found in the prerequisite steps. Again, this should be the build number for the current production release you want to deploy for. - `npx eas build:version:set -p ios` - `npx eas build:version:set -p android` + - These steps should spit out what the current build number is, save those values + for later too - Run the deployment - Navigate to https://github.com/bluesky-social/social-app/actions/workflows/bundle-deploy-eas-update.yml - Select the “Run Workflow” dropdown @@ -79,3 +82,9 @@ In about five minutes, the new deployment should be available for download. To t - Launch the app once and wait approximately 15 seconds - Relaunch the app - Check the Settings page and scroll to the bottom. The commit hash should now be the latest commit on your deployed branch. + +### Post Deployment + +- Reset both platforms build numbers to what they were before the OTA + deployment. These values should have been logged by the EAS CLI when you + reset them to the production values prior to OTA.