From a25ce546180e3d79514c50a857e65d09deb9e335 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Wed, 8 Oct 2025 17:07:18 +0300 Subject: [PATCH] fix unused variable errors --- src/components/dialogs/StarterPackDialog.tsx | 2 +- src/components/intents/VerifyEmailIntentDialog.tsx | 2 +- src/lib/link-meta/link-meta.ts | 4 ++-- src/lib/react-query.tsx | 2 +- src/lib/strings/embed-player.ts | 2 +- src/lib/strings/starter-pack.ts | 4 ++-- src/lib/strings/url-helpers.ts | 6 +++--- src/logger/bitdrift/setup/index.ts | 2 +- src/screens/Settings/InterestsSettings.tsx | 2 +- src/screens/Signup/StepCaptcha/CaptchaWebView.web.tsx | 2 +- src/state/persisted/index.web.ts | 8 ++++---- src/state/queries/service-config.ts | 3 ++- src/state/queries/tenor.ts | 2 +- src/state/session/util.ts | 2 +- .../com/composer/text-input/web/useWebPreloadEmoji.ts | 2 +- src/view/com/notifications/NotificationFeedItem.tsx | 2 +- src/view/shell/desktop/LeftNav.tsx | 2 +- src/view/shell/desktop/RightNav.tsx | 2 +- 18 files changed, 26 insertions(+), 25 deletions(-) diff --git a/src/components/dialogs/StarterPackDialog.tsx b/src/components/dialogs/StarterPackDialog.tsx index ae225a0d1d..f31a7f42a7 100644 --- a/src/components/dialogs/StarterPackDialog.tsx +++ b/src/components/dialogs/StarterPackDialog.tsx @@ -148,7 +148,7 @@ function StarterPackList({ if (isFetchingNextPage || !hasNextPage || isError) return try { await fetchNextPage() - } catch (err) { + } catch { // Error handling is optional since this is just pagination } }, [isFetchingNextPage, hasNextPage, isError, fetchNextPage]) diff --git a/src/components/intents/VerifyEmailIntentDialog.tsx b/src/components/intents/VerifyEmailIntentDialog.tsx index 3aca1b6d82..6427ccbb91 100644 --- a/src/components/intents/VerifyEmailIntentDialog.tsx +++ b/src/components/intents/VerifyEmailIntentDialog.tsx @@ -49,7 +49,7 @@ function Inner({}: {control: DialogControlProps}) { token: state.code.trim(), }) setStatus('success') - } catch (e) { + } catch { setStatus('failure') } })() diff --git a/src/lib/link-meta/link-meta.ts b/src/lib/link-meta/link-meta.ts index 3d9a695f05..900ecea9f8 100644 --- a/src/lib/link-meta/link-meta.ts +++ b/src/lib/link-meta/link-meta.ts @@ -50,7 +50,7 @@ export async function getLinkMeta( // follow redirects for soundcloud shortlinks // QUESTION - do we want to follow redirects in other cases? -sfn shouldFollowRedirect = urlp.hostname === 'on.soundcloud.com' - } catch (e) { + } catch { return { error: 'Invalid URL', likelyType: LikelyType.Other, @@ -107,7 +107,7 @@ export function getLikelyType(url: URL | string): LikelyType { if (typeof url === 'string') { try { url = new URL(url) - } catch (e) { + } catch { return LikelyType.Other } } diff --git a/src/lib/react-query.tsx b/src/lib/react-query.tsx index fe3ec6f4c7..396f9cf0b1 100644 --- a/src/lib/react-query.tsx +++ b/src/lib/react-query.tsx @@ -32,7 +32,7 @@ async function checkIsOnline(): Promise { } else { return false } - } catch (e) { + } catch { return false } } diff --git a/src/lib/strings/embed-player.ts b/src/lib/strings/embed-player.ts index a7ce441fcc..23aa578ddb 100644 --- a/src/lib/strings/embed-player.ts +++ b/src/lib/strings/embed-player.ts @@ -81,7 +81,7 @@ export function parseEmbedPlayerFromUrl( let urlp try { urlp = new URL(url) - } catch (e) { + } catch { return undefined } diff --git a/src/lib/strings/starter-pack.ts b/src/lib/strings/starter-pack.ts index 475b000336..1187a077f9 100644 --- a/src/lib/strings/starter-pack.ts +++ b/src/lib/strings/starter-pack.ts @@ -21,7 +21,7 @@ export function createStarterPackLinkFromAndroidReferrer( if (contentParts.length !== 3) return null return `at://${contentParts[1]}/app.bsky.graph.starterpack/${contentParts[2]}` - } catch (e) { + } catch { return null } } @@ -56,7 +56,7 @@ export function parseStarterPackUri(uri?: string): { rkey, } } - } catch (e) { + } catch { return null } } diff --git a/src/lib/strings/url-helpers.ts b/src/lib/strings/url-helpers.ts index 288f428c10..31edbf2c87 100644 --- a/src/lib/strings/url-helpers.ts +++ b/src/lib/strings/url-helpers.ts @@ -55,7 +55,7 @@ export function toNiceDomain(url: string): string { return 'Bluesky Social' } return urlp.host ? urlp.host : url - } catch (e) { + } catch { return url } } @@ -72,7 +72,7 @@ export function toShortUrl(url: string): string { return urlp.host + path.slice(0, 13) + '...' } return urlp.host + path - } catch (e) { + } catch { return url } } @@ -364,7 +364,7 @@ export function getHostnameFromUrl(url: string | URL): string | null { let urlp try { urlp = new URL(url) - } catch (e) { + } catch { return null } return urlp.hostname diff --git a/src/logger/bitdrift/setup/index.ts b/src/logger/bitdrift/setup/index.ts index dd2560acc6..1074df40c2 100644 --- a/src/logger/bitdrift/setup/index.ts +++ b/src/logger/bitdrift/setup/index.ts @@ -14,7 +14,7 @@ initPromise.then(() => { if (Statsig.checkGate('enable_bitdrift_v2_networking')) { isNetworkEnabled = true } - } catch (e) { + } catch { // Statsig may complain about it being called too early. } if (isEnabled && BITDRIFT_API_KEY) { diff --git a/src/screens/Settings/InterestsSettings.tsx b/src/screens/Settings/InterestsSettings.tsx index 4ecaba2884..54ffa5326c 100644 --- a/src/screens/Settings/InterestsSettings.tsx +++ b/src/screens/Settings/InterestsSettings.tsx @@ -126,7 +126,7 @@ function Inner({ }), ), ) - } catch (error) { + } catch { Toast.show( _( msg({ diff --git a/src/screens/Signup/StepCaptcha/CaptchaWebView.web.tsx b/src/screens/Signup/StepCaptcha/CaptchaWebView.web.tsx index 8faaf90a03..2904374465 100644 --- a/src/screens/Signup/StepCaptcha/CaptchaWebView.web.tsx +++ b/src/screens/Signup/StepCaptcha/CaptchaWebView.web.tsx @@ -48,7 +48,7 @@ export function CaptchaWebView({ return } onSuccess(code) - } catch (e: unknown) { + } catch { // We don't actually want to record an error here, because this will happen quite a bit. We will only be able to // get hte href of the iframe if it's on our domain, so all the hcaptcha requests will throw here, although it's // harmless. Our other indicators of time-to-complete and back press should be more reliable in catching issues. diff --git a/src/state/persisted/index.web.ts b/src/state/persisted/index.web.ts index 49fa224c05..543f0f6f73 100644 --- a/src/state/persisted/index.web.ts +++ b/src/state/persisted/index.web.ts @@ -55,7 +55,7 @@ export async function write( // This is good mostly because it avoids useless broadcasts to other tabs. return } - } catch (e) { + } catch { // Ignore and go through the normal path. } _state = normalizeData({ @@ -85,7 +85,7 @@ onUpdate satisfies PersistedApi['onUpdate'] export async function clearStorage() { try { localStorage.removeItem(BSKY_STORAGE) - } catch (e: any) { + } catch { // Expected on the web in private mode. } } @@ -133,7 +133,7 @@ function writeToStorage(value: Schema) { if (rawData) { try { localStorage.setItem(BSKY_STORAGE, rawData) - } catch (e) { + } catch { // Expected on the web in private mode. } } @@ -145,7 +145,7 @@ function readFromStorage(): Schema | undefined { let rawData: string | null = null try { rawData = localStorage.getItem(BSKY_STORAGE) - } catch (e) { + } catch { // Expected on the web in private mode. } if (rawData) { diff --git a/src/state/queries/service-config.ts b/src/state/queries/service-config.ts index 890a49a5cf..e9f1869b47 100644 --- a/src/state/queries/service-config.ts +++ b/src/state/queries/service-config.ts @@ -27,7 +27,8 @@ export function useServiceConfigQuery() { topicsEnabled: Boolean(data.topicsEnabled), liveNow: data.liveNow ?? [], } - } catch (e) { + } catch (err) { + console.error('Failed to fetch service config', err) return { checkEmailConfirmed: false, topicsEnabled: false, diff --git a/src/state/queries/tenor.ts b/src/state/queries/tenor.ts index 3379d5dfb2..9d6411d71c 100644 --- a/src/state/queries/tenor.ts +++ b/src/state/queries/tenor.ts @@ -91,7 +91,7 @@ export function tenorUrlToBskyGifUrl(tenorUrl: string) { let url try { url = new URL(tenorUrl) - } catch (e) { + } catch { logger.debug('invalid url passed to tenorUrlToBskyGifUrl()') return '' } diff --git a/src/state/session/util.ts b/src/state/session/util.ts index c1d66f793c..be0cd15d09 100644 --- a/src/state/session/util.ts +++ b/src/state/session/util.ts @@ -30,7 +30,7 @@ export function isSessionExpired(account: SessionAccount) { return didExpire } } - } catch (e) { + } catch { logger.error(`session: could not decode jwt`) } return true diff --git a/src/view/com/composer/text-input/web/useWebPreloadEmoji.ts b/src/view/com/composer/text-input/web/useWebPreloadEmoji.ts index 08f18d94bd..e0eb3a3cfb 100644 --- a/src/view/com/composer/text-input/web/useWebPreloadEmoji.ts +++ b/src/view/com/composer/text-input/web/useWebPreloadEmoji.ts @@ -17,7 +17,7 @@ export function useWebPreloadEmoji({immediate}: {immediate?: boolean} = {}) { try { const data = (await import('./EmojiPickerData.json')).default init({data}) - } catch (e) {} + } catch {} }, []) if (immediate) preload() return preload diff --git a/src/view/com/notifications/NotificationFeedItem.tsx b/src/view/com/notifications/NotificationFeedItem.tsx index 8f33f4b796..971b2d0872 100644 --- a/src/view/com/notifications/NotificationFeedItem.tsx +++ b/src/view/com/notifications/NotificationFeedItem.tsx @@ -322,7 +322,7 @@ let NotificationFeedItem = ({ try { const rkey = new AtUri(item.notification.author.viewer.following).rkey followingTimestamp = TID.fromStr(rkey).timestamp() - } catch (e) { + } catch { // For some reason the following URI was invalid. Default to it not being a follow back. console.error('Invalid following URI') } diff --git a/src/view/shell/desktop/LeftNav.tsx b/src/view/shell/desktop/LeftNav.tsx index 2c44a5b00f..62171159a6 100644 --- a/src/view/shell/desktop/LeftNav.tsx +++ b/src/view/shell/desktop/LeftNav.tsx @@ -539,7 +539,7 @@ function ComposeBtn() { try { setIsFetchingHandle(true) handle = await fetchHandle(handle) - } catch (e) { + } catch { handle = undefined } finally { setIsFetchingHandle(false) diff --git a/src/view/shell/desktop/RightNav.tsx b/src/view/shell/desktop/RightNav.tsx index 1e000340af..9d325317b4 100644 --- a/src/view/shell/desktop/RightNav.tsx +++ b/src/view/shell/desktop/RightNav.tsx @@ -34,7 +34,7 @@ function useWebQueryParams() { const {state} = e.data const lastRoute = state.routes[state.routes.length - 1] setParams(lastRoute.params) - } catch (err) {} + } catch {} }) }, [navigation, setParams])