From a14228fd06c1020c58531e31661fa89fc35a5f63 Mon Sep 17 00:00:00 2001
From: Samuel Newman <mozzius@protonmail.com>
Date: Tue, 1 Jul 2025 12:24:01 +0300
Subject: [PATCH] add list footer to list list

---
 src/components/Lists.tsx             |  4 +-
 src/components/dialogs/GifSelect.tsx |  4 +-
 src/view/com/lists/MyLists.tsx       | 93 ++++++++++------------------
 3 files changed, 36 insertions(+), 65 deletions(-)

diff --git a/src/components/Lists.tsx b/src/components/Lists.tsx
index 5c602249ba..225670119e 100644
--- a/src/components/Lists.tsx
+++ b/src/components/Lists.tsx
@@ -1,5 +1,5 @@
-import React, {memo} from 'react'
-import {StyleProp, View, ViewStyle} from 'react-native'
+import {memo} from 'react'
+import {type StyleProp, View, type ViewStyle} from 'react-native'
 import {msg, Trans} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 
diff --git a/src/components/dialogs/GifSelect.tsx b/src/components/dialogs/GifSelect.tsx
index d880708b54..15c1ba26e8 100644
--- a/src/components/dialogs/GifSelect.tsx
+++ b/src/components/dialogs/GifSelect.tsx
@@ -1,4 +1,4 @@
-import React, {
+import {
   useCallback,
   useImperativeHandle,
   useMemo,
@@ -119,7 +119,7 @@ function GifList({
     [onSelectGif],
   )
 
-  const onEndReached = React.useCallback(() => {
+  const onEndReached = useCallback(() => {
     if (isFetchingNextPage || !hasNextPage || error) return
     fetchNextPage()
   }, [isFetchingNextPage, hasNextPage, error, fetchNextPage])
diff --git a/src/view/com/lists/MyLists.tsx b/src/view/com/lists/MyLists.tsx
index 5f94946e8b..0d161285e8 100644
--- a/src/view/com/lists/MyLists.tsx
+++ b/src/view/com/lists/MyLists.tsx
@@ -1,28 +1,25 @@
-import React from 'react'
+import {useCallback, useMemo, useState} from 'react'
 import {
   ActivityIndicator,
-  FlatList as RNFlatList,
-  RefreshControl,
-  StyleProp,
+  type StyleProp,
   View,
-  ViewStyle,
+  type ViewStyle,
 } from 'react-native'
-import {AppBskyGraphDefs as GraphDefs} from '@atproto/api'
+import {type AppBskyGraphDefs as GraphDefs} from '@atproto/api'
 import {msg} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 
-import {usePalette} from '#/lib/hooks/usePalette'
 import {cleanError} from '#/lib/strings/errors'
-import {s} from '#/lib/styles'
 import {logger} from '#/logger'
 import {useModerationOpts} from '#/state/preferences/moderation-opts'
-import {MyListsFilter, useMyListsQuery} from '#/state/queries/my-lists'
+import {type MyListsFilter, useMyListsQuery} from '#/state/queries/my-lists'
+import {ErrorMessage} from '#/view/com/util/error/ErrorMessage'
+import {List} from '#/view/com/util/List'
 import {atoms as a, useTheme} from '#/alf'
 import {BulletList_Stroke2_Corner0_Rounded as ListIcon} from '#/components/icons/BulletList'
 import * as ListCard from '#/components/ListCard'
+import {ListFooter} from '#/components/Lists'
 import {Text} from '#/components/Typography'
-import {ErrorMessage} from '../util/error/ErrorMessage'
-import {List} from '../util/List'
 
 const LOADING = {_reactKey: '__loading__'}
 const EMPTY = {_reactKey: '__empty__'}
@@ -30,27 +27,24 @@ const ERROR_ITEM = {_reactKey: '__error__'}
 
 export function MyLists({
   filter,
-  inline,
   style,
   renderItem,
   testID,
 }: {
   filter: MyListsFilter
-  inline?: boolean
   style?: StyleProp<ViewStyle>
   renderItem?: (list: GraphDefs.ListView, index: number) => JSX.Element
   testID?: string
 }) {
-  const pal = usePalette('default')
   const t = useTheme()
   const {_} = useLingui()
   const moderationOpts = useModerationOpts()
-  const [isPTRing, setIsPTRing] = React.useState(false)
+  const [isPTRing, setIsPTRing] = useState(false)
   const {data, isFetching, isFetched, isError, error, refetch} =
     useMyListsQuery(filter)
   const isEmpty = !isFetching && !data?.length
 
-  const items = React.useMemo(() => {
+  const items = useMemo(() => {
     let items: any[] = []
     if (isError && isEmpty) {
       items = items.concat([ERROR_ITEM])
@@ -85,7 +79,7 @@ export function MyLists({
   // events
   // =
 
-  const onRefresh = React.useCallback(async () => {
+  const onRefresh = useCallback(async () => {
     setIsPTRing(true)
     try {
       await refetch()
@@ -98,7 +92,7 @@ export function MyLists({
   // rendering
   // =
 
-  const renderItemInner = React.useCallback(
+  const renderItemInner = useCallback(
     ({item, index}: {item: any; index: number}) => {
       if (item === EMPTY) {
         return (
@@ -162,47 +156,24 @@ export function MyLists({
     [t, renderItem, error, onRefresh, emptyText],
   )
 
-  if (inline) {
-    return (
-      <View testID={testID} style={style}>
-        {items.length > 0 && (
-          <RNFlatList
-            testID={testID ? `${testID}-flatlist` : undefined}
-            data={items}
-            keyExtractor={item => (item.uri ? item.uri : item._reactKey)}
-            renderItem={renderItemInner}
-            refreshControl={
-              <RefreshControl
-                refreshing={isPTRing}
-                onRefresh={onRefresh}
-                tintColor={pal.colors.text}
-                titleColor={pal.colors.text}
-              />
-            }
-            contentContainerStyle={[s.contentContainer]}
-            removeClippedSubviews={true}
-          />
-        )}
-      </View>
-    )
-  } else {
-    return (
-      <View testID={testID} style={style}>
-        {items.length > 0 && (
-          <List
-            testID={testID ? `${testID}-flatlist` : undefined}
-            data={items}
-            keyExtractor={item => (item.uri ? item.uri : item._reactKey)}
-            renderItem={renderItemInner}
-            refreshing={isPTRing}
-            onRefresh={onRefresh}
-            contentContainerStyle={[s.contentContainer]}
-            removeClippedSubviews={true}
-            desktopFixedHeight
-            sideBorders={false}
-          />
-        )}
-      </View>
-    )
-  }
+  return (
+    <View testID={testID} style={style}>
+      {items.length > 0 && (
+        <List
+          testID={testID ? `${testID}-flatlist` : undefined}
+          data={items}
+          keyExtractor={item => (item.uri ? item.uri : item._reactKey)}
+          renderItem={renderItemInner}
+          refreshing={isPTRing}
+          onRefresh={onRefresh}
+          removeClippedSubviews={true}
+          desktopFixedHeight
+          sideBorders={false}
+          ListFooterComponent={
+            <ListFooter error={cleanError(error)} onRetry={refetch} />
+          }
+        />
+      )}
+    </View>
+  )
 }