diff --git a/src/components/Dialog/index.tsx b/src/components/Dialog/index.tsx index 6d859aeb0b..a27271168c 100644 --- a/src/components/Dialog/index.tsx +++ b/src/components/Dialog/index.tsx @@ -153,18 +153,18 @@ export function Outer({ ) return ( - - + + {children} - - + + ) } diff --git a/src/components/Dialog/types.ts b/src/components/Dialog/types.ts index caa787535b..b1388a817e 100644 --- a/src/components/Dialog/types.ts +++ b/src/components/Dialog/types.ts @@ -6,7 +6,6 @@ import type { } from 'react-native' import {ViewStyleProp} from '#/alf' -import {PortalComponent} from '#/components/Portal' import {BottomSheetViewProps} from '../../../modules/bottom-sheet' import {BottomSheetSnapPoint} from '../../../modules/bottom-sheet/src/BottomSheet.types' @@ -61,7 +60,6 @@ export type DialogOuterProps = { nativeOptions?: Omit webOptions?: {} testID?: string - Portal?: PortalComponent } type DialogInnerPropsBase = React.PropsWithChildren & T diff --git a/src/components/Menu/index.tsx b/src/components/Menu/index.tsx index 12cf1866e5..4d35a63bdb 100644 --- a/src/components/Menu/index.tsx +++ b/src/components/Menu/index.tsx @@ -18,7 +18,6 @@ import { ItemTextProps, TriggerProps, } from '#/components/Menu/types' -import {PortalComponent} from '#/components/Portal' import {Text} from '#/components/Typography' export { @@ -78,11 +77,9 @@ export function Trigger({children, label}: TriggerProps) { export function Outer({ children, showCancel, - Portal, }: React.PropsWithChildren<{ showCancel?: boolean style?: StyleProp - Portal?: PortalComponent }>) { const context = React.useContext(Context) const {_} = useLingui() @@ -90,8 +87,7 @@ export function Outer({ return ( + nativeOptions={{preventExpansion: true}}> {/* Re-wrap with context since Dialogs are portal-ed to root */} diff --git a/src/components/Portal.tsx b/src/components/Portal.tsx index 7441df005c..03b397b2b8 100644 --- a/src/components/Portal.tsx +++ b/src/components/Portal.tsx @@ -12,8 +12,6 @@ type ComponentMap = { [id: string]: Component } -export type PortalComponent = ({children}: {children?: React.ReactNode}) => null - export function createPortalGroup() { const Context = React.createContext({ outlet: null, diff --git a/src/components/Prompt.tsx b/src/components/Prompt.tsx index c47f0d64af..7b33c6e256 100644 --- a/src/components/Prompt.tsx +++ b/src/components/Prompt.tsx @@ -6,7 +6,6 @@ import {useLingui} from '@lingui/react' import {atoms as a, useBreakpoints, useTheme} from '#/alf' import {Button, ButtonColor, ButtonText} from '#/components/Button' import * as Dialog from '#/components/Dialog' -import {PortalComponent} from '#/components/Portal' import {Text} from '#/components/Typography' import {BottomSheetViewProps} from '../../modules/bottom-sheet' @@ -27,12 +26,10 @@ export function Outer({ children, control, testID, - Portal, nativeOptions, }: React.PropsWithChildren<{ control: Dialog.DialogControlProps testID?: string - Portal?: PortalComponent nativeOptions?: Omit }>) { const {gtMobile} = useBreakpoints() @@ -48,7 +45,6 @@ export function Outer({ @@ -190,7 +186,6 @@ export function Basic({ onConfirm, confirmButtonColor, showCancel = true, - Portal, }: React.PropsWithChildren<{ control: Dialog.DialogOuterProps['control'] title: string @@ -207,10 +202,9 @@ export function Basic({ onConfirm: (e: GestureResponderEvent) => void confirmButtonColor?: ButtonColor showCancel?: boolean - Portal?: PortalComponent }>) { return ( - + {title} {description} diff --git a/src/view/com/util/UserAvatar.tsx b/src/view/com/util/UserAvatar.tsx index b311f78879..dbd68f8ef5 100644 --- a/src/view/com/util/UserAvatar.tsx +++ b/src/view/com/util/UserAvatar.tsx @@ -30,7 +30,6 @@ import {Trash_Stroke2_Corner0_Rounded as Trash} from '#/components/icons/Trash' import {Link} from '#/components/Link' import {MediaInsetBorder} from '#/components/MediaInsetBorder' import * as Menu from '#/components/Menu' -import {PortalComponent} from '#/components/Portal' import {ProfileHoverCard} from '#/components/ProfileHoverCard' import {openCamera, openCropper, openPicker} from '../../../lib/media/picker' @@ -51,7 +50,6 @@ interface UserAvatarProps extends BaseUserAvatarProps { interface EditableUserAvatarProps extends BaseUserAvatarProps { onSelectNewAvatar: (img: RNImage | null) => void - Portal?: PortalComponent } interface PreviewableUserAvatarProps extends BaseUserAvatarProps { @@ -268,7 +266,6 @@ let EditableUserAvatar = ({ size, avatar, onSelectNewAvatar, - Portal, }: EditableUserAvatarProps): React.ReactNode => { const t = useTheme() const pal = usePalette('default') @@ -366,7 +363,7 @@ let EditableUserAvatar = ({ )} - + {isNative && ( void - Portal?: PortalComponent }) { const pal = usePalette('default') const theme = useTheme() @@ -118,7 +115,7 @@ export function UserBanner({ )} - + {isNative && (