acetheking987/bsky-social-app
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Fix Retain Cycles in SheetViewController (#6202)

Browse Source 
* Fix retain cycle in SheetViewController.swift

* Fix retain cycles
This commit is contained in:
Hazem Ali
2024-11-11 00:10:09 +02:00
committed by GitHub
parent b4412f3333
commit 9a10af7117
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/bottom-sheet/ios/SheetViewController.swift
+8 -5
View File
@@ -64,11 +64,14 @@ class SheetViewController: UIViewController {
func updateDetents(contentHeight: CGFloat, preventExpansion: Bool) { func updateDetents(contentHeight: CGFloat, preventExpansion: Bool) {
if let sheet = self.sheetPresentationController { if let sheet = self.sheetPresentationController {
sheet.animateChanges { // Capture `self` weakly to prevent retain cycles.
self.setDetents(contentHeight: contentHeight, preventExpansion: preventExpansion) // Also, capture `sheet` weakly to avoid potential strong references held by animateChanges.
if #available(iOS 16.0, *) { sheet.animateChanges { [weak self, weak sheet] in
sheet.invalidateDetents() guard let weakSelf = self, let weakSheet = sheet else { return }
} weakSelf.setDetents(contentHeight: contentHeight, preventExpansion: preventExpansion)
if #available(iOS 16.0, *) {
weakSheet.invalidateDetents()
}
} }
} }
} }